From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9724D3E78C for ; Wed, 6 Nov 2024 09:53:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 58F2C60652; Wed, 6 Nov 2024 09:53:59 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id fIODVBjwNlrJ; Wed, 6 Nov 2024 09:53:58 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A5F4160676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1730886838; bh=LMxbCHgkkvx5XhMu4SkqdL5emWrivIpJuB42LR9Yen4=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TRFBgibpwhN/wXmET7K3s8XcVwdU3cNDw0yK4odsogHxgsHKm5dnRP9X/JMX6v+4j dJvEgfbwbUqPMk1vnGn/hjeygN5vsKeE7yJc0tK5p5pGu7Dt4q8Q5Ry+uT8DOq/GeF FZTR8BkvFKRRrxkXDx5QsOfWlZ8ZtbCubKsIvIQDcBUhqVfqGPfaGGJ1YIaq8ydnJn VhiQUnqIxWYkabjXUOOjKn8g9ut8gol5EzMYwYsFcWoI+ptTZT9e1b3Oembpl67Ywt r1bbvMHvY2YpVuj+tY0XdRX9sDP9g5Vltx23+fe5CEm2BpUSvPsxhnAG08svuknYmF km8Cu5wTo9yMQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id A5F4160676; Wed, 6 Nov 2024 09:53:58 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 5FE843B for ; Wed, 6 Nov 2024 09:53:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 40D3760676 for ; Wed, 6 Nov 2024 09:53:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id L6Yd-ujFNqUG for ; Wed, 6 Nov 2024 09:53:55 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 972ED60652 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 972ED60652 Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp3.osuosl.org (Postfix) with ESMTPS id 972ED60652 for ; Wed, 6 Nov 2024 09:53:55 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3D6BCA42B64; Wed, 6 Nov 2024 09:51:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDE18C4CECD; Wed, 6 Nov 2024 09:53:52 +0000 (UTC) Date: Wed, 6 Nov 2024 09:53:50 +0000 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, sridhar.samudrala@intel.com Message-ID: <20241106095350.GJ4507@kernel.org> References: <20241031060009.38979-1-michal.swiatkowski@linux.intel.com> <20241031060009.38979-2-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031060009.38979-2-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730886833; bh=bPepb+/BgfiR6bYytxcaRaPssEkGU1xCaygb9x+TGik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JSfFNmNQN6bbBo3K1K4YytOYVWdAtrS2O0ewxrIUQ3317WiNL0A+gzKNNkoIsYSwJ OGpH6H0oGG9PXsjl/vj6sq3+iwLJKECncsGT5vgW4TWwmcjHrk4u6yjpY9ZWkJu3PC jYW4z5Jku1drRdlMqAwjgwVv2eRyTOyrVuojSK+2b8IXV+vbY43kjCzcu8C7FFlHCp YFetnctpz/B5n+V1RLKMV7DC/9/52CCkjI4Alj3Zq3Xpbyhdv96Ehf3p6Cg4PIet5e G0LCOFPTQfwu2igLqfty4Ad08YPP68QSzs1V13hkGq5oSJ+ks29BFl2lPiN9acC3Wu SvzOedS2KvHyA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JSfFNmNQ Subject: Re: [Intel-wired-lan] [iwl-next v1 1/3] ice: support max_io_eqs for subfunction X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Oct 31, 2024 at 07:00:07AM +0100, Michal Swiatkowski wrote: > Implement get and set for the maximum IO event queues for SF. > It is used to derive the maximum number of Rx/Tx queues on subfunction > device. > > If the value isn't set when activating set it to the low default value. > > Reviewed-by: Sridhar Samudrala > Signed-off-by: Michal Swiatkowski > --- > drivers/net/ethernet/intel/ice/devlink/port.c | 37 +++++++++++++++++++ > drivers/net/ethernet/intel/ice/ice.h | 2 + > 2 files changed, 39 insertions(+) > > diff --git a/drivers/net/ethernet/intel/ice/devlink/port.c b/drivers/net/ethernet/intel/ice/devlink/port.c ... > @@ -548,6 +575,14 @@ ice_activate_dynamic_port(struct ice_dynamic_port *dyn_port, > if (dyn_port->active) > return 0; > > + if (!dyn_port->vsi->max_io_eqs) { > + err = ice_devlink_port_fn_max_io_eqs_set(&dyn_port->devlink_port, > + ICE_SF_DEFAULT_EQS, > + extack); Hi Michal, I am a little confused about the relationship between this, where ICE_SF_DEFAULT_EQS is 8, and the following check in ice_devlink_port_fn_max_io_eqs_set(). if (max_io_eqs > num_online_cpus()) { NL_SET_ERR_MSG_MOD(extack, "Supplied value out of range"); return -EINVAL; } What is the behaviour on systems with more than 8 online CPUs? > + if (err) > + return err; > + } > + > err = ice_sf_eth_activate(dyn_port, extack); > if (err) > return err; ... > diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h > index 70d5294a558c..ca0739625d3b 100644 > --- a/drivers/net/ethernet/intel/ice/ice.h > +++ b/drivers/net/ethernet/intel/ice/ice.h > @@ -109,6 +109,7 @@ > #define ICE_Q_WAIT_MAX_RETRY (5 * ICE_Q_WAIT_RETRY_LIMIT) > #define ICE_MAX_LG_RSS_QS 256 > #define ICE_INVAL_Q_INDEX 0xffff > +#define ICE_SF_DEFAULT_EQS 8 > > #define ICE_MAX_RXQS_PER_TC 256 /* Used when setting VSI context per TC Rx queues */ > ...