Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ahmed Zaki <ahmed.zaki@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org,
	Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
	Ahmed Zaki <ahmed.zaki@intel.com>
Subject: [Intel-wired-lan] [PATCH iwl-net 2/2] idpf: finish pending IRQ handling before freeing interrupt
Date: Fri,  8 Nov 2024 17:12:06 -0700	[thread overview]
Message-ID: <20241109001206.213581-3-ahmed.zaki@intel.com> (raw)
In-Reply-To: <20241109001206.213581-1-ahmed.zaki@intel.com>

From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>

Wait for pending IRQs to be handled before an interrupt is free'd up.

Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
---
 drivers/net/ethernet/intel/idpf/idpf_txrx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
index 82e0e3698f10..08acdd383b8d 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
@@ -3584,6 +3584,7 @@ static void idpf_vport_intr_rel_irq(struct idpf_vport *vport)
 
 		/* clear the affinity_mask in the IRQ descriptor */
 		irq_set_affinity_notifier(irq_num, NULL);
+		synchronize_irq(irq_num);
 		kfree(free_irq(irq_num, q_vector));
 	}
 }
-- 
2.43.0


  parent reply	other threads:[~2024-11-09  0:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09  0:12 [Intel-wired-lan] [PATCH iwl-net 0/2] idpf: Preserve IRQ affinity and sync IRQ Ahmed Zaki
2024-11-09  0:12 ` [Intel-wired-lan] [PATCH iwl-net 1/2] idpf: preserve IRQ affinity settings across resets Ahmed Zaki
2024-11-12  2:53   ` Jakub Kicinski
2024-12-02 13:03     ` Ahmed Zaki
2024-12-02 14:26       ` Jakub Kicinski
2024-11-09  0:12 ` Ahmed Zaki [this message]
2024-11-12  2:54   ` [Intel-wired-lan] [PATCH iwl-net 2/2] idpf: finish pending IRQ handling before freeing interrupt Jakub Kicinski
2024-12-02 13:11     ` Ahmed Zaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241109001206.213581-3-ahmed.zaki@intel.com \
    --to=ahmed.zaki@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=sudheer.mogilappagari@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox