From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 953EED6DDF8 for ; Fri, 15 Nov 2024 12:45:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3C9DB40390; Fri, 15 Nov 2024 12:45:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id L-kOSrEz3pxs; Fri, 15 Nov 2024 12:45:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 460CF4030D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1731674723; bh=ghOhfYcObwPstTxN053WjSdLIkm5mznQbXq6FFQCuxs=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FCLcGrr/Tw3stPfkTEhwEzMSOlOY7eQhOsHtqg9B/6bcL47/qo5YfLSuE7L0nr3Dm MnbCiZzQUDJYS0hUD7pK6aww/xw02cYmpx9YptIpY692xITmpalklyA3vnsQ0qd2v6 eUQnpKEz0vwV6AfSE/ap63V49H+ikG3N+7s7aZtdKH5YE/TwO0s1JnjpxNt7emvtog Er0eFJ8pR/onp0CY1NBQ06sI+LQmcDxvcNrVIgwUNIa7MyG2wGBgxCDJ5Nok5jkWNe lhYNWKxQuF0HMBW2q4kbO2eL5R9rh6bJQVAabX1okyrDwQbRV/W1OgTtpT1DeTRHFo heMEUD71+D1Gw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 460CF4030D; Fri, 15 Nov 2024 12:45:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 7BE3327DF for ; Fri, 15 Nov 2024 12:45:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6A0CD60B4B for ; Fri, 15 Nov 2024 12:45:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nuesiUCxjHow for ; Fri, 15 Nov 2024 12:45:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org AFE6F60909 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AFE6F60909 Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp3.osuosl.org (Postfix) with ESMTPS id AFE6F60909 for ; Fri, 15 Nov 2024 12:45:20 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B6C05A427A6; Fri, 15 Nov 2024 12:43:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C4C0C4CECF; Fri, 15 Nov 2024 12:45:17 +0000 (UTC) Date: Fri, 15 Nov 2024 12:45:15 +0000 From: Simon Horman To: Willem de Bruijn Cc: Milena Olech , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, Emil Tantilov , Pavan Kumar Linga , Alexander Lobakin Message-ID: <20241115124515.GO1062410@kernel.org> References: <20241113154616.2493297-1-milena.olech@intel.com> <20241113154616.2493297-8-milena.olech@intel.com> <6736625792e20_3379ce2948b@willemb.c.googlers.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6736625792e20_3379ce2948b@willemb.c.googlers.com.notmuch> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731674719; bh=zMOM1PAqWE7rZ59eadQ4Q40wY9FxpTUefPj94OxfR00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RdMQlEbxjbB1mH5/lrhQKDG7URM4ArRfVUOqfnOcyA5XwTIrXyHUQB56Ws+TLW5az bSU/uxBxpEGLGhgj/v/nBhhrvEO6jQqJ9NpbrQc0V4u1pXMJHq0ihRtXaU1RA+dXyC bvR0HgDUpKuxSdvENTWyyt2KCUb+q2OJjzJ3sZDclP/W6U6CCXq4jbdl2WA2Fx8hpR 67yyJvbAedwmOAhbzrkzAUG4+NS7Fu3QXBpClOiJWlJaSeLEAhg6NkkDgpVkrI8UW0 cN03fudnFcBfXs47rdWHom2ozXps3DmxOFKPwCJb6oA7XHv8m4YT27PQqp28OEm8Tq u+pqlK6a1LIDA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=RdMQlEbx Subject: Re: [Intel-wired-lan] [PATCH iwl-net 07/10] idpf: add Tx timestamp capabilities negotiation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Nov 14, 2024 at 03:49:27PM -0500, Willem de Bruijn wrote: > Milena Olech wrote: > > Tx timestamp capabilities are negotiated for the uplink Vport. > > Driver receives information about the number of available Tx timestamp > > latches, the size of Tx timestamp value and the set of indexes used > > for Tx timestamping. > > > > Add function to get the Tx timestamp capabilities and parse the uplink > > vport flag. > > > > Co-developed-by: Emil Tantilov > > Signed-off-by: Emil Tantilov > > Co-developed-by: Pavan Kumar Linga > > Signed-off-by: Pavan Kumar Linga > > Reviewed-by: Alexander Lobakin > > Signed-off-by: Milena Olech > > A few minor points. No big concerns from me. > > > struct idpf_vc_xn_manager; > > > > +#define idpf_for_each_vport(adapter, iter) \ > > + for (struct idpf_vport **__##iter = &(adapter)->vports[0], \ > > + *iter = *__##iter; \ > > + __##iter < &(adapter)->vports[(adapter)->num_alloc_vports]; \ > > + iter = *(++__##iter)) > > + > > Perhaps more readable to just use an int: > > for (int i = 0; iter = &(adapter)->vports[i], i < (adapter)->num_alloc_vports; i++) > > > /** > > @@ -517,6 +524,60 @@ static int idpf_ptp_create_clock(const struct idpf_adapter *adapter) > > return 0; > > } > > > > +/** > > + * idpf_ptp_release_vport_tstamp - Release the Tx timestamps trakcers for a > > s/trakcers/trackers > > > +/** > > + * struct idpf_ptp_tx_tstamp - Parametrs for Tx timestamping > > s/Parametrs/Parameters > > > + * @list_member: the list member strutcure > > s/strutcure/Structure > > Please use a spell checker, don't rely on reviewers. To add to that: * Capabilities is misspelt in the subject * checkpatch.pl --codespell will spell-check the patch > > Also, going forward, IMHO documentation can be limited to APIs and > non-obvious functions/structs/fields. >