From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8B25E7717F for ; Tue, 10 Dec 2024 17:08:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 903B781234; Tue, 10 Dec 2024 17:08:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id y0yP6Tuaf-nb; Tue, 10 Dec 2024 17:08:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org EDCB081236 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1733850535; bh=eWj5KNj0YyYcp+iR74rAGs6OTDyZc6I9jRti5hsqh9g=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=0O+DAK2ruoQC90qfB3A8c9TSBlmydokGULCDhymVFaCO4pJ3m8pbU3P6Bq3CijtGt lGPoQcAy6sCkCfPZLpCKk0R+mrckmnREdcbKDqFzkNOZyDWHRrFCadJIvisPq8lc8c j24YNMeadAm1BhUS1/8U6hT1TO+0bXYdCRxllwHN/thmc33ur+MZDDZp8bSEGn0iuO BCVjSkPKdzKXwxZVNFzcXMYuC+Fra3Rl17tD+FUsAQ7DqMql/6pFJDsWzTv24RnbHa ijagvTsIX+gSACax2pIuIkVZsUCcH3fstjVzQXj6olv9FmuJKroGj6/mGA3ECAon85 zKtjK6OpNNjMA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id EDCB081236; Tue, 10 Dec 2024 17:08:54 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 332B3E11 for ; Tue, 10 Dec 2024 17:08:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 13149400EA for ; Tue, 10 Dec 2024 17:08:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yKOlvkHbw3fe for ; Tue, 10 Dec 2024 17:08:52 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 21759400BB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 21759400BB Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 21759400BB for ; Tue, 10 Dec 2024 17:08:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 62E305C5CDD; Tue, 10 Dec 2024 17:08:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23248C4CED6; Tue, 10 Dec 2024 17:08:47 +0000 (UTC) Date: Tue, 10 Dec 2024 17:08:46 +0000 From: Simon Horman To: Larysa Zaremba Message-ID: <20241210170846.GD6554@kernel.org> References: <20241209140856.277801-1-larysa.zaremba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241209140856.277801-1-larysa.zaremba@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733850530; bh=Y2Vsc9I8jXblIm8hGxv3z8aLdD8Oy15ilENKuf7CcYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ofnDEbMFjMzeKLwbusCHwIouhHE62Tpps/H0nx+myKUTHwG42TMHJ2wu/6AuaCX0X WCAT90xAF+jvDZXW8Ax6apC3qPCUwd5kpI35roavSt3GiyBt5lTY7NzK2lAJi/SFNo nfx1Hg/oFMwo+9TtmeW7pDxj2P6g1bafNBlXgICLyyhwyh5j6ASMgYc19OvHoNUoz2 oQmGirG6N0rNMeP+JnJYZ/4B/V6kXspDkb5RKsr8Csrw/QsDeaYQKimzlzfFTf2JU2 pEZkYD1Ei5S8WXwsG8j1OsAciT63lZEs4KPhuDbOl2UKH0RWjgpKiZO45eZjj8C3rs /PzQlqpoAN5RQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ofnDEbMF Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: do not configure destination override for switchdev X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Swiatkowski , Przemek Kitszel , linux-kernel@vger.kernel.org, Andrew Lunn , Eric Dumazet , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , netdev@vger.kernel.org, Tony Nguyen , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Dec 09, 2024 at 03:08:53PM +0100, Larysa Zaremba wrote: > After switchdev is enabled and disabled later, LLDP packets sending stops, > despite working perfectly fine before and during switchdev state. > To reproduce (creating/destroying VF is what triggers the reconfiguration): > > devlink dev eswitch set pci/
mode switchdev > echo '2' > /sys/class/net//device/sriov_numvfs > echo '0' > /sys/class/net//device/sriov_numvfs > > This happens because LLDP relies on the destination override functionality. > It needs to 1) set a flag in the descriptor, 2) set the VSI permission to > make it valid. The permissions are set when the PF VSI is first configured, > but switchdev then enables it for the uplink VSI (which is always the PF) > once more when configured and disables when deconfigured, which leads to > software-generated LLDP packets being blocked. > > Do not modify the destination override permissions when configuring > switchdev, as the enabled state is the default configuration that is never > modified. > > Fixes: 1a1c40df2e80 ("ice: set and release switchdev environment") > Reviewed-by: Michal Swiatkowski > Signed-off-by: Larysa Zaremba Reviewed-by: Simon Horman