From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B495AE77188 for ; Fri, 20 Dec 2024 03:42:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 68E4F80F15; Fri, 20 Dec 2024 03:42:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4WyeD0KH_p6w; Fri, 20 Dec 2024 03:42:43 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CEF9F80F1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1734666163; bh=K74pSCwfsf1TaLjZQXHZ4p2i1Azv/tuJqklFEDR5rYc=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EjdDmIebVS5tf7vX6I0y+qM34V4RW6got0RZhHDCDNVM63ObNz85M66EtyJlN6iLh wtbarJ2M8fESxE9QGdzQKZyDLj/qHUTqAiQE5fsSFixzoVDvVQoBHHzNqTYNV1uzgU vIUS4z/o5N24urPGdjk8kmSVbULgZ97gTylScPeBowywA1zlVsKmKu8XZDDzxEKP+5 9A5VlZMIEk0XmeO8VHxyqXCdWdDIecLxOcYsD8PaVZW7hjiZ7KwUrqec1lSGvci3he pymKnnSLRv9WwSN5EiE+gOUg5zRPIEvPOKV0rA2Pfs+h6QNHJ3i4nUkqBFW+7+YyHG uLKkXoW5Gvnag== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id CEF9F80F1F; Fri, 20 Dec 2024 03:42:43 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id C9593920 for ; Fri, 20 Dec 2024 03:42:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A938B40153 for ; Fri, 20 Dec 2024 03:42:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TbI4lTv-olqB for ; Fri, 20 Dec 2024 03:42:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 8FCFD40242 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8FCFD40242 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8FCFD40242 for ; Fri, 20 Dec 2024 03:42:40 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5501D5C6AAB; Fri, 20 Dec 2024 03:41:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FC31C4CECD; Fri, 20 Dec 2024 03:42:38 +0000 (UTC) Date: Thu, 19 Dec 2024 19:42:37 -0800 From: Jakub Kicinski To: Ahmed Zaki Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, davem@davemloft.net, michael.chan@broadcom.com, tariqt@nvidia.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, jdamato@fastly.com, shayd@nvidia.com, akpm@linux-foundation.org Message-ID: <20241219194237.31822cba@kernel.org> In-Reply-To: <20241218165843.744647-5-ahmed.zaki@intel.com> References: <20241218165843.744647-1-ahmed.zaki@intel.com> <20241218165843.744647-5-ahmed.zaki@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734666159; bh=fnImh29yoKImg9f1jUzjkpruOXk0v2PvXOnZJPACOFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JMNOTu2v8Xg3DzOhrHjiZuyQbDFlSCSy1rhNXN02tOCsEYU8vdb37WbOSX4UNR0H1 wtqvdCvJXmOicL5T8F1SNZh0THSic2U0JeHbWR58kqSdgnUHY/Z+0dSLnYaS1EC4+S Vy6mTVs7w8Ht1LLHeA48N3Fn9YaKJB6vZBIF2qHRwTjIM2faRA3FwSUeQm8S9Yh5CS Lj/LHORn4r9yWja+4CyqJpixEJ1A7xC/rUT+ISZCC6uAuZMticlgsRNQdKzSUW2Rne 0WrYzHBQCOR5z2kBHVqW9gm+9ZYtmuRlujfVUqKtL8H1KsRGvgK+L6rKbYFFIoeVd1 Ia/o+ppIuC5uw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JMNOTu2v Subject: Re: [Intel-wired-lan] [PATCH net-next v2 4/8] net: napi: add CPU affinity to napi->config X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 18 Dec 2024 09:58:39 -0700 Ahmed Zaki wrote: > + if (!glue_created && flags & NAPIF_IRQ_AFFINITY) { > + glue = kzalloc(sizeof(*glue), GFP_KERNEL); > + if (!glue) > + return; > + glue->notify.notify = netif_irq_cpu_rmap_notify; > + glue->notify.release = netif_napi_affinity_release; > + glue->data = napi; > + glue->rmap = NULL; > + napi->irq_flags |= NAPIF_IRQ_NORMAP; Why allocate the glue? is it not possible to add the fields: struct irq_affinity_notify notify; u16 index; to struct napi_struct ?