From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3A76E77188 for ; Mon, 6 Jan 2025 23:52:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8AB876080F; Mon, 6 Jan 2025 23:52:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0Y5zQRWsf0j4; Mon, 6 Jan 2025 23:52:01 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9346C607ED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1736207521; bh=h+t1a+Wcy+KRp/X70C+xsAph3Osz6Q09Wwfd7it6d6E=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iOVoygK2Ld3+efXRWqe7Afnj3lYZgVeQO3mW6NJiD230I2dQAdvnD73Pv02kS+CMO sTOLEfd+gG50QGc6T5heJ1DvrxzlFVqAVBNqq09SbLDiJ1Q6K+gPg23V1VCmPUGD/C 2/L9ARSHLb6Y11HhOlz8G37RwO1MDhXCUzAFHhy7HjeJVzbPEREi60W5KJ54xu2BvK Z1wnhcHj2JcgRIxVKA4gsI1RixhYDsLSKjhhgGv6I+3+cHwKeRPAeGmX+xzuMBbDqC ZRaRhlv3t+mRNYmIQI36d/S0uDxOBNoXfj+ksUoOtGnOJqox+jss4V2zlgceJ5WQgQ 8oD9kPVR7vn3A== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 9346C607ED; Mon, 6 Jan 2025 23:52:01 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 0B3396B for ; Mon, 6 Jan 2025 23:51:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D9CD781300 for ; Mon, 6 Jan 2025 23:51:59 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id StsnnptRqhvs for ; Mon, 6 Jan 2025 23:51:58 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org A85A3812FD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A85A3812FD Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp1.osuosl.org (Postfix) with ESMTPS id A85A3812FD for ; Mon, 6 Jan 2025 23:51:58 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 58059A41F79; Mon, 6 Jan 2025 23:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DAA0C4CED2; Mon, 6 Jan 2025 23:51:56 +0000 (UTC) Date: Mon, 6 Jan 2025 15:51:54 -0800 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , , Alexander Lobakin , Robin Murphy , Alexander Duyck , Andrew Morton , IOMMU , MM , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , Message-ID: <20250106155154.7c349c67@kernel.org> In-Reply-To: <20250106130116.457938-1-linyunsheng@huawei.com> References: <20250106130116.457938-1-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736207516; bh=Fu660IWX5S6t38fvF4BJ3mJpDywwH3eUN5CgaE2RF48=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=THtnK84Q3Oz/4hr7raXMxtb5YnvUsRTP0Z19d7W1LrVc020uM7dHfZQfaxiTBglrb 0uuuv4Ij3lvMxNaYs2U4xkdM1Mx/sGjqu1JF+EzVap0/mx7qJl607iIVwFe7HlG/s7 X14tjNK13QKsu2ZiViNL1koaVJB20ifxb0W3EaYPXmPLvd3Yw+D43CTpT1bSdEobVq enX3QqiM+fai2TD9PUP4jYCjrP+vp1tAnLo3Mv9k74nhRw+qMFF8RVBP1HKE/Gn7Dh zUjVlCwE6j30/RjhJSLQ4oMUTU+dCUPoDR1ZtkaF7VWo4Bdbpz0SfAdBVCoaM5Jkwm nSJEIl5AN0w9g== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=THtnK84Q Subject: Re: [Intel-wired-lan] [PATCH net-next v6 0/8] fix two bugs related to page_pool X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 6 Jan 2025 21:01:08 +0800 Yunsheng Lin wrote: > This patchset fix a possible time window problem for page_pool and > the dma API misuse problem as mentioned in [1], and try to avoid the > overhead of the fixing using some optimization. > > From the below performance data, the overhead is not so obvious > due to performance variations for time_bench_page_pool01_fast_path() > and time_bench_page_pool02_ptr_ring, and there is about 20ns overhead > for time_bench_page_pool03_slow() for fixing the bug. This appears to make the selftest from the drivers/net target implode. [ 20.227775][ T218] BUG: KASAN: use-after-free in page_pool_item_uninit+0x100/0x130 Running the ping.py tests should be enough to repro. -- pw-bot: cr