From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C800EC02194 for ; Fri, 7 Feb 2025 18:47:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 86B584267A; Fri, 7 Feb 2025 18:47:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gwvasbdvohWL; Fri, 7 Feb 2025 18:47:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A2FB5417E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1738954073; bh=5rcLnBaJ83tNh8TNgLmlz5nnTDQb1xMTf8vhMtR50N8=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GQMAoAFoe2VojpIGu13x4HK/+V6XWSSzrRfXpg1apHq5t0YwF+RgvmZhaPEh6YWBW oI+xtyKIVhD7HQPGf4yNxy0CSJxW9SWYviuLNVwDeA0eF581OXxs4aGkiwZKIUzZuR dV3kBBFIJdF6a5gktzQHXM+RNUC6IMRQGNWJ0kvUeNPo78VEU+yXeZ0KAGVa/GDQpL 3e9tlgZ40vmn3jzn0IHoblOo/pPQNgUf/Ju1BrnetrGJ+Wqys276bYAbgu3wTyZPYE Sl61+nnIookslg+JZrWJuM7h7tfqUm1vpx7YFz3I7umMssHnV9EbuLHZnt1XK4hq2p G+Vd8YAmUektA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id A2FB5417E1; Fri, 7 Feb 2025 18:47:53 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 4C1D7E4 for ; Fri, 7 Feb 2025 18:47:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 3BD0D61058 for ; Fri, 7 Feb 2025 18:47:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 15YK_QPM2Xw8 for ; Fri, 7 Feb 2025 18:47:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 489C16069B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 489C16069B Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp3.osuosl.org (Postfix) with ESMTPS id 489C16069B for ; Fri, 7 Feb 2025 18:47:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4C42EA439E5; Fri, 7 Feb 2025 18:46:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 537C5C4CED1; Fri, 7 Feb 2025 18:47:49 +0000 (UTC) Date: Fri, 7 Feb 2025 10:47:48 -0800 From: Jakub Kicinski To: Ahmed Zaki Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, andrew+netdev@lunn.ch, edumazet@google.com, horms@kernel.org, pabeni@redhat.com, davem@davemloft.net, michael.chan@broadcom.com, tariqt@nvidia.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, jdamato@fastly.com, shayd@nvidia.com, akpm@linux-foundation.org, shayagr@amazon.com, kalesh-anakkur.purayil@broadcom.com Message-ID: <20250207104748.27c7f96b@kernel.org> In-Reply-To: <20250204220622.156061-1-ahmed.zaki@intel.com> References: <20250204220622.156061-1-ahmed.zaki@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738954069; bh=SNHeOCTyWvD96DD7OFG4ME5iDM/iA2UYMrI1ko53A1A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sZ59KkDygg+JhdakwAIIaXTh/jB2sEZVMgaNTU8mU7umEwJCkPDTpxaPlqNXuPl5c eb6Qg0U8P+nK8dwlZNcaJ4bpfTxmKnLYbYT9HoKQqXwXXIj8cLDio6iBBhXFJrP0c6 JQyY1ns+l319hN7KOkCKaoZStq8OgRS4mlq9CIdJ93r8gZewDAqW1YDhtNCdkXLahS CmMJP038DbUFc1RsOu1oJ7gYWnH5ApUI3jXeb6yDvckVO53salmtMsPAuZfFTcXHPr HuIWiOTBNMzUwTG0BPaVjl13F5dO29u3hwCK9q9unDvyNYAyAULVz6iPvUuvhIHmEw 6rp8hX9rFWBdw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=sZ59KkDy Subject: Re: [Intel-wired-lan] [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 4 Feb 2025 15:06:17 -0700 Ahmed Zaki wrote: > Drivers usually need to re-apply the user-set IRQ affinity to their IRQs > after reset. However, since there can be only one IRQ affinity notifier > for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap > management in the core (which also registers separate IRQ affinity > notifiers). > > Move the IRQ affinity management to the napi struct. This way we can have > a unified IRQ notifier to re-apply the user-set affinity and also manage > the ARFS rmaps. The first patch moves the ARFS rmap management to CORE. > The second patch adds the IRQ affinity mask to napi_config and re-applies > the mask after reset. Patches 3-5 use the new API for bnxt, ice and idpf > drivers. Hi Ahmed! I put together a selftest for maintaining the affinity: https://github.com/kuba-moo/linux/commit/de7d2475750ac05b6e414d7e5201e354b05cf146 It depends on a couple of selftest infra patches (in that branch) which I just posted to the list. But if you'd like you can use it against your drivers.