From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7FF4C021AA for ; Thu, 20 Feb 2025 02:06:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 686B840837; Thu, 20 Feb 2025 02:06:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id B3LzCp4EjLBr; Thu, 20 Feb 2025 02:06:57 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7386940DC1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740017217; bh=52jceNwLt0gRA8miJzw1PRc8wr+wFA0Cp/cey71YB3w=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QD8kTdrHCQutSvMHbWMms4gLIVEBpLhQClW6lZ3zISuhLGOxvxK0PHePZb9TpQ7dJ 8ucNUvtPOJ+te7qRn0f85QWdWjpVf9SFNiztkVp+juowGmvNxKRm9s2iZMeU3FJC4o xi+w1pThzQeOgN6YZ7TPBybD4LIwaVK04cPTSFA4+kkmABSJ74t+x0zYX3dq5zY+QH 4pqCbNGRr6xqQhQi7ssTW9EfkAIqZfEZVBryrYi79GRLTWHNrhJgfXE18+giYtwa1m Yqg2xF4iB/aWJTaCesGbkjyBE704d9DA+LcveQwe/YZgeJo1Qouunq8D4L0RiHSghG qn3YWU99c3y5g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 7386940DC1; Thu, 20 Feb 2025 02:06:57 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 626DCD92 for ; Thu, 20 Feb 2025 02:06:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 51591608C4 for ; Thu, 20 Feb 2025 02:06:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kXMFMMhaynUz for ; Thu, 20 Feb 2025 02:06:54 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org AB300608CD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AB300608CD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id AB300608CD for ; Thu, 20 Feb 2025 02:06:54 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1CF625C55C0; Thu, 20 Feb 2025 02:06:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90A9FC4CED1; Thu, 20 Feb 2025 02:06:52 +0000 (UTC) Date: Wed, 19 Feb 2025 18:06:51 -0800 From: Jakub Kicinski To: Kurt Kanzenbach Cc: Joe Damato , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Message-ID: <20250219180651.0ea6f33d@kernel.org> In-Reply-To: <878qq22xk3.fsf@kurt.kurt.home> References: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> <878qq22xk3.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740017212; bh=EgBVo6RhWMthFB+iS+hJogXI/CaL4DpuWPIXar+k6Tc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S6xjXoLUpWXK7RxE098FTqZiEyWwABqwy11BtNe8AGQdbyk2/FyMLvNunXJd7S4Ev rz7DC1Ia8/Umaj4uHJbBwQzhZS36a5dCynw2stcQkIFhkreFaga++/GAklJXyP5vJH +k5mhM3xuZ4UBBlqfnw1FUjrfXBN9y7/NbQqpV+D/uqZhoJ28UDduAlVb0uwgEoB1c U/Ix4qc42O1VwHcvXvgCHKBbvdRYKGGQW1oqutMbPdNeN8kg0A0jpYPHqqcBPXzaBl otryvF/MmGmz+Lc4l0mOP3wCixc83GAT0F1r74Lx/pJXgwDjO+I73p8MyZRpWBI46m ZK6ErJLlZSj+A== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=S6xjXoLU Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 19 Feb 2025 08:39:08 +0100 Kurt Kanzenbach wrote: > > My comment from the previous series still stands, which simply that > > I have no idea if the maintainers will accept changes using this API > > or prefer to wait until Stanislav's work [1] is completed to remove > > the RTNL requirement from this API altogether. > > I'd rather consider patch #2 a bugfix to restore the busy polling with > XDP/ZC. After commit 5ef44b3cb43b ("xsk: Bring back busy polling > support") it is a requirement to implement this API. > > The maintainers didn't speak up on v1, so i went along and sent v2. > > @Jakub: What's your preference? Would you accept this series or rather > like to wait for Stanislav's work to be finished? No strong preference. If rtnl_lock is not causing any issues in this driver, the we can merge as is. I haven't followed the past discussions, tho.