From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06436C021B2 for ; Sun, 23 Feb 2025 05:40:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AAA8E812E7; Sun, 23 Feb 2025 05:40:08 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id saayqC8-Mj6j; Sun, 23 Feb 2025 05:40:08 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0A80F812CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740289208; bh=BfvuWvSB4FrYuL3Q9W8pUmNF8XrVHM6syd74IbIbqmI=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=5traBDdnsFVk6erfNIkHxhNkxXIHswOACB7UGGWabMvDGxol/imuI1D7B1LF7ICMK 62GD8W18aOI8IWMOqIjfTnK/1NREYo+zWUTol49zf1cg5f9moMK+cWB3OHvQmJGqdZ bp2fhajuMDz7yN8BVJHMizatip8YJf3aSKU2QEoYeSlSPqw3AjXYwKVkdZ9b5N/pED xlAg+D2JFu05rq3zOG6zUWWxqMY8RJapytwwpG9y/EnRArSf1tdSjl/3fdlVThRx5y DgSQN/M3iQO5x0nr381DWf3P6G2SIdqyM2VvGSUDD46CESUsK8WB9h++xlV7grL0nh 0cLmtKL0AUrhw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 0A80F812CF; Sun, 23 Feb 2025 05:40:08 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id E3D57943 for ; Sun, 23 Feb 2025 05:40:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B580C60615 for ; Sun, 23 Feb 2025 05:40:05 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id r1Jg9evWwwqr for ; Sun, 23 Feb 2025 05:40:05 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::102c; helo=mail-pj1-x102c.google.com; envelope-from=0x1207@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 127836060B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 127836060B Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by smtp3.osuosl.org (Postfix) with ESMTPS id 127836060B for ; Sun, 23 Feb 2025 05:40:04 +0000 (UTC) Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2fa8ada6662so6931601a91.1 for ; Sat, 22 Feb 2025 21:40:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740289204; x=1740894004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BfvuWvSB4FrYuL3Q9W8pUmNF8XrVHM6syd74IbIbqmI=; b=aECUdBFaudArwdMOvrpsKvwMkH2sR3yw95oimCQJNI9QQ8g6EcBLN2CxPIfhglZ3o3 8NkuagLQjpPjeXWeQtG+u/hRO7Gg1OmHkvjg/bPFnj2a52e7GoUluwbkguoshN1bTYFF /qJfApfMfQQMiXUZeMXogvjTvZqLXaBeIRu0oTnwFtJPdMCdvh3HCg02C2Qyg1DTkO4z byKQeeoI8GEd9B/jmrNtczimWlL11EjV3yTvblPLZHD2Ivd28/eIEF8pDisM6RuoSEoo v62vdkYxraVbPcKPvbdjNSVC+sRS6pwRhY+2wq9NAz674lES0v50Os5l64D/8tY2KWaq u8Fg== X-Forwarded-Encrypted: i=1; AJvYcCWlH4IG5NPwdT9tpGl8zYZkV37S2wcJpOLTEZWaxQM9BduueWwP+ZwbMYtjHeFogeyiwOf84KrL7uIatttwKdI=@lists.osuosl.org X-Gm-Message-State: AOJu0YwNqOyqgryXsOij7inuIADgxxebv48gMZrCSKOxfPUlXuHUeqQZ UGf9+Lxwz2HDFBJscv1QvTrkKSD9BMxq9v6NBXtY8VPc1zTqXAUd X-Gm-Gg: ASbGnctyIcdmTVP2bGV2Ql2XWoqlZ6rbl7TfZGLgzZ9k0sLvWz6KNhWocVq/AsGnW4H xLLwlcrCa5xqcqnexj7BffMqOKJd0nHrHwfv1BjWUoupjpUb6qU4U6wGkl43mGsbL3+E1zNLkQ4 tTLLI3Hz95YDhUlnkdfgCCOOWrWdj+dcl4iGbKKLK95HjjqSIfK824JIpvH76A1eOGA0LBCXC6j VHt04HsOfKoIJNqK4Bf6kdCae6JMo4NpMBFARz1KGXWnOZHKAwtuiqqR/Atzul5IDQSa0G6rKvd g8CH04qbXqzeGCFpnETX6D0= X-Google-Smtp-Source: AGHT+IEsyitKBEB+TjtOIJ7j0ghQQ1PUySgYsjd6ENH+ooYHWDcum4IoJa9MuHEv9g0sOVIJCIQYCA== X-Received: by 2002:a05:6a20:8403:b0:1ee:efa5:6573 with SMTP id adf61e73a8af0-1eef52c9981mr17773167637.8.1740289203622; Sat, 22 Feb 2025 21:40:03 -0800 (PST) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73261ca7831sm15022814b3a.104.2025.02.22.21.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2025 21:40:03 -0800 (PST) Date: Sun, 23 Feb 2025 13:39:47 +0800 From: Furong Xu <0x1207@gmail.com> To: Faizal Rahim Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Russell King , Vladimir Oltean , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Andrew Halaney , Choong Yong Liang , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Message-ID: <20250223133947.00002f06@gmail.com> In-Reply-To: <20250220025349.3007793-2-faizal.abdul.rahim@linux.intel.com> References: <20250220025349.3007793-1-faizal.abdul.rahim@linux.intel.com> <20250220025349.3007793-2-faizal.abdul.rahim@linux.intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740289204; x=1740894004; darn=lists.osuosl.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BfvuWvSB4FrYuL3Q9W8pUmNF8XrVHM6syd74IbIbqmI=; b=E/6g0CKJOth3gRdyLV42UFDaWr7uZCYfW5FwMa3mvJ0i0siP4dCvaMt3iG3949OUom 7WVyHYwXwZii/Ne3nabmMI+zlIwUfos+rScNK4/xPmyH4FjlCwzFAJ2L2PDIecyKCnV7 +AY52S6kQZlnbgn0jONSXy51cD8wbsGv63GkRIHOFidepEKwzzIHKwAYFO6ti+xzjg6r 1gvT8ezZsec2ugcjCuFuj2FscpV20QqypdDnBmM8NfcYr/zpuSMQW0HAwQMBJ+TRAxj9 5GuitOxCjLbaYVQq5Ge39GD60ilvdcSSkZOp+PZ7F8wXZxVu3XtA65zbO0OsaLdZFSwD XsEA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=E/6g0CKJ Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 1/9] net: ethtool: mm: extract stmmac verification logic into common library X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 19 Feb 2025 21:53:41 -0500, Faizal Rahim wrote: > @@ -1258,23 +1236,8 @@ static int stmmac_set_mm(struct net_device *ndev, struct ethtool_mm_cfg *cfg, > if (err) > return err; > > - /* Wait for the verification that's currently in progress to finish */ > - timer_shutdown_sync(&fpe_cfg->verify_timer); > - > - spin_lock_irqsave(&fpe_cfg->lock, flags); > - > - fpe_cfg->verify_enabled = cfg->verify_enabled; > - fpe_cfg->pmac_enabled = cfg->pmac_enabled; > - fpe_cfg->verify_time = cfg->verify_time; > - fpe_cfg->tx_enabled = cfg->tx_enabled; > - > - if (!cfg->verify_enabled) > - fpe_cfg->status = ETHTOOL_MM_VERIFY_STATUS_DISABLED; > - > + ethtool_mmsv_set_mm(&priv->fpe_cfg.mmsv, cfg); > stmmac_fpe_set_add_frag_size(priv, frag_size); > - stmmac_fpe_apply(priv); Well, I would prefer keeping stmmac_fpe_set_add_frag_size() before ethtool_mmsv_set_mm(), but not after, the VERIFY process should be triggered after all the parameters are set. > - > - spin_unlock_irqrestore(&fpe_cfg->lock, flags); > > return 0; > }