From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0AE2C19F32 for ; Thu, 27 Feb 2025 17:27:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 49B6C41694; Thu, 27 Feb 2025 17:27:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ICxdq55X1sDo; Thu, 27 Feb 2025 17:27:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 79459416AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740677251; bh=a7wqzVe59zAy+kAO/b53mbZKci7qzZB1se5GRZqkV3g=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=9NtjMvwe8Oeiezr/OFhSSkOTF/UVWpyCLi+yQbb3JyPharqEgxkaZtnQgofZxs1zd UfOi6HgOolWJp77M0fmRNlJ7pXAej0EVM6YKOjqquUEb0YcqRzfmiZqIEPAP/lDvaS yqcALJ6RWMqarnKqR1CRTCp0a4BJo89qjp8K9j984jdexEaW86DiWHR9QweMG7JRXQ LjavvaPQUMe0X6sthCQ0B2inFulK11sEnJdnQm5XKkXnYM3VBD7wujo80bYWB7rHR+ 7hUQr+UluV5zIHQpjVuDJsDowjtHDKLEoll/lhdVSEXLYppsVtldm/wz7FohLxWTzD QcRuCxPmn1Hkw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 79459416AB; Thu, 27 Feb 2025 17:27:31 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id D97E968 for ; Thu, 27 Feb 2025 17:27:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BD87380A83 for ; Thu, 27 Feb 2025 17:27:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yrph3abfmNXL for ; Thu, 27 Feb 2025 17:27:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04::f03c:95ff:fe5e:7468; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1AB83802CB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1AB83802CB Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04::f03c:95ff:fe5e:7468]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1AB83802CB for ; Thu, 27 Feb 2025 17:27:28 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D032B61F3D; Thu, 27 Feb 2025 17:27:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA61EC4CEDD; Thu, 27 Feb 2025 17:27:25 +0000 (UTC) Date: Thu, 27 Feb 2025 17:27:23 +0000 From: Simon Horman To: Grzegorz Nitka Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Karol Kolacinski , Przemek Kitszel , Milena Olech Message-ID: <20250227172723.GG1615191@kernel.org> References: <20250221093949.2436728-1-grzegorz.nitka@intel.com> <20250225095021.GK1615191@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250225095021.GK1615191@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740677247; bh=3rbgKRdPD57Q4504inUanYwfL6bZjk7Ar3Z9m1kYk8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=enwMmSL1/rsdzfIYr8EZwClm9n5DN/KczIfu5ZOLTIJke0YNXaNWs8JQkh4gidrLr sgaqcHu5EYUf3T2noL7fw7ATnbwcRAUwPslurErbY0Vamw8d5XM2lMSyTNnJCATQe7 4T8c4jLs2nXkqV9zAP+pGaPY9ZsO8d1aoa3orasd7YcdHKHI87usXvfsTrcBlksihu Na40zuhZSoiCHu+2Ed+IVNvfPfYuq9vmdkitoUrMEWvuUYZZPby0WA6cNCtaQiconA Pc+MrVdDLJ3BWanxm3sd4KKGiV29NefHy0x99lBoprjKbs8cg1bjJp2FBxGwe6ylHR JS5KTjT7zNzhg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=enwMmSL1 Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix lane number calculation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Feb 25, 2025 at 09:50:21AM +0000, Simon Horman wrote: > On Fri, Feb 21, 2025 at 10:39:49AM +0100, Grzegorz Nitka wrote: > > E82X adapters do not have sequential IDs, lane number is PF ID. > > > > Add check for ICE_MAC_GENERIC and skip checking port options. > > This I see. Sorry, this was part of an earlier draft. Please ignore. > > > > > Also, adjust logical port number for specific E825 device with external > > PHY support (PCI device id 0x579F). For this particular device, > > with 2x25G (PHY0) and 2x10G (PHY1) port configuration, modification of > > pf_id -> lane_number mapping is required. PF IDs on the 2nd PHY start > > from 4 in such scenario. Otherwise, the lane number cannot be > > determined correctly, leading to PTP init errors during PF initialization. > > > > Fixes: 258f5f9058159 ("ice: Add correct PHY lane assignment") > > Co-developed-by: Karol Kolacinski > > Signed-off-by: Karol Kolacinski > > Signed-off-by: Grzegorz Nitka > > Reviewed-by: Przemek Kitszel > > Reviewed-by: Milena Olech > > Reviewed-by: Simon Horman I only meant to send this part :)