From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FE9CC282D0 for ; Fri, 28 Feb 2025 17:25:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 619E470EFE; Fri, 28 Feb 2025 17:25:59 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id cvNXVXkO5QhY; Fri, 28 Feb 2025 17:25:58 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7938470B20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740763558; bh=6XY2UAQNHsivw2xARBLiNxIUdwI43IIkjzNJ+l7WpKQ=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=4PAMX4F2whvjZiBd9MO2krnjgEg/HoSky+CJQrlxStxSthsALw/Nc5rtY3+4aVCnL ywrjWoux6crQ1p1bmVZnC6tBJUBLhVLEerxdKngrvArZdHcWQn9SUc3H5hkfOrYPC5 zAqqBI3zd8qrkvWf5Lac/Cod5U8KY07WF6xaWQ2tfkFA0xcHOEy96ELXjP1PwoUReH ScCTAlki6L6/nXPKQ+WBJa8ZsPHUdhc0mVVyvu1ZrzW2acm6m//rpCKFIeMHhawzlN RWy613lS1QzJ8xsaFZI1peUQG3U+ZN9ik7d4UqtVuFAvRT5SCKSQV4IK6yt3MTFRAF Az+MgdSzFZfFQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 7938470B20; Fri, 28 Feb 2025 17:25:58 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 488841CB for ; Fri, 28 Feb 2025 17:19:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 18AA0403FE for ; Fri, 28 Feb 2025 17:19:10 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4VEhOaLxGSAh for ; Fri, 28 Feb 2025 17:19:07 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 38F984165C DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 38F984165C Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 38F984165C for ; Fri, 28 Feb 2025 17:19:06 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 719675C67D0; Fri, 28 Feb 2025 17:16:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9174C4CEE8; Fri, 28 Feb 2025 17:19:03 +0000 (UTC) Date: Fri, 28 Feb 2025 17:19:01 +0000 From: Simon Horman To: Martyna Szapar-Mudlaw Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Lukasz Czapnik , Jedrzej Jagielski Message-ID: <20250228171901.GP1615191@kernel.org> References: <20250225090847.513849-2-martyna.szapar-mudlaw@linux.intel.com> <20250225090847.513849-7-martyna.szapar-mudlaw@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250225090847.513849-7-martyna.szapar-mudlaw@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740763145; bh=3MrgstQePIvcsa2zhz0+y++t+2iL5vyrmilS1Ep7/NM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rh0LMl0Xufcdsu8doj7CnKPlujmmfVXEBRMQ0niz2dnuyYshYkHePS+oGSc3OjXi2 b3X9F2oE+5WRd4lrZYprXx1xwXTvHI99bVaxMx029B0XEZWPoNCj7TfrL4gSx1Q8/x 7vYWABvIij1MoUOR7ZuDHpssnvtnHrTqv0EyuUuPUgtultqEZP8QyhhmRXNXbmXWn3 y1ButkIrzuRg7de96+lXuYg/CRwjAwxy/MSv+7Gwv53HPkUYZCcoUgRUPW28Ua752b cAOmztv/Fim7hLcHmjSfsw22wV1C+2PF6OFtO0L/GSGyCCwRsU+fBDGDq+/UPSesCc GRmfM639NKKwA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Rh0LMl0X Subject: Re: [Intel-wired-lan] [iwl-net v2 4/5] ice: fix input validation for virtchnl BW X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Feb 25, 2025 at 10:08:48AM +0100, Martyna Szapar-Mudlaw wrote: > From: Lukasz Czapnik > > Add missing validation of tc and queue id values sent by a VF in > ice_vc_cfg_q_bw(). > Additionally fixed logged value in the warning message, > where max_tx_rate was incorrectly referenced instead of min_tx_rate. > Also correct error handling in this function by properly exiting > when invalid configuration is detected. > > Fixes: 015307754a19 ("ice: Support VF queue rate limit and quanta size configuration") > Reviewed-by: Jedrzej Jagielski > Signed-off-by: Lukasz Czapnik > Co-developed-by: Martyna Szapar-Mudlaw > Signed-off-by: Martyna Szapar-Mudlaw Reviewed-by: Simon Horman