From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59CC9C282DE for ; Sun, 16 Mar 2025 13:15:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F16DD81DEF; Sun, 16 Mar 2025 13:15:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id jdcv3wJVh-2P; Sun, 16 Mar 2025 13:15:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 603E981DF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1742130955; bh=yos+l5CGltOBFII8UMYOc958S9Awy3xJrkho/+UWavA=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=M6u8tFXcq6YYIE9o4eaXAL+kcDVht7HAJ1YH+7360JexbRcMeKgYH9h6RHgnR/h6A s/P3uNg5g2/EQ7chWKg+4JyQtFxsuc78Lzq8tKLImg7FqwxBbU9yENAkqjbGDjSd0V hgrUlKcldMwgccQVT2FFIWHAXMAjB65Bs9IN1YOBxhsrsLZOl9Q9dBrakrYhg3GC5Y r7r00h72K4y4L0OETNguBWvQfWyNC281lDj7GNw4P7MzXbM/EM+PRHlzpzQempbl9B +rKjN7PAs/7QMZpWeg3ZbBoZcI07j9EwsNYxKs6aU+Nhq6jpDh2q2KHeJRscKkL7fx leW1nmh4rLz2g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 603E981DF9; Sun, 16 Mar 2025 13:15:55 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id C13DCEA for ; Sun, 16 Mar 2025 13:15:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AFC8540C1A for ; Sun, 16 Mar 2025 13:15:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sd1QU0eF3Tr6 for ; Sun, 16 Mar 2025 13:15:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org B910540C14 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B910540C14 Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp4.osuosl.org (Postfix) with ESMTPS id B910540C14 for ; Sun, 16 Mar 2025 13:15:52 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3C453A48B74; Sun, 16 Mar 2025 13:10:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79A1CC4CEDD; Sun, 16 Mar 2025 13:15:48 +0000 (UTC) Date: Sun, 16 Mar 2025 13:15:45 +0000 From: Simon Horman To: Martyna Szapar-Mudlaw Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Mateusz Polchlopek , Marcin Szycik , Michal Swiatkowski , Jedrzej Jagielski , Przemek Kitszel , Aleksandr Loktionov Message-ID: <20250316131545.GY4159220@kernel.org> References: <20250307132555.119902-2-martyna.szapar-mudlaw@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307132555.119902-2-martyna.szapar-mudlaw@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742130950; bh=S8k6hZfMd8wUHCgq21ZTyZehbZz+gKZmfe5iK5Dpr0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FQCpLDxsVkKe6ypR3DTVOWjEmidOBmT7ecCm3ke/XeXb3mBUskRECSW5KIzULq0YT 9OtFXsgOGz1y4nQf6J0aYb4sPqgjOW//O3oOCfFBjNT1ht7VGxQsmaQFXK/bLLtIZy M8ACT4RaAKI0xg6DtJdOxSLmByrpERq+3efiIw6ye0PbaKC9uqHop7626BVcSsz+dd fyU74KUJU3STWnm6h7qPRpw5YmQINjchx9RczsycfDJSIwZBGyt+pv5+MdJh6K4dUW 9NXQDCPSiI7klqgTec2ls3OKGY5KCfT/ByNDadzANxNstjkPEWc0NUW1lu4Pjf7S9v TrqtwVvQbZbQw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FQCpLDxs Subject: Re: [Intel-wired-lan] [iwl-next v2] ice: refactor the Tx scheduler feature X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Mar 07, 2025 at 02:25:56PM +0100, Martyna Szapar-Mudlaw wrote: > From: Mateusz Polchlopek > > Simplify the code by eliminating an unnecessary wrapper function. > Previously, ice_devlink_tx_sched_layers_get() acted as a thin wrapper > around ice_get_tx_topo_user_sel(), adding no real value but increasing > code complexity. Since both functions were only used once, the wrapper > was redundant and contributed approximately 20 lines of unnecessary > code. Remove ice_get_tx_topo_user_sel() and moves its instructions > directly into ice_devlink_tx_sched_layers_get(), improving readability > and reducing function jumps, without altering functionality. Thanks, this explanation looks good to me. > > Also remove unnecessary comment and make usage of str_enabled_disabled() in > ice_init_tx_topology(). Sorry for not noticing this in my review of v1, but I would lean towards these changes being separate patches. That not withstanding, this looks good to me. Reviewed-by: Simon Horman > Suggested-by: Marcin Szycik > Reviewed-by: Michal Swiatkowski > Reviewed-by: Jedrzej Jagielski > Reviewed-by: Przemek Kitszel > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Mateusz Polchlopek > Signed-off-by: Martyna Szapar-Mudlaw ...