From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3C66C282EC for ; Mon, 17 Mar 2025 16:36:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7DB1A40D91; Mon, 17 Mar 2025 16:36:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KJKLaQQBtjeR; Mon, 17 Mar 2025 16:36:15 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5232340D76 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1742229375; bh=jmD9IP5D3pQQqpMFBv2z413sIGBt5qTTLHVOGUSylAw=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K2aqKBVauewHUmrz9IHFC/u00K6yq+4//glV3tofU/FyQ2MorqtcvhYuFdIo1UHH3 LjvAas/9LlRUufMtcIy8ST1uaabZUZwtgWT4dJvl6CdskOp/gHuK+b5+OOkc03WDgC ZyM0dNuAPHEywOk061H7qTf7NHMZ/L6IQ92Miz4J29wSvCnwwADOc/rUWP7VDrkcpc 34hVQ/ScbZ6QmSSb/TbODQOb6gV6npf0a57DG9IO1rh6fzsjNPQKuQVOKrRz8Bm3XH Can3NIAH/iVu4XbVLFtOxe3iY8pMrP63+3I89ecRcqQJ2k0QUo5cc67V06nv/kcYk2 6jiJw8/YY4a+g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 5232340D76; Mon, 17 Mar 2025 16:36:15 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 1392FD5 for ; Mon, 17 Mar 2025 16:36:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0933840D84 for ; Mon, 17 Mar 2025 16:36:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OGOMFcB22ARe for ; Mon, 17 Mar 2025 16:36:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org DFD0840D76 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DFD0840D76 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id DFD0840D76 for ; Mon, 17 Mar 2025 16:36:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D4ED55C4B2A; Mon, 17 Mar 2025 16:33:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27D6DC4CEE3; Mon, 17 Mar 2025 16:36:08 +0000 (UTC) Date: Mon, 17 Mar 2025 16:36:07 +0000 From: Simon Horman To: Grzegorz Nitka Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Karol Kolacinski , Michal Swiatkowski , Przemek Kitszel Message-ID: <20250317163607.GD688833@kernel.org> References: <20250310122439.3327908-1-grzegorz.nitka@intel.com> <20250310122439.3327908-2-grzegorz.nitka@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310122439.3327908-2-grzegorz.nitka@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742229370; bh=hxUGwuq7WDdmDJmZwXTfkiEjKSTVRymvuQfO+oKCd2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eim7GMPZJ+a7J8RIAakBUTHU5Hl4HUVOxQlDkCp7Az77Y1ooTCXtn7CT4PydNT9ML 34Yna0UV8nQUFO3Gr+TJ08s1Zdf8kXQA+dNCTHZlgPfdbSymzXSJPlcxo/te6GtpYe ryZ27ab6g42K9XJ/7CQk+YP/KqrSk3OJfruoFYdt/46vo1oWDjsO2FwXAy5MECOjDv miRVvAPL0THlFytOTz3wVGDPpVB9UWKmm1uFdSL8sn7aWpGaIZA05tcYSlGBd2l8Yu bIEUfWTT/vfkvqmbfR/bvqimtQ3jAOLxJ2pqfxt/ATslJchpRwtA1W1U+cA1hiazwD hq1aVhOoXfuXQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=eim7GMPZ Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote: > From: Karol Kolacinski > > Due to the bug in FW/NVM autoload mechanism (wrong default > SB_REM_DEV_CTL register settings), the access to peer PHY and CGU > clients was disabled by default. > > As the workaround solution, the register value was overwritten by the > driver at the probe or reset handling. > Remove workaround as it's not needed anymore. The fix in autoload > procedure has been provided with NVM 3.80 version. Hi Grzegorz, As per my belated comment on v2 [*], I think it would be worth adding a brief comment here regarding this not being expected to cause a regression in HW+FW seen in the wild. [*] https://lore.kernel.org/netdev/20250317163359.GC688833@kernel.org/ > > Reviewed-by: Michal Swiatkowski > Reviewed-by: Przemek Kitszel > Signed-off-by: Karol Kolacinski > Signed-off-by: Grzegorz Nitka ...