From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD377C28B28 for ; Tue, 18 Mar 2025 14:01:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9D31E60669; Tue, 18 Mar 2025 14:01:20 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id FAtoOXvYCa_o; Tue, 18 Mar 2025 14:01:20 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 00CE7607DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1742306480; bh=1jDL+7c4ztAx/g6S3i+Y52ajKbBqZxFdY6WR/0h66ws=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y4UctUXFTYACQCZMb9HeVzw385cXH1OlvqX70b79TApuo4MzK9PBXjwiXEvjeLN7n Zd1+HfLQAjufPnxldULnWVZVWNzzCGmcHRZKQX1rnA/nK8N6LRY/aUZCYs8jLLX02R Rk+FOxt80tft1b3Qfc4FAegbvXsquJ8mHMUz4MCRb1ULkE4RNtw4yF/+T+MD8IILTg Rddqs8hwORJAZWGZ9ZBiS/KtZ/RDjaV10gzy4zn/QPPuOCOZrIArEm06jTc6AY+41S 3fuYnf5+tfZhXr7SW5qreZUfQRDjHKzgLAkwgALRz7T7A04y4/2nV4ffxf+q22hN/K +/Zr1pQIN83mg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 00CE7607DE; Tue, 18 Mar 2025 14:01:20 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 60B86D5 for ; Tue, 18 Mar 2025 14:01:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 43E9B406F9 for ; Tue, 18 Mar 2025 14:01:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id c_76mBURU0ba for ; Tue, 18 Mar 2025 14:01:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 71234403AF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 71234403AF Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp4.osuosl.org (Postfix) with ESMTPS id 71234403AF for ; Tue, 18 Mar 2025 14:01:18 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D2285A4536B; Tue, 18 Mar 2025 13:55:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D5EC4CEEE; Tue, 18 Mar 2025 14:01:12 +0000 (UTC) Date: Tue, 18 Mar 2025 14:01:10 +0000 From: Simon Horman To: Jacob Keller Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Ruud Bos , Paul Barker , Niklas =?utf-8?Q?S=C3=B6derlund?= , Bryan Whitehead , UNGLinuxDriver@microchip.com, Raju Lakkaraju , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , Jonathan Lemon , Lasse Johnsen , Vadim Fedorenko , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Message-ID: <20250318140110.GT688833@kernel.org> References: <20250310-jk-net-fixes-supported-extts-flags-v1-0-854ffb5f3a96@intel.com> <20250310-jk-net-fixes-supported-extts-flags-v1-4-854ffb5f3a96@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310-jk-net-fixes-supported-extts-flags-v1-4-854ffb5f3a96@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742306477; bh=qN5FZGZkV8hY7P/iLN+6qzh/l08Z8WtzT3kITbpr4z8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YKFTE1pAeiLLSYZqt9CPYNr83U0Y4/SFw3mBdgF3bXkql4dvOnh/Xgg/TT7hBGZgv qmuWtwBNzzj/1t1TzLwToFr7Yl0P+QyU7Df9m5WnaYCmPfpcmR7fk6EcrqdbCGodj5 B+WJ11UMOaQRNnBMK1pmTf0stPUYqdMOihVc7azHsmtBoaWkyUokwWhLt/t6e1XCno XHKHpq5qFBStufAOpnVx0CocgcdFpGxHGbWKBWJHbP9aG/8KvFy1laMGqnzUM5ZHNQ CgzT8xzJSVlgTIoYHgrBDPV3hO+FkotlpguVkI9Hoq2czJJUl/1PzQh3auXoo+6/cG GnOOwLLY1JFEw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YKFTE1pA Subject: Re: [Intel-wired-lan] [PATCH net 4/5] broadcom: fix supported flag check in periodic output function X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Mar 10, 2025 at 03:16:39PM -0700, Jacob Keller wrote: > In bcm_ptp_perout_locked, the driver rejects requests which have > PTP_PEROUT_PHASE set. This appears to be an attempt to reject any > unsupported flags. Unfortunately, this only checks one flag, but does not > protect against PTP_PEROUT_ONE_SHOT, or any future flags which may be > added. > > Fix the check to ensure that no flag other than the supported > PTP_PEROUT_DUTY_CYCLE is set. > > Fixes: 7bfe91efd525 ("net: phy: Add support for 1PPS out and external timestamps") > Signed-off-by: Jacob Keller Reviewed-by: Simon Horman