From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E067BC28B28 for ; Tue, 18 Mar 2025 14:03:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A12118126B; Tue, 18 Mar 2025 14:03:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id o9sDy91VXjoJ; Tue, 18 Mar 2025 14:03:30 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 096AB8111B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1742306610; bh=ODe703cBzcJNsrGXr0rBG+avIRrn8cVjyQ/+2F18Kxg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SNOQ8jhF4CdFM+VhEFpILWe0h8WFYdjOjfvVLoWJZyyWNH1O9Qh1229geWhaVEzNH DtYDN4bDmgIXHsDHIV07Dq6im0d/Dy+kR6ahewRY8WRqTyHHHuFfgh1rNvQOULvJ6C w2kG/4QJfKKyF3L8LbMmGMfvPf4Xa7FIuHsrRn0IYOU3q+6BuYZMNsCgTkLY2B7n4G Ou79Oh8FhDUK4mU1oT/6gbrN4RXChhIjOlmX0LlDVvkYOKx3V+vOPJmFBb1fw+rtTl KlrBaUUAdiiCX3lSZ3Xuxp9iTFLlJqq+CVkwg6T2G2D03s8/pc1paoP5cF0bGeNSWh ytQjg8ebOPlug== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 096AB8111B; Tue, 18 Mar 2025 14:03:30 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 9B6C7950 for ; Tue, 18 Mar 2025 14:03:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8A175409C7 for ; Tue, 18 Mar 2025 14:03:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id cOBjoabnvgcB for ; Tue, 18 Mar 2025 14:03:27 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 966314051D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 966314051D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 966314051D for ; Tue, 18 Mar 2025 14:03:27 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B58995C57FD; Tue, 18 Mar 2025 14:01:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85DC8C4CEEA; Tue, 18 Mar 2025 14:03:21 +0000 (UTC) Date: Tue, 18 Mar 2025 14:03:19 +0000 From: Simon Horman To: Jacob Keller Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Ruud Bos , Paul Barker , Niklas =?utf-8?Q?S=C3=B6derlund?= , Bryan Whitehead , UNGLinuxDriver@microchip.com, Raju Lakkaraju , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , Jonathan Lemon , Lasse Johnsen , Vadim Fedorenko , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda Message-ID: <20250318140319.GU688833@kernel.org> References: <20250310-jk-net-fixes-supported-extts-flags-v1-0-854ffb5f3a96@intel.com> <20250310-jk-net-fixes-supported-extts-flags-v1-2-854ffb5f3a96@intel.com> <20250318135947.GR688833@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250318135947.GR688833@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742306606; bh=wLSyUj0wy1pDaO3/fQf6a6v78mYwzwxwtySQH15C9X8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qSO51hNtifkd+iANWTT0FvTSTlYPVAGia7nCNdbyCI2pobyHQqBfNS6e0jYjKJkw8 S1D5WMQ9B8NnJJnrtANHvWapqOxv95Pya0CSDbyfV5UyjNpuMCgg1w3tCA8aeqOCQx AHj8tTlmtjZCOlCcj/lUpOVl3D9LgBxv4vXr4Ib4XjjJGlHIx4QtONafg5qW4o5sOT MkQWAYruRr8meu1KV2GLuAHFRpd2xTO6vYu5VteK3R7N8WJtl0z4tJrFQWvwu8aWLU hLKvGZWk9h0rqu2JiL4l686V2CdiKDXbOILgSVLlM0XzX1l0/BYREmMeK9Sn2gXLDl ZAdxWJRdR4YMw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=qSO51hNt Subject: Re: [Intel-wired-lan] [PATCH net 2/5] renesas: reject PTP_STRICT_FLAGS as unsupported X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Mar 18, 2025 at 01:59:47PM +0000, Simon Horman wrote: > + Shimoda-san > > On Mon, Mar 10, 2025 at 03:16:37PM -0700, Jacob Keller wrote: > > The ravb_ptp_extts() function checks the flags coming from the > > PTP_EXTTS_REQUEST ioctl, to ensure that future flags are not accepted on > > accident. > > > > This was updated to 'honor' the PTP_STRICT_FLAGS in commit 6138e687c7b6 > > ("ptp: Introduce strict checking of external time stamp options."). > > However, the driver does not *actually* validate the flags. > > > > I originally fixed this driver to reject future flags in commit > > 592025a03b34 ("renesas: reject unsupported external timestamp flags"). It > > is still unclear whether this hardware timestamps the rising, falling, or > > both edges of the input signal. > > > > Accepting requests with PTP_STRICT_FLAGS is a bug, as this could lead to > > users mistakenly assuming a request with PTP_RISING_EDGE actually > > timestamps the rising edge only. > > > > Reject requests with PTP_STRICT_FLAGS (and hence all PTP_EXTTS_REQUEST2 > > requests) until someone with access to the datasheet or hardware knowledge > > can confirm the timestamping behavior and update this driver. > > > > Fixes: 6138e687c7b6 ("ptp: Introduce strict checking of external time stamp options.") > > Signed-off-by: Jacob Keller > > Adding Shimoda-san who may be able to help coordinate a review if > Niklas and Paul are unavailable for some reason. Sorry for the noise. I now see that Niklas has reviewed v2.