From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 072FFC28B2F for ; Tue, 18 Mar 2025 14:08:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C162E6062E; Tue, 18 Mar 2025 14:08:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id odQ6gsqXBAjj; Tue, 18 Mar 2025 14:08:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2D6EE60B39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1742306935; bh=jcStHYE0d05GPaozUGu7SMnLuPqngMwkeZQH81Gl3p4=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=8R6Rnarl1r1FMrJhdmf/fHRQIfjgo9OV8KlrCfaz6ZHbi7l8RWDYw30dEhNqPvSD/ 8zQ7XzqVwR1W62MXh1YHJM+jMT5t9PXlznuf5vHkfbYIKm/KdOcO5p+SgBe7asA9Hq d2gGS6VED15yrSpNG+ogK9AJHPuXmMdpt3K05Ijaxfh7ttpCitu0lSppN+CTLAEVyQ D/KrNetwFTJq61C2mVPU+RRtU3XJ1nG1B+Ol3H/zOmcGkQwifi4uYNu4QywdOLhMeH bdDU5xQCCFVWyUF3sQPsESw7Bqta+DvnoX3J1HYmznlRzhePAM+dh0tb1lqRbxBOou 3R24JZR6exr7A== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 2D6EE60B39; Tue, 18 Mar 2025 14:08:55 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id DC60F950 for ; Tue, 18 Mar 2025 14:08:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C555480EF7 for ; Tue, 18 Mar 2025 14:08:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TZIU5DNZZ-5F for ; Tue, 18 Mar 2025 14:08:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1326080E49 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1326080E49 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1326080E49 for ; Tue, 18 Mar 2025 14:08:52 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 824AEA45F0B; Tue, 18 Mar 2025 14:03:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FDADC4CEDD; Tue, 18 Mar 2025 14:08:46 +0000 (UTC) Date: Tue, 18 Mar 2025 14:08:45 +0000 From: Simon Horman To: Jacob Keller Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Ruud Bos , Paul Barker , Niklas =?utf-8?Q?S=C3=B6derlund?= , Bryan Whitehead , UNGLinuxDriver@microchip.com, Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , Jonathan Lemon , Lasse Johnsen , Vadim Fedorenko , Michal Swiatkowski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Message-ID: <20250318140845.GX688833@kernel.org> References: <20250312-jk-net-fixes-supported-extts-flags-v2-0-ea930ba82459@intel.com> <20250312-jk-net-fixes-supported-extts-flags-v2-3-ea930ba82459@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312-jk-net-fixes-supported-extts-flags-v2-3-ea930ba82459@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742306931; bh=zwEgifMobld4uUocUPMZBeRolUHzD/YMncdDMRuLpC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=osX268sMbEfFNm+edoVczlAYnHxXzFwrBFGHGiH++bobaKSWhEM5NxDKNNOlLTDbd 1geugkMov15jvkOhrRO5ScFFmBwwkk7eGfhvsU+dedlI8VWDHw0Fu8PioDyIgOXqzz +uAm5u4gx+oMEKkdRpMLb3KX7JW+ikb6aoVUb7P/lzNQ5vVfq+GD3/CDjWzHHdNz15 9gaWRszIaSajQSkl4jNRALSaWG2EVADV8W3wIfmFSYsjtH4vGASNi/0wa4IfbBDlCD ZbtDFJndS6CUwNWyFq2VeLVwFFoxQngFFuCi8/aG6TtapzZkSBtN0A22zL240moNOP FbPOQURQFHUeA== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=osX268sM Subject: Re: [Intel-wired-lan] [PATCH net v2 3/5] net: lan743x: reject unsupported external timestamp requests X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Mar 12, 2025 at 03:15:52PM -0700, Jacob Keller wrote: > The lan743x_ptp_io_event_cap_en() function checks that the given request > sets only one of PTP_RISING_EDGE or PTP_FALLING_EDGE, but not both. > > However, this driver does not check whether other flags (such as > PTP_EXT_OFF) are set, nor whether any future unrecognized flags are set. > > Fix this by adding the appropriate check to the lan743x_ptp_io_extts() > function. > > Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)") > Signed-off-by: Jacob Keller Reviewed-by: Simon Horman