From: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Chwee-Lin Choong <chwee.lin.choong@intel.com>
Subject: [Intel-wired-lan] [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation
Date: Wed, 14 May 2025 00:29:45 -0400 [thread overview]
Message-ID: <20250514042945.2685273-9-faizal.abdul.rahim@linux.intel.com> (raw)
In-Reply-To: <20250514042945.2685273-1-faizal.abdul.rahim@linux.intel.com>
From: Chwee-Lin Choong <chwee.lin.choong@intel.com>
A hardware-padded frame transmitted from the preemptible queue
results in an incorrect mCRC computation by hardware, as the
padding bytes are not included in the mCRC calculation.
To address this, manually pad frames in preemptible queues to a
minimum length of 60 bytes using skb_padto() before transmission.
This ensures that the hardware includes the padding bytes in the
mCRC computation, producing a correct mCRC value.
Signed-off-by: Chwee-Lin Choong <chwee.lin.choong@intel.com>
Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 4d748eca0c6c..509f95651f25 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1685,6 +1685,15 @@ static netdev_tx_t igc_xmit_frame_ring(struct sk_buff *skb,
first->tx_flags = tx_flags;
first->protocol = protocol;
+ /* For preemptible queue, manually pad the skb so that HW includes
+ * padding bytes in mCRC calculation
+ */
+ if (tx_ring->preemptible && skb->len < ETH_ZLEN) {
+ if (skb_padto(skb, ETH_ZLEN))
+ goto out_drop;
+ skb_put(skb, ETH_ZLEN - skb->len);
+ }
+
tso = igc_tso(tx_ring, first, launch_time, first_flag, &hdr_len);
if (tso < 0)
goto out_drop;
--
2.34.1
next prev parent reply other threads:[~2025-05-14 4:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 4:29 [Intel-wired-lan] [PATCH iwl-next v2 0/8] igc: harmonize queue priority and add preemptible queue support Faizal Rahim
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 1/8] igc: move TXDCTL and RXDCTL related macros Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 2/8] igc: add DCTL prefix to " Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 3/8] igc: refactor TXDCTL macros to use FIELD_PREP and GEN_MASK Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 4/8] igc: assign highest TX queue number as highest priority in mqprio Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 5/8] igc: add private flag to reverse TX queue priority in TSN mode Faizal Rahim
2025-05-16 9:45 ` Simon Horman
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 6/8] igc: add preemptible queue support in taprio Faizal Rahim
2025-05-14 4:29 ` [Intel-wired-lan] [PATCH iwl-next v2 7/8] igc: add preemptible queue support in mqprio Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim [this message]
2025-05-16 9:43 ` [Intel-wired-lan] [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation Simon Horman
2025-05-19 6:27 ` Abdul Rahim, Faizal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514042945.2685273-9-faizal.abdul.rahim@linux.intel.com \
--to=faizal.abdul.rahim@linux.intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=chwee.lin.choong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox