intel-wired-lan.osuosl.org archive mirror
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH v2 1/2] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set
@ 2025-06-23 15:58 Jacek Kowalski
  2025-06-23 16:01 ` [Intel-wired-lan] [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform Jacek Kowalski
  0 siblings, 1 reply; 10+ messages in thread
From: Jacek Kowalski @ 2025-06-23 15:58 UTC (permalink / raw)
  To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: intel-wired-lan, netdev, linux-kernel

As described by Vitaly Lifshits:

> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
> driver cannot perform checksum validation and correction. This means
> that all NVM images must leave the factory with correct checksum and
> checksum valid bit set. Since Tiger Lake devices were the first to have
> this lock, some systems in the field did not meet this requirement.
> Therefore, for these transitional devices we skip checksum update and
> verification, if the valid bit is not set.

Signed-off-by: Jacek Kowalski <Jacek@jacekk.info>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
Cc: stable@vger.kernel.org
---
v1 -> v2: updated patch description
 drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 364378133526..df4e7d781cb1 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -4274,6 +4274,8 @@ static s32 e1000_validate_nvm_checksum_ich8lan(struct e1000_hw *hw)
 			ret_val = e1000e_update_nvm_checksum(hw);
 			if (ret_val)
 				return ret_val;
+		} else if (hw->mac.type == e1000_pch_tgp) {
+			return 0;
 		}
 	}
 
-- 
2.47.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-06-24 18:54 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-23 15:58 [Intel-wired-lan] [PATCH v2 1/2] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set Jacek Kowalski
2025-06-23 16:01 ` [Intel-wired-lan] [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform Jacek Kowalski
2025-06-23 16:18   ` Jacek Kowalski
2025-06-24 18:17     ` Vlad URSU
2025-06-24 18:34       ` Jacek Kowalski
2025-06-24 18:54         ` Vlad URSU
2025-06-24  9:53   ` Simon Horman
2025-06-24 12:51     ` Jacek Kowalski
2025-06-24 16:03       ` Simon Horman
2025-06-24 16:08         ` Jacek Kowalski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).