From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Andrew Lunn <andrew@lunn.ch>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Donald Hunter <donald.hunter@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report
Date: Mon, 11 Aug 2025 09:21:42 -0700 [thread overview]
Message-ID: <20250811092142.5b9288d5@kernel.org> (raw)
In-Reply-To: <34da824b-1922-418f-953f-99287443b088@linux.dev>
On Mon, 11 Aug 2025 17:08:34 +0100 Vadim Fedorenko wrote:
> On 11/08/2025 16:41, Jakub Kicinski wrote:
> > On Sun, 10 Aug 2025 11:52:55 +0100 Vadim Fedorenko wrote:
> >> Well, the current implementation is straight forward. Do you propose to
> >> have drivers fill in the amount of lanes they have histogram for, or
> >> should we always put array of ETHTOOL_MAX_LANES values and let
> >> user-space to figure out what to show?
> >
> > Similar logic to what you have, you can move the put outside of the
> > loop, let the loop break or exit, and then @j will tell you how many
> > entries to fill..
>
> I see. Fair, I can do it. After this change there will be no need to
> change the code in the reply size calculation, right?
I think you need to split in two, one for the normal val and one for
the array.
prev parent reply other threads:[~2025-08-11 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 15:59 [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report Vadim Fedorenko
2025-08-08 20:15 ` Jakub Kicinski
2025-08-10 10:52 ` Vadim Fedorenko
2025-08-11 15:41 ` Jakub Kicinski
2025-08-11 16:08 ` Vadim Fedorenko
2025-08-11 16:21 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811092142.5b9288d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=donald.hunter@gmail.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).