From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CB7DCAC5A5 for ; Wed, 24 Sep 2025 00:27:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B5E5F61367; Wed, 24 Sep 2025 00:27:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zbvNLzGSF6DC; Wed, 24 Sep 2025 00:27:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5C6036125F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1758673673; bh=1JN0mgRK5y2iI4aB9BwxFTYq1NjnoUPfXCywQTzOLiw=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LWhp2DLXVTAg87nb/B6k2Ls+EPTHXsA26Ho1iDp1nOwxb4+QnCTU2orQak86ICkaX tNP7uQ+kDmPCeKsk/gzdl4TxmKrzBDBVUm/wLPlipL/KEY5CewWhw96Citnv3z2/SB /Yy1wi51RvKVVkpLqtEwDjjx5hjTEYQOxrsH8xDwh0q/yWwoJf4HIGKl+WuX9YmUf+ vuyZzqyjrHO8Kwk2GCEijvSUkWdSRxfweXmuMBjvhX4RBVaO46TTXQVAhRtXuvOumm kWq9Zs0RR45s6uNLQbPYST9oFiU0Ui0mT1v5bQJcf5MTIdhxlpX8IuX/4Py0iWMEJt 7cCAjLa26YJFw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 5C6036125F; Wed, 24 Sep 2025 00:27:53 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id E01CAE7 for ; Wed, 24 Sep 2025 00:27:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D132983C5F for ; Wed, 24 Sep 2025 00:27:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id hlfQRquh1Gaz for ; Wed, 24 Sep 2025 00:27:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 436D583C66 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 436D583C66 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp1.osuosl.org (Postfix) with ESMTPS id 436D583C66 for ; Wed, 24 Sep 2025 00:27:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 04D99601D4; Wed, 24 Sep 2025 00:27:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AEDDC4CEF5; Wed, 24 Sep 2025 00:27:49 +0000 (UTC) Date: Tue, 23 Sep 2025 17:27:48 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , intel-wired-lan@lists.osuosl.org, Donald Hunter , Carolina Jubran , Aleksandr Loktionov , Paolo Abeni , Simon Horman , netdev@vger.kernel.org Message-ID: <20250923172748.7269e6f7@kernel.org> In-Reply-To: <20250922100741.2167024-2-vadim.fedorenko@linux.dev> References: <20250922100741.2167024-1-vadim.fedorenko@linux.dev> <20250922100741.2167024-2-vadim.fedorenko@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758673669; bh=0jZz5CUadTlqMTZqsY4u85H5twUdMl/A+qFlWUZs9OA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NcbTa/mj0Vr39Mf/kc/FiXh0PWzMXcAvLEwjViTOhxqZfEomV3Po7c0r5ttwQ8RbS QkUB3d3/QLl7oQFTgZyFcaYn1tOn93lqeTIgvnIF/l3OmtaRQbJryu6AOossyjaNeE CGaU0MJGOJp2xqAWSv9m5CxYMONSeXM07GwJwF23HhLDpsRSYFW44DMJh1YVPsKN6e +h/d7P80iQWO+NGUZM11szOypv7B6fZEl+hDsBTarEzKyr9mzr7pi6dRScQPUDID3H 59Jom7enwuH51eoA5ygvr+cMip1/h/+uXGmAT3yo59EwlB8SmnXKyE3onU6Cl1/U7J /otA/AeJXgqjg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=NcbTa/mj Subject: Re: [Intel-wired-lan] [PATCH net-next v5 1/5] ethtool: add FEC bins histogram report X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 22 Sep 2025 10:07:37 +0000 Vadim Fedorenko wrote: > + if (j && nla_put_64bit(skb, ETHTOOL_A_FEC_HIST_BIN_VAL_PER_LANE, > + sizeof(u64) * j, > + values[i].per_lane, > + ETHTOOL_A_FEC_STAT_PAD)) The pad attribute needs to be from the same attr space as the attr you're outputting. You need to create your own pad attr in the spec.