From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CC31CCFA04 for ; Tue, 4 Nov 2025 19:22:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1610E40E18; Tue, 4 Nov 2025 19:22:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id t_CiWsaDtTAi; Tue, 4 Nov 2025 19:22:22 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8E4DF40E19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1762284142; bh=Olxv1rxRmXd1BhX+5sdrwYpA0F1vfnEwNxNkuO82J30=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BmsHWnoBOaShsgWo7Q+/h/jMUeEXAtPgl1elCMDbh/GIybUvHnkKHWRkfPIMRmnGZ NpriHH5Bj0IJJj1fqvZiZjEqQ2/cj+GYh8raYdpyO199yDlI/FAnsM1zumVhZyLpvv Db792JZaTtZkhiGU6BxzZdkROMCflgls+rJq1WOJ+mYm1kW6vD9r+jmoYOQGSLZGgG IdLDxJDkJXIhiIytvNrLxAKT4XT2Fk239f+EQEkjocwMNaCdLnJKYsGmef5vcbHVDw PcM/icKXliqFKSU6f16xhHfEKvRoLdqHysejBo79SWszdKIO/hDjxDI7GsQSsrx/3+ hMYTIX9tBzdKw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 8E4DF40E19; Tue, 4 Nov 2025 19:22:22 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 7F180462 for ; Tue, 4 Nov 2025 19:22:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 70EDD61080 for ; Tue, 4 Nov 2025 19:22:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id doIDoHC_fJCV for ; Tue, 4 Nov 2025 19:22:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BA0EC6107F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BA0EC6107F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp3.osuosl.org (Postfix) with ESMTPS id BA0EC6107F for ; Tue, 4 Nov 2025 19:22:20 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8F82D60208; Tue, 4 Nov 2025 19:22:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A88DC16AAE; Tue, 4 Nov 2025 19:22:15 +0000 (UTC) Date: Tue, 4 Nov 2025 11:22:14 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: Daniel Zahka , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Srujana Challa , Bharat Bhushan , Herbert Xu , Brett Creeley , Andrew Lunn , Michael Chan , Pavan Chebbi , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , Maxime Coquelin , Alexandre Torgue , Siddharth Vadapalli , Roger Quadros , Loic Poulain , Sergey Ryazanov , Johannes Berg , Vladimir Oltean , Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman , Vlad Dumitrescu , "Russell King (Oracle)" , Alexander Sverdlin , Lorenzo Bianconi , netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20251104112214.7f60b252@kernel.org> In-Reply-To: References: <20251103194554.3203178-1-daniel.zahka@gmail.com> <20251103194554.3203178-3-daniel.zahka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762284138; bh=+lf7dW++l2EW9+9yEsAcle5UBElW4w+UfVpXaHOHW2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B+/TZv1XRq0zzd5NbGu3Z9bN5OyQZnNOsope6laxMrWxA3/9XRg7VX+3PhsjNe7lW 5cbgxn6SqwRaVkJbyodTHSn0LdeO5DaMLbCFV/YkdMgryijwrq6LyocnrsiVuNyhLv xHsrmZselWKpvNIRQMjhLTdiIa0VnfoixY52BS0uFlEVig1wBgEFGzD/T3bGyB56e6 1l8b7lD0a36nrmABwnEvq70bPZRM5IzkSVy7iTQN+TPjab7k/GpzkYFUllJxth410q 4+JiRU+f29KNZ9lJy0ZuU0cQlh4AQfIsQMj0TIhuqexc7SbGFrZJBc5IimM07mEMvE R1RZeW1bSnP0w== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=B+/TZv1X Subject: Re: [Intel-wired-lan] [PATCH net-next v2 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 4 Nov 2025 11:14:03 +0100 Jiri Pirko wrote: > >@@ -548,6 +703,12 @@ static const struct devlink_param mlx5_nv_param_devlink_params[] = { > > mlx5_nv_param_devlink_cqe_compress_get, > > mlx5_nv_param_devlink_cqe_compress_set, > > mlx5_nv_param_devlink_cqe_compress_validate), > >+ DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_SWP_L4_CSUM_MODE, > >+ "swp_l4_csum_mode", DEVLINK_PARAM_TYPE_STRING, > > I still think that even unlikely this will be implemented in other > driver, it is generic param. Could you please treat it as such? We need a clearer definition of what this does then. Is it basically disabling silicon validation of L4 checksum and allows for the FW to compute the L4 checksum? Which may negatively impact performance? (hence disabled by default?)