From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 504E4CCFA13 for ; Mon, 10 Nov 2025 22:58:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E7D62408AE; Mon, 10 Nov 2025 22:58:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id NURAdOcSNjZw; Mon, 10 Nov 2025 22:58:37 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CCCEC403CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1762815517; bh=xEj6eZpyv1UfaAPzBSAVdY3T3blXd1bKHdMkO9FrXCg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=75KkYoQRZBNmFDrsct+n4y9NoZyAxGwQohXZ7rC6EeUPOYpTqnJtGG/4ny930UFJa M7Ht4i2+ooqMK9eIKSPiATnQ6rSNgbbwnR6CuoKFbzoa8UxGToMYs2Wb9HFHoH1r3f NJD94UL820puvMP4reD0bS1Md1XiScwWzN8xEoRmzyPF7+GwZApfBDXbSrTrZq6cEC s9+JO3dI9v8OPuq9h5a6kHPo69HxuWG69kwue2YhlsUj+qqMifDyUGLK4MnkxXk4wL U2cFtPrl7Xix2Fg3Q2NMSB2BG3DAlXZDj4v8it/MQHlixyf9ELUtvODmmNVjaYSoQB EF0K5FxsIhe1g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id CCCEC403CF; Mon, 10 Nov 2025 22:58:37 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 6D3E6FA for ; Mon, 10 Nov 2025 22:58:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 579B6406D2 for ; Mon, 10 Nov 2025 22:58:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oHNgjoxRlQVe for ; Mon, 10 Nov 2025 22:58:35 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org A4EA740639 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A4EA740639 Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id A4EA740639 for ; Mon, 10 Nov 2025 22:58:35 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D5AAA44197; Mon, 10 Nov 2025 22:58:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADE8DC16AAE; Mon, 10 Nov 2025 22:58:32 +0000 (UTC) Date: Mon, 10 Nov 2025 14:58:31 -0800 From: Jakub Kicinski To: Daniel Zahka Cc: Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Srujana Challa , Bharat Bhushan , Herbert Xu , Brett Creeley , Andrew Lunn , Michael Chan , Pavan Chebbi , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , Maxime Coquelin , Alexandre Torgue , Siddharth Vadapalli , Roger Quadros , Loic Poulain , Sergey Ryazanov , Johannes Berg , Vladimir Oltean , Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman , Vlad Dumitrescu , "Russell King (Oracle)" , Alexander Sverdlin , Lorenzo Bianconi , netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20251110145831.15872b86@kernel.org> In-Reply-To: <25ebaf18-f009-45de-a3e4-fe440c42ef19@gmail.com> References: <20251107204347.4060542-1-daniel.zahka@gmail.com> <20251107204347.4060542-3-daniel.zahka@gmail.com> <25ebaf18-f009-45de-a3e4-fe440c42ef19@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762815514; bh=gp119oKTnpbHC1P/d+n3Qm9C5OlbMz4VTP9qPySDarM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wv5sTKvK8Fth+8Ulry2nulV4xCEtVBXnwIhWHQPmidsRNLKwkQ3d5V0GD068+lAO9 LI3OqSg5CRVEyB//hIYRvUHrLnqzWExmmbDT9Z1UchTDbOP3Ryw9ll2uDjt6HDWyWj 6KPxk/pHL763G49ToN0WUTIrt7+ddlaAHxfdQwJIFbCcTTqelmfK6pM2GNLDRQ4vys AfRF6fB43wY/PHKCpH1Uvy2oCOSMxac7NhkYiYrR01l/n/URrTywQFpukP74NlCWWD I99Zqwa+C5Z/WJT4fbNe3yCmM0qcOl3BeAEHvVNQphNd/uswiSxOEDkg692CA0h6BI d9gnLkn/HQN4w== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Wv5sTKvK Subject: Re: [Intel-wired-lan] [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 10 Nov 2025 08:05:57 -0500 Daniel Zahka wrote: > On 11/9/25 5:39 AM, Jiri Pirko wrote: > > Daniel, I asked twice if this could be a non-driver param. Jakub asked > > for clearer definition of this know in that context. > > > > Not sure why you are ignoring this :/ > > > > My apologies. I think there was a miscommunication. I assumed Jakub's > question was directed towards you. I have no objection to making it a > generic param; I will do so in v4. It sounded to me like Jakub was > wanting more information on what exactly this setting does beyond what I > was able to provide in the commit message and mlx5 devlink > documentation. My understanding is that this setting pertains to tx > csums and how the device expects the driver to prepare partial csums > when doing tx cso. I don't really know more than that. Especially not > something like what the FW's role in implementing this is. Right, per To: field of my email I as asking Jiri for clarifications. Since we struggle to understand the semantics nack on making this generic. Chances are whoever reuses the "generic" param will have a different interpretation of its meaning, so what's the point of making it generic.