From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFED0CCFA1A for ; Tue, 11 Nov 2025 15:34:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7FDD24084F; Tue, 11 Nov 2025 15:34:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ERSylIDxjXmB; Tue, 11 Nov 2025 15:34:20 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B121C408AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1762875260; bh=4j8ZKzszseIjZ7pfR2T/668BGyXjq5DTM+7l1c3vmKM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=4KMl9GOI4VxlZRsxRd7bMjd18GrryfyNlkikpuh1XmPsROFAV4cVYHjE8RfVavXbn 1a2eH5NGXIh6U8TyrBztw4SAAmHgzDrGW5r2Spf3mn6Sq0TfxKoeKMZPz8Nmhq0/Vh GxzEUb6Joa7wMDnAT1SiHuDrGVlrYSyDfTco1WWhFPGHIX8IMnRmUPAZqr5/916H0h oZ3szijz4Un1JAGkgKa16o8Igax7CX73lVo/lAxpICcMpuqSnl1oVKw/2PS3QZITTH 2aX3iowvciYgCCOZPoiJAdOaegkf7eW42y7fA0b5kUzs/U4sbUpJzcDQ1spIj/yfEB fu7bCmL2zC8dw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id B121C408AF; Tue, 11 Nov 2025 15:34:20 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id DC36B25D for ; Tue, 11 Nov 2025 15:34:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CE089408AF for ; Tue, 11 Nov 2025 15:34:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Wk09OHSoQQap for ; Tue, 11 Nov 2025 15:34:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org CFDB34084F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CFDB34084F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp4.osuosl.org (Postfix) with ESMTPS id CFDB34084F for ; Tue, 11 Nov 2025 15:34:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8B02660205; Tue, 11 Nov 2025 15:34:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F987C4CEF5; Tue, 11 Nov 2025 15:34:13 +0000 (UTC) Date: Tue, 11 Nov 2025 07:34:12 -0800 From: Jakub Kicinski To: Saeed Mahameed Cc: Daniel Zahka , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Srujana Challa , Bharat Bhushan , Herbert Xu , Brett Creeley , Andrew Lunn , Michael Chan , Pavan Chebbi , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , Maxime Coquelin , Alexandre Torgue , Siddharth Vadapalli , Roger Quadros , Loic Poulain , Sergey Ryazanov , Johannes Berg , Vladimir Oltean , Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman , Vlad Dumitrescu , "Russell King (Oracle)" , Alexander Sverdlin , Lorenzo Bianconi , netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20251111073412.5aa12e38@kernel.org> In-Reply-To: References: <20251107204347.4060542-1-daniel.zahka@gmail.com> <20251107204347.4060542-3-daniel.zahka@gmail.com> <20251110150133.04a2e905@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762875255; bh=/IiWVNswHcrotcXImuZbhDizvXR5f83IzztpfhJsS3g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C387oCWRJx0kXDCxVdceMrAw7Xp2ONrwf4fzsso3ilHBN5eUDEfDZc5gln26HIGHS QREeK2eYI5DB0V23P5YE8svKzYb0H0AfOXgoYultzhBBFQiTNuKRdO+ACLwEiqbOKy vFXuH/7UdT7zdJsvrSeDbmZNG7p2v0YmZOXzVdxc1ejFVQmXzaTVfQB+CL4ky9CiLP XkADHhMZkYQsAmvyySufJL72zovyGm+I26vbA/NJmxqPjzNLCA7O/HCSG9hLnQ0h3T 1sR4//vn0OwcGa60PW9qgnyqkXWU9IY7XQADFO6bAuP8DOdUZyRkBfYhAVf8i0zu+w 3DOhKUCwD9ZsA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=C387oCWR Subject: Re: [Intel-wired-lan] [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 10 Nov 2025 19:34:40 -0800 Saeed Mahameed wrote: > On 10 Nov 15:01, Jakub Kicinski wrote: > >On Fri, 7 Nov 2025 22:14:45 -0800 Saeed Mahameed wrote: > >> Plug in the err, NL_SET_ERR_MSG_FMT_MOD(.., .., err); > >> other locations as well. > > > >Incorrect. extack should basically be passed to perror() > >IOW user space will add strerror(errno) after, anyway. > >Adding the errno inside the string is pointless and ugly. > > ernno set by stack. err set by driver. we can't assume err will propagate > to errno, this is up to the stack. > > And not at all ugly, very useful debug hint to the user, unless you > guarantee err == errno. Not propagating errno should be fixed, if that happens. We need clear expectations to avoid the messages being all over the place. Historically we haven't included err because formatting was not an option. So I think we should continue this way.