From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71092D33995 for ; Fri, 5 Dec 2025 16:56:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2295B84999; Fri, 5 Dec 2025 16:56:06 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8zWlVsKUspOr; Fri, 5 Dec 2025 16:56:04 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A19BD84985 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1764953764; bh=2yxTSvuS6r89LET5K5JxIhOhcWNrXuNTxkuDEWyrKTg=; h=From:To:CC:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Co30lzgNQpBKgyzTEsp2drz7n33ZI3uKPab/gcKRhPfGU2G61Kd6RxmfsvZc48aRs pQfAKoEInjDbK6nMKU0aXgIlD+JSg5mAT+L3DrvH9Me/kRFZ1wxYsS6EVXADyeHH6o 2trtWBY+uKeiy8QjtiMItA7Ebsvpt6wh89474auw6lRbhv4Cw+aYy1+zIdnaCxkqzr AA5OiOkQA2Z+sYfQo+UaKxG+B9tcPg8FH8AE7e7WKpXX3+OLJgmyIAw9rfpyPX9ibq grAVl8D6ezNAHgrTr/qs0GqdQCc7zW4w+GCKj4i4SeXXrMfBa6cKDNZprw73d5UDKg 4M3eEKnNTspdA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id A19BD84985; Fri, 5 Dec 2025 16:56:04 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id D36A7E7 for ; Fri, 5 Dec 2025 08:22:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BA0E6411F9 for ; Fri, 5 Dec 2025 08:22:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aljcW_8W8_Vd for ; Fri, 5 Dec 2025 08:22:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=52.42.203.116; helo=pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com; envelope-from=prvs=427ee495b=takkozu@amazon.co.jp; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org BDB744032A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BDB744032A Received: from pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com [52.42.203.116]) by smtp2.osuosl.org (Postfix) with ESMTPS id BDB744032A for ; Fri, 5 Dec 2025 08:22:20 +0000 (UTC) X-CSE-ConnectionGUID: vR98Ikc5Qe+WgcLO0LbK7A== X-CSE-MsgGUID: dBno5VIRQV+Q4OlwGGXRIg== X-IronPort-AV: E=Sophos;i="6.20,251,1758585600"; d="scan'208";a="8477422" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2025 08:22:16 +0000 Received: from EX19MTAUWA002.ant.amazon.com [205.251.233.234:25793] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.51.201:2525] with esmtp (Farcaster) id 5db10035-a247-44f8-ae70-f4859b2a997d; Fri, 5 Dec 2025 08:22:16 +0000 (UTC) X-Farcaster-Flow-ID: 5db10035-a247-44f8-ae70-f4859b2a997d Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Fri, 5 Dec 2025 08:22:16 +0000 Received: from 603e5f7bc1fe.amazon.com (10.37.244.13) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Fri, 5 Dec 2025 08:22:14 +0000 From: Takashi Kozu To: CC: , , , , , , , , Takashi Kozu , Kohei Enju Date: Fri, 5 Dec 2025 17:21:05 +0900 Message-ID: <20251205082106.4028-6-takkozu@amazon.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20251205082106.4028-5-takkozu@amazon.com> References: <20251205082106.4028-5-takkozu@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.37.244.13] X-ClientProxiedBy: EX19D033UWA001.ant.amazon.com (10.13.139.103) To EX19D001UWA001.ant.amazon.com (10.13.138.214) X-Mailman-Approved-At: Fri, 05 Dec 2025 16:56:02 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1764922940; x=1796458940; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2yxTSvuS6r89LET5K5JxIhOhcWNrXuNTxkuDEWyrKTg=; b=f5o4C61W9jGBy1tgkY32PS8p31x43NpT9uoMuWitLdyzB2iM6M2hKHsA rhMjSQ3DjiqcsXfMslnB8sV35eB6CFybIiWxHPQm2Ca9EGdSS/JBbkEIQ vpBoISHJxcMGaWwKfvKhhE7XFOvgcQsywt3DnyA7TKRPeKfWuQYMZytjO C9Dx7LgOleAux3tgocJh6kA14Z4f97jDSzZa/gyXqxfymVk9h1+WKVS3r dMQNBAGdRyysjJ8GZLyKo7mOIMpM2NhljZgr+/TgXmt6+fhprqrIcVWVf y4txOmujLgsEx7nSLto20LSvekJp24W3vdxR3YLYe5o5bSslMNittG32b g==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=f5o4C61W Subject: [Intel-wired-lan] [PATCH iwl-next v1 1/3] Store the RSS key inside struct igb_adapter and introduce the X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Store the RSS key inside struct igb_adapter and introduce the igb_write_rss_key() helper function. This allows the driver to program the E1000 registers using a persistent RSS key, instead of using a stack-local buffer in igb_setup_mrqc(). Tested-by: Kohei Enju Signed-off-by: Takashi Kozu --- drivers/net/ethernet/intel/igb/igb.h | 3 +++ drivers/net/ethernet/intel/igb/igb_ethtool.c | 12 ++++++++++++ drivers/net/ethernet/intel/igb/igb_main.c | 6 ++---- 3 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h index 0fff1df81b7b..8c9b02058cec 100644 --- a/drivers/net/ethernet/intel/igb/igb.h +++ b/drivers/net/ethernet/intel/igb/igb.h @@ -495,6 +495,7 @@ struct hwmon_buff { #define IGB_N_PEROUT 2 #define IGB_N_SDP 4 #define IGB_RETA_SIZE 128 +#define IGB_RSS_KEY_SIZE 40 enum igb_filter_match_flags { IGB_FILTER_FLAG_ETHER_TYPE = 0x1, @@ -655,6 +656,7 @@ struct igb_adapter { struct i2c_client *i2c_client; u32 rss_indir_tbl_init; u8 rss_indir_tbl[IGB_RETA_SIZE]; + u8 rss_key[IGB_RSS_KEY_SIZE]; unsigned long link_check_timeout; int copper_tries; @@ -735,6 +737,7 @@ void igb_down(struct igb_adapter *); void igb_reinit_locked(struct igb_adapter *); void igb_reset(struct igb_adapter *); int igb_reinit_queues(struct igb_adapter *); +void igb_write_rss_key(struct igb_adapter *adapter); void igb_write_rss_indir_tbl(struct igb_adapter *); int igb_set_spd_dplx(struct igb_adapter *, u32, u8); int igb_setup_tx_resources(struct igb_ring *); diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index 10e2445e0ded..8695ff28a7b8 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -3016,6 +3016,18 @@ static int igb_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd) return ret; } +void igb_write_rss_key(struct igb_adapter *adapter) +{ + struct e1000_hw *hw = &adapter->hw; + u32 val; + int i; + + for (i = 0; i < IGB_RSS_KEY_SIZE / 4; i++) { + val = get_unaligned_le32(&adapter->rss_key[i * 4]); + wr32(E1000_RSSRK(i), val); + } +} + static int igb_get_eee(struct net_device *netdev, struct ethtool_keee *edata) { struct igb_adapter *adapter = netdev_priv(netdev); diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 85f9589cc568..da0f550de605 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -4525,11 +4525,9 @@ static void igb_setup_mrqc(struct igb_adapter *adapter) struct e1000_hw *hw = &adapter->hw; u32 mrqc, rxcsum; u32 j, num_rx_queues; - u32 rss_key[10]; - netdev_rss_key_fill(rss_key, sizeof(rss_key)); - for (j = 0; j < 10; j++) - wr32(E1000_RSSRK(j), rss_key[j]); + netdev_rss_key_fill(adapter->rss_key, sizeof(adapter->rss_key)); + igb_write_rss_key(adapter); num_rx_queues = adapter->rss_queues; -- 2.51.1