From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1BF4D29DC2 for ; Tue, 13 Jan 2026 03:09:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A64EA412CC; Tue, 13 Jan 2026 03:09:02 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id O_KjimFwKt51; Tue, 13 Jan 2026 03:09:01 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CF454412C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1768273741; bh=FIFEbodwzQLUxMX4W0oFQA80yOHFLrvq8u3ausPe5bU=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BCkAPPlePWGzGkTakRCOHtTM7uiV7AqPAP+a610cQ6OusBNVWVKQu+461XRX/LN0B EHlAIkNqwBFqkt0gpOGldDPrri1/9+Xq25zS/z/0+2qsg/9HbL9r83ircM8ehBdrra 8boYZ2k3CqhTYEMPV7082L9t2TKDikgHpeoQ6qqr03b4BnQsHLwZ0DOPVPuEzMKXuD OttTDwuGWQFwG4hjk7vfp2mDpPgxbFfEfFnfsF4J1e9tIaNFStxlvEDgd4H8jRmYyP b/+/S0/1RYiDSMPo0T0r5UPBE7ZoRtmmWks26I1RBmMLCv7aaGbxfW2ziuJ6zpetYi 7U7eMJwuRYSNQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id CF454412C3; Tue, 13 Jan 2026 03:09:01 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 1C50218D for ; Tue, 13 Jan 2026 03:09:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0D49184243 for ; Tue, 13 Jan 2026 03:09:00 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id MIYNne9qLZLU for ; Tue, 13 Jan 2026 03:08:59 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 43F168422B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 43F168422B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp1.osuosl.org (Postfix) with ESMTPS id 43F168422B for ; Tue, 13 Jan 2026 03:08:59 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 718A64328A; Tue, 13 Jan 2026 03:08:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40EF2C116D0; Tue, 13 Jan 2026 03:08:57 +0000 (UTC) Date: Mon, 12 Jan 2026 19:08:56 -0800 From: Jakub Kicinski To: Jakub Sitnicki Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Michael Chan , Pavan Chebbi , Andrew Lunn , Tony Nguyen , Przemek Kitszel , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , intel-wired-lan@lists.osuosl.org, bpf@vger.kernel.org, kernel-team@cloudflare.com Message-ID: <20260112190856.3ff91f8d@kernel.org> In-Reply-To: <20260110-skb-meta-fixup-skb_metadata_set-calls-v1-0-1047878ed1b0@cloudflare.com> References: <20260110-skb-meta-fixup-skb_metadata_set-calls-v1-0-1047878ed1b0@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768273738; bh=5xE/UzPxx8Afb98pxY1v4ktqur7bu8ogwAB86SInQLY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TxCxXi1YYxnJS0sw3EBgIsVaZR29gHP1MwekE7jvJ7HN9K66f3ba7l45ZqRcdA4uf nuDNomQ8sQtAOoCE2XaXl2oNobHXeldazE0BSB7OPo16sSaF6+gh+d+3na5Oaq6oLO +lNZWxelFszTDqaj2FTYJ9qL8I4dN/0VSFpCXMgDETBmJequQVEQA0lO2kXvpvp2fH neG7Lf84hS1pPM0GbkHOpvFjmkCeniqNDr94VipaKGmg5nEwR7Ec1Wp3mH+RsqzP0E 0tUFv8j3TPBbUaoqIZDcO4V0p3YIPFLWreWrRrHIwGWWgfRVN2RrsoBdaRQQUvsz1m azzkhf9CVTgkA== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=TxCxXi1Y Subject: Re: [Intel-wired-lan] [PATCH net-next 00/10] Call skb_metadata_set when skb->data points past metadata X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, 10 Jan 2026 22:05:14 +0100 Jakub Sitnicki wrote: > This series is split out of [1] following discussion with Jakub. > > To copy XDP metadata into an skb extension when skb_metadata_set() is > called, we need to locate the metadata contents. "When skb_metadata_set() is called"? I think that may cause perf regressions unless we merge major optimizations at the same time? Should we defer touching the drivers until we have a PoC and some idea whether allocating the extension right away is manageable or we are better off doing it via a kfunc in TC (after GRO)? To be clear putting the metadata in an extension right away would indeed be much cleaner, just not sure how much of the perf hit we can optimize away..