From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A675D625E5 for ; Fri, 23 Jan 2026 06:58:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0BB9B8321B; Fri, 23 Jan 2026 06:58:26 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Ntxv_fyzgr1Q; Fri, 23 Jan 2026 06:58:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8188983224 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1769151505; bh=wNuK2/dOALJQhNEGtJ2LlGL6rosoPqMbD+3I0jKBgfc=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=PpMun2gtbaoZ+MJCfipHZ4L/Tp/AbrNmR9vWF+QT9i8qtKNOyrXeGs9DMPdA86zKN g4zKhmx/owvT74JELXvmFOtk6BdVfHJkK6eB8F/vNjnVzirfWNEGSYYUN0E3MIqycm UcFzCS9Db8f4+bj1gvBVU5oCRVprE+ZUqOkaiu0OCE2K4iYajaaJnfhzLppSlQbyTU WcMcULH5c1TgvF3JJVcvOdG1f9Q5homZcgS7Qf8jaWyUv6vxlilzt+2fCEdvrpOaHH mu5y5ciaOf0qyWrh3QZ1cHteEMWXX8oMfSPPgi7+KBVUVYuX0uoS6FA4YnR8bI5a4z jBBu5X5qGIkRA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 8188983224; Fri, 23 Jan 2026 06:58:25 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id D252B158 for ; Fri, 23 Jan 2026 06:58:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B585D4098C for ; Fri, 23 Jan 2026 06:58:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id jlP8PD3ys9Zc for ; Fri, 23 Jan 2026 06:58:23 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1249; helo=mail-dl1-x1249.google.com; envelope-from=3drxzaqykd2qdqqnnkiqqing.eqokpvgn-yktgf-ncpnkuvu.quwqun.qti@flex--boolli.bounces.google.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D83FF4088F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D83FF4088F Received: from mail-dl1-x1249.google.com (mail-dl1-x1249.google.com [IPv6:2607:f8b0:4864:20::1249]) by smtp4.osuosl.org (Postfix) with ESMTPS id D83FF4088F for ; Fri, 23 Jan 2026 06:58:22 +0000 (UTC) Received: by mail-dl1-x1249.google.com with SMTP id a92af1059eb24-11b94abc09dso2797252c88.1 for ; Thu, 22 Jan 2026 22:58:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769151502; x=1769756302; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wNuK2/dOALJQhNEGtJ2LlGL6rosoPqMbD+3I0jKBgfc=; b=id3/BY0Lh5eQUZeRZ0q9yYR/i2AQhBTFQR8TRbqy+Zy1bzFLDrBNR7bgMlnUDKa2Al 7Y6Ia7Wosj/nxyvkR64GwsOv049phEdeGD+wlcO+ZKAZval1RKlr6cnTgW2Eiow9TFgW Dr0nm2xEvywhlq3pC2tOUP6bopza24GviRjU9aDQVrNpcplkHpCwItpM6YiPSNhqbWNd L3UXwpbF5tqSVtLx2Okil4j3/fjutsrg7aWHMislq5rRYGT2e9d8hn89lxt5IZunmANV KZ02bIp4zGzIKj6S5tCquD2HFUNwq0o7OTP95jcBCorfBHjyGjnW+noE6lhgvH1cIhyV DJkQ== X-Forwarded-Encrypted: i=1; AJvYcCUSfuEUjlnKh5dkyqQbrYFgv80d5B3brRL4Iq/Zm9TrFVoKxyAMipIuCMKpswmCMaMymBbxdbDuXX/6WOMR+vY=@lists.osuosl.org X-Gm-Message-State: AOJu0YwzqcrL0puPTnxh+9H+++r4FEYKUO38WSGkxPCylRcaIMbElr1F nqKl5D4y87SyuXfMNPfxsYWmkvT8ROkegHUgcrDS8JduWRLCy4dGo1oHecw7wO7y0aQpRZ7yqci hNuprag== X-Received: from dlbuy11.prod.google.com ([2002:a05:7022:1e0b:b0:11f:3ccd:73d7]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:112:b0:11a:273c:dd98 with SMTP id a92af1059eb24-1247dbb0d6amr858556c88.20.1769151501761; Thu, 22 Jan 2026 22:58:21 -0800 (PST) Date: Fri, 23 Jan 2026 06:58:06 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260123065806.3858623-1-boolli@google.com> To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Type: text/plain; charset="UTF-8" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769151502; x=1769756302; darn=lists.osuosl.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=wNuK2/dOALJQhNEGtJ2LlGL6rosoPqMbD+3I0jKBgfc=; b=4YjMmmcVek0fEvx3NJkSOH3jngJqMRXdPHf78ofn0FYGQCPhsatnOvWRXtSY04oNwh pKH7R/zzEmGb/GFH1Uu5LS5BUq0DdWjOVogVOoepKc0+WAub9Qyabn2D/r6ecnVH7nlp xmByzhOHs0u/XJQAdnoLUQP/JVJxIH3IW3FcuyOukOwZsSYHf1GaeVT0XpDbRQKgEl7a fo5KUFzyJ7kde6POVKAvGykTz2GPgiJkez5xcZ+c4Z2MKuLB6WL5qk7lvQIAZJlam+PH SFy7e2EZQNu6tZHtEBVkaznGc/esZ9Dk5g3qTlYHgLgVsvPVWPVwOZHO2q17nYl+JusW CEoA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=reject dis=none) header.from=google.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=4YjMmmcV Subject: [Intel-wired-lan] [PATCH v2] idpf: nullify pointers after they are freed X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Li Li via Intel-wired-lan Reply-To: Li Li Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" rss_data->rss_key needs to be nullified after it is freed. Checks like "if (!rss_data->rss_key)" in the code could fail if it is not nullified. Tested: built and booted the kernel. Fixes: 83f38f210b85 ("idpf: Fix RSS LUT NULL pointer crash on early ethtool operations") Signed-off-by: Li Li --- Changes in v2: - Remove the line to nullify vport->q_vector_idxs as it is not necessary. drivers/net/ethernet/intel/idpf/idpf_lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c index 131a8121839bd..f63ab58428d2e 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -1308,6 +1308,7 @@ static struct idpf_vport *idpf_vport_alloc(struct idpf_adapter *adapter, free_rss_key: kfree(rss_data->rss_key); + rss_data->rss_key = NULL; free_vector_idxs: kfree(vport->q_vector_idxs); free_vport: -- 2.52.0.457.g6b5491de43-goog