From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04EE8CA6C92 for ; Tue, 27 Jan 2026 08:54:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A6AFA60F2E; Tue, 27 Jan 2026 08:54:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qdymRHE26EGB; Tue, 27 Jan 2026 08:54:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6474260F29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1769504071; bh=5Vu2GOUUTUkzQBR4MGj91wDX9S48NAbJAlRo+YnFDDU=; h=From:To:CC:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=OrFYjYxh+q9L6WGzOFIiH2RO+vFN4xWHp+OMLMjra2eWS5SYSKnZI+Hl2EpErEOMj 4T5lhUfCf/iNtLcHN+7PYbUC04tSRCsb4cOWqa0Kx/RCBUgQ3LyGgeKHwGrsR5OJlT wCSnZeCHHkP625NFfnmLBujIhWFGW5JES74WWrXHjuoKyU8r34oH67QoZ5kRm79Akd qT0MCxAfQe6T70nubCl1fbndB7Obo5PeEg20R4LJIqVIK9V6J3MgS5GUCZNuQNJ1H6 BCRmg6IDF1YNVsc+2tsjLFhMjYcnQ9qyBTeoKAErBG1HIG76U9ddkye6jWV146GQ6Y wCy2QjXpbsgog== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 6474260F29; Tue, 27 Jan 2026 08:54:31 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id BC54C2F4 for ; Tue, 27 Jan 2026 08:54:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AC2B980DE5 for ; Tue, 27 Jan 2026 08:54:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WMcDSK70WaCl for ; Tue, 27 Jan 2026 08:54:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=52.42.203.116; helo=pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com; envelope-from=prvs=4803e00d0=takkozu@amazon.co.jp; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8D0DE80DDB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8D0DE80DDB Received: from pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com [52.42.203.116]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8D0DE80DDB for ; Tue, 27 Jan 2026 08:54:27 +0000 (UTC) X-CSE-ConnectionGUID: PKJUmrdeS6mevJl3rA2FPA== X-CSE-MsgGUID: TajFWLVmQOCONlZAeeyy8A== X-IronPort-AV: E=Sophos;i="6.21,256,1763424000"; d="scan'208";a="11660345" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 08:54:24 +0000 Received: from EX19MTAUWC002.ant.amazon.com [205.251.233.51:26705] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.19.122:2525] with esmtp (Farcaster) id 8abc2707-6992-48fe-a36f-6b2eefa5c4a0; Tue, 27 Jan 2026 08:54:24 +0000 (UTC) X-Farcaster-Flow-ID: 8abc2707-6992-48fe-a36f-6b2eefa5c4a0 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Tue, 27 Jan 2026 08:54:23 +0000 Received: from 603e5f7bc1fe.amazon.com (10.37.245.7) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Tue, 27 Jan 2026 08:54:21 +0000 From: Takashi Kozu To: CC: , , , , , , , , , , , , Takashi Kozu Date: Tue, 27 Jan 2026 17:54:07 +0900 Message-ID: <20260127085410.79645-5-takkozu@amazon.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.37.245.7] X-ClientProxiedBy: EX19D037UWC004.ant.amazon.com (10.13.139.254) To EX19D001UWA001.ant.amazon.com (10.13.138.214) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1769504068; x=1801040068; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5Vu2GOUUTUkzQBR4MGj91wDX9S48NAbJAlRo+YnFDDU=; b=Hy03BS5BGpdELgCh9ImIpUQfIGoZih4n45VhRzFiF9lsy1ymsRu7BnCT cpqnCPWNpwphvlDlPszQTu8q7trLo76gyha4vXNmLBKBS6pOHgkLdVcob uNZBGFwNrMFqTBW/L2Ioq3gPMfrkK9AxsGD+8VL4G1tgWFG8ObcrSvu02 UnjUHhsapZFrEoYvm5UEn8Om1Skx8Qk3YoMmuHFuLiW9g+PJ2RgrJcW/Y JHsuc4Bl5zBAInWQdncnszDWQNgVnKdb8vsaSkjfRwtFVAzX6YH+gLAI8 6bXGo7myDTiYdLQHgdkqjRR3hC2c4pI/vhRk9tPhV/6EcWU6vJY2VgLjv Q==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=Hy03BS5B Subject: [Intel-wired-lan] [PATCH iwl-next v5 0/3] igb: add RSS key get/set support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This series adds ethtool get/set support for the RSS hash key in the igb driver. - `ethtool -x ` to display the RSS key - `ethtool -X hkey ` to configure the RSS key Without patch: # ethtool -x $DEV | grep key -A1 RSS hash key: Operation not supported # ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:00:00:00:000 Cannot set RX flow hash configuration: Hash key setting not supported With patch: # ethtool -x $DEV | grep key -A1 RSS hash key: 86:5d:11:56:bd:6f:20:38:3b:f8:bb:df:00:3a:b0:24:95:9f:f9:f4:25:a3:01:3e:4a:15:d6:7c:4d:af:39:7e:4a:95:f2:fd:f6:b6:26:f7 # ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00 # ethtool -x $DEV | grep key -A1 RSS hash key: 00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00 v5: - delete 'has_user_rss_key' flag because it's unnecessary. v4: - modify the position of the declaration in the igb_write_rss_key() so that it is at the start of the block. v3: - add ASSERT_RTNL() to explicitly show that an rtnl lock is being used - Move netdev_rss_key_fill() function from igb_setup_mrqc() to igb_sw_init() - Add kernel-doc header to igb_write_rss_key() - tools/testing/selftests/drivers/net/hw/rss_api.py is successful Run the following command # NETIF=enp0s3 python tools/testing/selftests/drivers/net/hw/rss_api.py | grep -v "# Exception" Then, I checked the diffs before and after applying the patch $ diff beforePatch.txt afterPatch.txt 9c9 < not ok 6 rss_api.test_rxfh_nl_set_key --- > ok 6 rss_api.test_rxfh_nl_set_key 16c16 < # Totals: pass:4 fail:8 xfail:0 xpass:0 skip:0 error:0 --- > # Totals: pass:5 fail:7 xfail:0 xpass:0 skip:0 error:0 The failing tests originally fails due to hardware. - tools/testing/selftests/drivers/net/hw/toeplitz.py is untested since there is no actual hardware, but since the logic around wr32() is preserved as it is, key writing to the device remain the same. v2: Fix typos (igc_* → igb_*) https://lore.kernel.org/intel-wired-lan/20260108052020.84218-5-takkozu@amazon.com/T/ v1: https://lore.kernel.org/all/20251205082106.4028-5-takkozu@amazon.com/ Takashi Kozu (3): igb: prepare for RSS key get/set support igb: expose RSS key via ethtool get_rxfh igb: allow configuring RSS key via ethtool set_rxfh drivers/net/ethernet/intel/igb/igb.h | 3 + drivers/net/ethernet/intel/igb/igb_ethtool.c | 85 ++++++++++++++------ drivers/net/ethernet/intel/igb/igb_main.c | 8 +- 3 files changed, 66 insertions(+), 30 deletions(-) -- 2.52.0