From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50B89D3567B for ; Wed, 28 Jan 2026 06:10:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0D5CA606FA; Wed, 28 Jan 2026 06:10:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id A9SVfkUycsTq; Wed, 28 Jan 2026 06:10:41 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 39AF060710 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1769580641; bh=w/u1fzObb/vQ4nIOqm+p737l4YnAfCnIUy3FBydAJtY=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kLnZlPbmStBmtreD275DZThzFY5kdz0TCFNL6vXjD1rko0Kp7DfnQbpLKIrda4Cph rUFG6xJPFybhjZjKuiYTDHU44YuKH/F2D5h0G/Nu0FblB9RSvp6r1VF98fzUfJobNy BsryENtF9cqYyyyhqzgdRQQ2r4s4Z38tB83wmHSFwTkqOX3zlxXqALtqKb/k02SGDG u032tL03S+yc73/pSsSl4R8EX9X1qOOhZpZzL+HKPZL8zNGKWQsTepr7xKxe+rUlnM Ja+SwA+17lRB7JreyLBUx/yftQInjZXYA2G6DbA9+jh8YuZ4EacMp23G27Hn+Dz0cw t17/sPDBWoLYQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 39AF060710; Wed, 28 Jan 2026 06:10:41 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id B9AFE1AD for ; Wed, 28 Jan 2026 06:10:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B558D60710 for ; Wed, 28 Jan 2026 06:10:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ivC4fclSxDRX for ; Wed, 28 Jan 2026 06:10:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91; helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 924C2606FA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 924C2606FA Received: from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91]) by smtp3.osuosl.org (Postfix) with ESMTPS id 924C2606FA for ; Wed, 28 Jan 2026 06:10:38 +0000 (UTC) Received: from ms-a2 (85.154.13.160.dy.iij4u.or.jp [160.13.154.85]) (authenticated bits=0) by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 60S69wpg032523 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 28 Jan 2026 15:09:59 +0900 (JST) (envelope-from kohei@enjuk.jp) From: Kohei Enju To: anthony.l.nguyen@intel.com Cc: aleksandr.loktionov@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, enjuk@amazon.com, intel-wired-lan@lists.osuosl.org, kohei@enjuk.jp, kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, piotr.kwapulinski@intel.com, pmenzel@molgen.mpg.de, przemyslaw.kitszel@intel.com, takkozu@amazon.com Date: Wed, 28 Jan 2026 06:09:44 +0000 Message-ID: <20260128060958.6333-1-kohei@enjuk.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: a=rsa-sha256; bh=w/u1fzObb/vQ4nIOqm+p737l4YnAfCnIUy3FBydAJtY=; c=relaxed/relaxed; d=enjuk.jp; h=From:To:Subject:Date:Message-ID; s=rs20251215; t=1769580600; v=1; b=JlEhujSeU7vtv0/+BGamrTo9zGKFrnl3aXcsdlrX/d9eM5EuSJ6vf0u6ktA2ZOa0 dKazCB6JrQocTwpIpRv53UE3OmnR4q2ows6LZRMj5OqNtEM5SlTEIdiP/p/gRJTC tCvYrh7FEAhjEfsIuMVrnmRS2VPAExRkXm6+P3L9kL+/+A3qGHif6kGlBW12F9Vd hwmxRC6nRaX1P89+LHPEsScRH2s6sZDKR0EDcvCTiwR3zRnNpg470z2Yl5aLLqSg 26HdxT8y7NgHu/Ae9K5Bb4sZ0oiC9qUUKsURmE6HDts1YshC2BstxtQxomUo1X16 gpYGebMa52jiyi0MWgfNpA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256 header.s=rs20251215 header.b=JlEhujSe Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 3/3] igb: allow configuring RSS key via X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 27 Jan 2026 14:33:24 -0800, Tony Nguyen wrote: > On 1/25/2026 5:12 AM, Kohei Enju wrote: > > On Tue, 20 Jan 2026 18:34:40 +0900, Takashi Kozu wrote: > > > >> Change igc_set_rxfh() to accept and save a userspace-provided > >> RSS key. When a key is provided, store it in the adapter and write the > >> E1000 registers accordingly. > >> > >> This can be tested using `ethtool -X hkey `. > >> > >> Signed-off-by: Takashi Kozu > >> --- > >> drivers/net/ethernet/intel/igb/igb.h | 1 + > >> drivers/net/ethernet/intel/igb/igb_ethtool.c | 49 +++++++++++--------- > >> drivers/net/ethernet/intel/igb/igb_main.c | 3 +- > >> 3 files changed, 30 insertions(+), 23 deletions(-) > >> > >> diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h > >> index 8c9b02058cec..2509ec30acf3 100644 > >> --- a/drivers/net/ethernet/intel/igb/igb.h > >> +++ b/drivers/net/ethernet/intel/igb/igb.h > >> @@ -657,6 +657,7 @@ struct igb_adapter { > >> u32 rss_indir_tbl_init; > >> u8 rss_indir_tbl[IGB_RETA_SIZE]; > >> u8 rss_key[IGB_RSS_KEY_SIZE]; > >> + bool has_user_rss_key; > > > > Hi Kozu-san. > > > > While preparing for testing, I noticed that now 'has_user_rss_key' is > > not necessary. > > > > Since netdev_rss_key_fill() is called in igb_sw_init() and igb_sw_init() > > is called only once for the adapter's lifetime, adapter->rss_key > > wouldn't be changed except for user-intended change. > > > > I'd drop that flag and related code (see below) > > Hi Kohei, > > I believe this igb implementation was based on your igc implementation > which also has the same. Would it be possible for you to update the igc > to do this as well? Yes, you're right. I'd love to do that and post as new version, so could you drop the series[1] from tnguy/next-queue.git? [1] https://lore.kernel.org/intel-wired-lan/20251025150136.47618-1-enjuk@amazon.com/ > > Thanks, > Tony