From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68DDED35687 for ; Wed, 28 Jan 2026 07:29:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EA69B404F2; Wed, 28 Jan 2026 07:29:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5GezJ4VKglbH; Wed, 28 Jan 2026 07:29:47 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1A6EA4043E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1769585387; bh=cPiwWLDvghmCGt9oewTVK5ZkSP/BPQjzSlyP0s5Xx/0=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AaaqV89VoCvjmjANGG75N68mNIAL1Tcbep/DYfqttsynyehxhvx2bc49hQQeDglrr rJXfGbT33UJBqujJdr1ANH8T0IuuMvuiErC2+VKwX5YDLsBMt6zvXY2YMx+VlfKHs2 CfOaj6X593s6HzD3IaRvI3EPsdszPvMrK9x9XoHDCUReI10pRlbdGwpsfzfj4mdf2Z nLS+1lyKAeWXYDwfZ0ll/vQJGRLDIRjDoTT0roJLVIgAHd8epl4EjjQauqowmukdiJ IDlSWlUirggx5ajTt7eFj1r29PZ+x6zYxfOPbAJ9WM7R2hzLKeiIzgrBCpeA2AJGgk mwrFdiTXwodPg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 1A6EA4043E; Wed, 28 Jan 2026 07:29:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 3A62B118 for ; Wed, 28 Jan 2026 07:29:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2938F40245 for ; Wed, 28 Jan 2026 07:29:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id I12VH_Y7cQd8 for ; Wed, 28 Jan 2026 07:29:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91; helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 05C6F40024 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 05C6F40024 Received: from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91]) by smtp2.osuosl.org (Postfix) with ESMTPS id 05C6F40024 for ; Wed, 28 Jan 2026 07:29:43 +0000 (UTC) Received: from ms-a2 (85.154.13.160.dy.iij4u.or.jp [160.13.154.85]) (authenticated bits=0) by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 60S7TDIC049913 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 28 Jan 2026 16:29:14 +0900 (JST) (envelope-from kohei@enjuk.jp) From: Kohei Enju To: takkozu@amazon.com Cc: aleksandr.loktionov@intel.com, andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, enjuk@amazon.com, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, piotr.kwapulinski@intel.com, pmenzel@molgen.mpg.de, przemyslaw.kitszel@intel.com, Kohei Enju Date: Wed, 28 Jan 2026 07:27:36 +0000 Message-ID: <20260128072908.50245-1-kohei@enjuk.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260127085410.79645-8-takkozu@amazon.com> References: <20260127085410.79645-8-takkozu@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: a=rsa-sha256; bh=cPiwWLDvghmCGt9oewTVK5ZkSP/BPQjzSlyP0s5Xx/0=; c=relaxed/relaxed; d=enjuk.jp; h=From:To:Subject:Date:Message-ID; s=rs20251215; t=1769585355; v=1; b=Ao6pv7wipYUxJGx2OOpfIlSMY6dOYa2Mna0t4f39SGgg7HJ5ip+6Xbxl5i0NIIxV v/3iGuW3XEC0GIwalC9Ng9BKaKRbPcpK4acRKah4OLAvtP9v/6tSy/dHLPxykUKu S2p00kY5ZG5wGsF+3zgIyikIiJkB7q6eVLX6Qcn131L4le6jq/knG2j2tHYSgI78 xUVdzgMkYxeaDNdBcbw/bSCcxRgQliXfqx52l6WGaspMnSnTaRojD7CGM/3PeUHO 7forZjVeBhBinQEv1c5YK2pTlf9EiXgX/VowSc/FRtnyXlyn+mWOKK5o0NzlR+UO Qe/s2uVs6qDxdQ8LggW7WQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256 header.s=rs20251215 header.b=Ao6pv7wi Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 3/3] igb: allow configuring RSS key via ethtool set_rxfh X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 27 Jan 2026 17:54:10 +0900, Takashi Kozu wrote: > Change igc_set_rxfh() to accept and save a userspace-provided > RSS key. When a key is provided, store it in the adapter and write the > E1000 registers accordingly. > > This can be tested using `ethtool -X hkey `. > > Signed-off-by: Takashi Kozu Tested with Intel Corporation I350 Gigabit Network Connection and confirmed that toeplitz.py and test_rxfh_nl_set_key in rss_api.py succeeded. # tools/testing/selftests/drivers/net/hw/toeplitz.py | grep -E "^# Totals" # Totals: pass:12 fail:0 xfail:0 xpass:0 skip:0 error:0 # tools/testing/selftests/drivers/net/hw/rss_api.py | grep test_rxfh_nl_set_key ok 6 rss_api.test_rxfh_nl_set_key Also checked that RSS hash key remains through admin down & up. # ethtool -X $DEV hkey be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef # ethtool -x $DEV | grep key -A 1 RSS hash key: be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef # ip link set dev $DEV down && ip link set dev $DEV up # ethtool -x $DEV | grep key -A 1 RSS hash key: be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef Tested-by: Kohei Enju Note: Toeplitz test needs correct handling of setting skb->hash and its rss type, so I applied the patch below in advance. https://lore.kernel.org/intel-wired-lan/20260122134809.7765-1-kohei@enjuk.jp/