From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29F73ECD6EF for ; Wed, 11 Feb 2026 21:44:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A4F8280ED0; Wed, 11 Feb 2026 21:44:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id hV4M9AkQ1-GD; Wed, 11 Feb 2026 21:44:41 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ED40780E30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1770846281; bh=0SB1V5cbKvQThjGpuL7/nwOkzWegMaE07DHmasP4E2k=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w3H4CNI0nq0Qgvswi9wSAUNlS4KXzM5kNjbkGXrY6edTCUnjZpsQXWSPXR9wgtmuf gojTDJ6zZp77rnw4/fW2P0/vngzz5nbOuJJyZf6B7JJvShsjkb0hqd23MYrPfm6rj6 1ZaOZb6Ces59qLVzMGiqOjQsh0Wc7DtHiujqnJ/2DG6vkrD8lYfjG/SdAg6+1HVyC6 +A0N4CY8wVG2jN31PGF+vjDd4mo+c8FmjVvjTdl3xMuX/KArQxCotOk6PpyahCTWBP R+DscGTAXJ/NfBz/ZKlbCcQAlX1qu6u9qIapidD8C5+DLW3b1oQ+ccsAPgPTZ2bWhH 62AvBVEE1xpQw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id ED40780E30; Wed, 11 Feb 2026 21:44:40 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 90169BE for ; Wed, 11 Feb 2026 21:44:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8A7B241B7E for ; Wed, 11 Feb 2026 21:44:40 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Xubf3GbaS1iQ for ; Wed, 11 Feb 2026 21:44:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org C373740D3C DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C373740D3C Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id C373740D3C for ; Wed, 11 Feb 2026 21:44:39 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 1055B60051; Wed, 11 Feb 2026 21:44:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB18FC19421; Wed, 11 Feb 2026 21:44:36 +0000 (UTC) Date: Wed, 11 Feb 2026 13:44:36 -0800 From: Jakub Kicinski To: Jacob Keller Cc: Kurt Kanzenbach , Willem de Bruijn , Sebastian Andrzej Siewior , Vadim Fedorenko , Willem de Bruijn , Paolo Abeni , Eric Dumazet , "David S. Miller" , "Loktionov, Aleksandr" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Paul Menzel , "Gomes, Vinicius" , "netdev@vger.kernel.org" , Richard Cochran , "linux-kernel@vger.kernel.org" , Andrew Lunn , "intel-wired-lan@lists.osuosl.org" Message-ID: <20260211134436.1e623034@kernel.org> In-Reply-To: <12520aac-c69a-41a0-9710-497392bc18f6@intel.com> References: <20260205164341.pJvni8kA@linutronix.de> <76acd5cc-eb6f-4c56-a5e6-f6413736afbb@linux.dev> <601f0c4b-52d8-4b60-96bf-f2d65f8073d8@linux.dev> <20260209090621.GiZqTiMJ@linutronix.de> <8e762437-69f9-40d7-bb75-3a45bef1d5d6@linux.dev> <20260209114836.GPU-vnnh@linutronix.de> <78e2af2c-40e6-43f1-9471-42f350e69389@linux.dev> <20260210121207.9kLHroS0@linutronix.de> <87qzqr5vos.fsf@jax.kurt.home> <12520aac-c69a-41a0-9710-497392bc18f6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770846277; bh=JMqKerywpg1i4AsO2BcZY243d6hFyXTrcC68qtQaPsc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rqy0CijPHsw3y/Ope8+judGHByxaXC8M8eCsqUvyAwVaY8G8hcKL8i7lxABnmsgyW rzP6NxnvrtFWXxnfPxrH4/rI1SV0cHbwI8mvyHIwcfGWp8jifwWU/1O6cnO1KaHe4a WdoHCvXj+CK1aN9hiQUiQLgbcBNAPmzjkoT5Kv0rvAyOgyEpwuJQsZUSopsnlrXhWq xTm9XL9IzVeieAgUwO6946WgaXTzcwSvghm1LcQXiOEWsUM9HtsdO5ggko5wzgSWGh BkPIjH+vyRWSI4p9BeEwZyn/IdShqVw4aNO8ROUt71yyfwEInStAMYB5acYN1ixx39 wEBbCcn9FgA4A== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=rqy0CijP Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] igb: Retrieve Tx timestamp directly from interrupt for i210 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 11 Feb 2026 11:29:03 -0800 Jacob Keller wrote: > > Moving the timestamping in IRQ looked like a good solution, because the > > device already signals that the Tx timestamp is available now. No need > > to schedule any worker/work at all. So, it'd be very nice if > > skb_tstamp_tx() could be called from IRQ context. BTW other drivers like > > igc call this function in IRQ context as well. > > Right. Reporting the timestamp from the interrupt is the simplest and > lowest latency method. I know Miroslav had some situations and devices > where it apparently caused more problems than it helped, though I don't > believe anyone else has reproduced those? There's a BH workqueue now, as a replacement for tasklets. Presumably smallest fix would be to switch to that?