From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FFC5EE3698 for ; Thu, 12 Feb 2026 16:47:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CAE8D842C2; Thu, 12 Feb 2026 16:47:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Gq6rQTLCRZmC; Thu, 12 Feb 2026 16:47:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 127B1842B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1770914854; bh=s/DyEPe+77NoYsDIGpxy2seHogqaqunQv6TIiFOPDzI=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yR5cZ2AXL64G6Jee2ipWQJkjdrlwkGilRKMNb0Cgcp6rmJFQGB+lFTYiCPChJIFh1 TUsdakPe1GKnbMUbNac46ZpmH2Q31nE5d3idM1saTjaWwxOu6oEs1VbmQisxBB4VV/ Do2nLO/Icszn0rJLzOSnfAY33h7+DrCopHqWOQ4CLllBR7JIFCHSEPVlt8nlaYR3/l nC/dhfHOQv5UeHJWN6Am9UDZE37moc3j8kO9OnwO4bcKolR9HFxNVMYW0ZQ7DetWKV e8HW7ax0t9FWi9oNGNyxWkOSxjytNmxdKl9Xat2zBx94YX5+Gl4vPDwk6+aDwXoGWB cLc/B38j3SG/g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 127B1842B8; Thu, 12 Feb 2026 16:47:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id B355F23D for ; Thu, 12 Feb 2026 16:47:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 948BC842BA for ; Thu, 12 Feb 2026 16:47:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gUEu9CeeMshf for ; Thu, 12 Feb 2026 16:47:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=bigeasy@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org AAE5F842B8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AAE5F842B8 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id AAE5F842B8 for ; Thu, 12 Feb 2026 16:47:30 +0000 (UTC) Date: Thu, 12 Feb 2026 17:47:25 +0100 From: Sebastian Andrzej Siewior To: Jakub Kicinski Cc: Jacob Keller , Kurt Kanzenbach , Willem de Bruijn , Vadim Fedorenko , Willem de Bruijn , Paolo Abeni , Eric Dumazet , "David S. Miller" , "Loktionov, Aleksandr" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Paul Menzel , "Gomes, Vinicius" , "netdev@vger.kernel.org" , Richard Cochran , "linux-kernel@vger.kernel.org" , Andrew Lunn , "intel-wired-lan@lists.osuosl.org" Message-ID: <20260212164725.ltllw51l@linutronix.de> References: <20260209090621.GiZqTiMJ@linutronix.de> <8e762437-69f9-40d7-bb75-3a45bef1d5d6@linux.dev> <20260209114836.GPU-vnnh@linutronix.de> <78e2af2c-40e6-43f1-9471-42f350e69389@linux.dev> <20260210121207.9kLHroS0@linutronix.de> <87qzqr5vos.fsf@jax.kurt.home> <12520aac-c69a-41a0-9710-497392bc18f6@intel.com> <20260211134436.1e623034@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260211134436.1e623034@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1770914846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s/DyEPe+77NoYsDIGpxy2seHogqaqunQv6TIiFOPDzI=; b=N+K6lj3wl0VbioEZ2q8gSVvJkdOh63504F2+D57irJaU2pWVpxcMDwW9us2dAeOCkB/87C +QBuXkmNV+2uv2l5Rv6bomcRt4GBEOzbGtYteuiWnLRR3fLUbPgh1g1mHzovFydc/yjjds 9cPwYvdaVH8N7HpjkDlUQYYqs87NCmNd3vtohZSP0bkHKFo7bd0f7Iy4hwigfKarWD2LJY x+N/LBXH9JCfQHOV9/+6NjeFbfX+RZHl8VXpVRq/0He245+/CjNjude04vIqPCIjJnbMUI E0Z/y55krglNbf8fu8b+K/KNn2E2EACfL1AecxGuyPmjUed+yYkmWdEE5hanGw== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1770914846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s/DyEPe+77NoYsDIGpxy2seHogqaqunQv6TIiFOPDzI=; b=btvf8tItfDYAqnNr2fTa3aIBM0VfbBgRuxc5XlsgCD+E/96PiUpsz5xehfp5OiFe9pqUAc nsEH/9rOuy4fCGBQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=N+K6lj3w; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=btvf8tIt Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] igb: Retrieve Tx timestamp directly from interrupt for i210 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2026-02-11 13:44:36 [-0800], Jakub Kicinski wrote: > On Wed, 11 Feb 2026 11:29:03 -0800 Jacob Keller wrote: > > > Moving the timestamping in IRQ looked like a good solution, because t= he > > > device already signals that the Tx timestamp is available now. No need > > > to schedule any worker/work at all. So, it'd be very nice if > > > skb_tstamp_tx() could be called from IRQ context. BTW other drivers l= ike > > > igc call this function in IRQ context as well. > >=20 > > Right. Reporting the timestamp from the interrupt is the simplest and= =20 > > lowest latency method. I know Miroslav had some situations and devices= =20 > > where it apparently caused more problems than it helped, though I don't= =20 > > believe anyone else has reproduced those? >=20 > There's a BH workqueue now, as a replacement for tasklets. > Presumably smallest fix would be to switch to that? Hmm. This would raise the TASKLET softirq from the interrupt handler and then handle it on the irq-exit path.=20 Let me look if that one lock can be removed first=E2=80=A6 Sebastian