From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C566AE9B250 for ; Tue, 24 Feb 2026 11:10:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7B3B041BFF; Tue, 24 Feb 2026 11:10:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id I7Ru2MNTsctK; Tue, 24 Feb 2026 11:10:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4B59A41BF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1771931453; bh=IWOtAtRk99BDMMRXlOw9HFRfBcWZLiVREWuDyF92Tq0=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wD2AZqewMpaZIDo726hDavHN/axgFUOrgHb9ejRdieTpAjj+WPgTUPTVkf8RDbJ+H cSed/s+28PKRlycWa1MclqGbEFv7CiFIv8kJ4M/Woh8+2rnc6n7FGGqhD8RLv3hkHo 7pMHCeWGRzwUtv2xcftZAUdGzHXWBIMzepZBKfyQUUM6Q7uPTU2upbWbPj6VI/SN5B 3VV/iz2EATrGd4G+TcNyfRyYCU7qaDTyH3Rc5yh/9+/XKJ2wjVQnmjPaAoWV3YGjjs KfkKr51VEGDE99mvHpgM1n3fH19nSDa/AoiimMwjOr0/sfJT5D3LLrrtnCGKI40Px/ FCdnlVfeMo3mA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 4B59A41BF5; Tue, 24 Feb 2026 11:10:53 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 6A140237 for ; Tue, 24 Feb 2026 11:10:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 502BF41BF8 for ; Tue, 24 Feb 2026 11:10:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UHCe_DhyWvPV for ; Tue, 24 Feb 2026 11:10:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.19; helo=mgamail.intel.com; envelope-from=mika.westerberg@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7B18F41BEC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7B18F41BEC Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7B18F41BEC for ; Tue, 24 Feb 2026 11:10:51 +0000 (UTC) X-CSE-ConnectionGUID: Lc18+Lf8QbOuq4qr8zWNbQ== X-CSE-MsgGUID: LUZgTVcmQ4SKP25/VOeBZw== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="71974261" X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="71974261" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 03:10:51 -0800 X-CSE-ConnectionGUID: yNqYtachR4mFbLJVV8acEg== X-CSE-MsgGUID: GbPWuUYeR2aUblceRzNGPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="216037798" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa007.jf.intel.com with ESMTP; 24 Feb 2026 03:10:46 -0800 Received: by black.igk.intel.com (Postfix, from userid 1001) id 1E6039B; Tue, 24 Feb 2026 12:10:44 +0100 (CET) From: Mika Westerberg To: linux-pci@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org, Bjorn Helgaas , Lukas Wunner , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Richard Cochran , Andy Shevchenko , Vitaly Lifshits , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Vinicius Costa Gomes , Dima Ruinskiy , Mika Westerberg Date: Tue, 24 Feb 2026 12:10:41 +0100 Message-ID: <20260224111044.3487873-3-mika.westerberg@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260224111044.3487873-1-mika.westerberg@linux.intel.com> References: <20260224111044.3487873-1-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771931451; x=1803467451; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R+QtiOPuFfp3S5QbZO4NvSZNp52rBIcTtfnP5DXv4+Q=; b=OlnVn07P1lScmkJq9DyX+aTSYfVQECRa7qC7ySuaSfjlis7qxGUy9+VI qUDUzg8RNpfC+qAbL35UbKYY5U3qXNCMn7Zn/V3frBviH0QlzYvRSPawf b1/zzranHuk3Hl6sUlidzA8Xju+NH/XPTYpGcccA0sDjYz0TM8RenzrZy IFmzn8zbNDaLRuDWS1rxzpPJsFtlYptXrXYONpiK5duIQ5F/kpH6PhAyf UnYdAN1mIw+xIg1t7dt/8g7JCdLQGhRLH+4PxtyNPW5r1AawsQgDargbP YLB5K+wMq4wtfK7U4jckBNOqk23vdktByqLd4rzapb0tQUnpIUYfv24IH Q==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OlnVn07P Subject: [Intel-wired-lan] [PATCH 2/5] igc: Let the PCI core deal with the PM resume flow X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Currently igc driver calls pci_set_power_state() and pci_restore_state() and the like to bring the device back from low power states. However, PCI core handles all this on behalf of the driver. Furthermore with PTM enabled the PCI core re-enables it on resume but the driver calls pci_restore_state() which ends up disabling it again. For this reason let the PCI core handle the common PM resume flow. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko --- drivers/net/ethernet/intel/igc/igc_main.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 7ffd34bfa14e..99a4c99ddd57 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -7526,9 +7526,6 @@ static int __igc_resume(struct device *dev) struct igc_hw *hw = &adapter->hw; u32 err, val; - pci_set_power_state(pdev, PCI_D0); - pci_restore_state(pdev); - if (!pci_device_is_present(pdev)) return -ENODEV; err = pci_enable_device_mem(pdev); @@ -7538,9 +7535,6 @@ static int __igc_resume(struct device *dev) } pci_set_master(pdev); - pci_enable_wake(pdev, PCI_D3hot, 0); - pci_enable_wake(pdev, PCI_D3cold, 0); - if (igc_is_device_id_i226(hw)) pci_disable_link_state(pdev, PCIE_LINK_STATE_L1_2); -- 2.50.1