From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 413ADFD374E for ; Wed, 25 Feb 2026 12:26:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DFCC683D19; Wed, 25 Feb 2026 12:26:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id YMEM3Un8WE0K; Wed, 25 Feb 2026 12:26:29 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1E73883C1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1772022389; bh=jWN+p2jwMSDPyhfCDv6HTqbYFmXkXPJpRii7YBn2gyo=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=6W36qOXJEIQ7ejAHY8JdVcy9fgIZRRzwA+OJ/P16mRZ3+kX6HvVujwM7ot7907YFf 0/9nU0Y4RJE/VSFJ95mddESM2tkhOI+5Ns1/O5Sqe3V6V8+lSFPM46Ee3P3BtpeHTj YIEo2Q0y8SKdpGFuE++tHi6LQ+USLVraQs8t0F7NTg58Lno2rsdATuZ8aUYQsKZ7Fa zi5wiOAVvvvQi92ymvi5Cm1rYMWC563CS4NMqsVtzjMIhCg5jdItoiRwItCbFefy90 fVvv5adSetcxtpcU/Idpxcq5xLkFQn8bWfaVCeaId/lX4ftsDEXz4lybHQBtMaqTrx VYLZzT0BFrv+w== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 1E73883C1A; Wed, 25 Feb 2026 12:26:29 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 4C8E5204 for ; Wed, 25 Feb 2026 12:26:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3E3594055D for ; Wed, 25 Feb 2026 12:26:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vPttlt40O_Fl for ; Wed, 25 Feb 2026 12:26:26 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.19; helo=mgamail.intel.com; envelope-from=mika.westerberg@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 3B7C74053E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3B7C74053E Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3B7C74053E for ; Wed, 25 Feb 2026 12:26:26 +0000 (UTC) X-CSE-ConnectionGUID: 6UIzwu27SomOBPnw65Cerw== X-CSE-MsgGUID: I9EoaELRSraWN2SkCYhMxg== X-IronPort-AV: E=McAfee;i="6800,10657,11711"; a="72960265" X-IronPort-AV: E=Sophos;i="6.21,310,1763452800"; d="scan'208";a="72960265" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 04:26:25 -0800 X-CSE-ConnectionGUID: 4JnDYL7fSCuRBpUEBA/K1A== X-CSE-MsgGUID: j1D/6tAuQf6vtC8ZewI+jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,310,1763452800"; d="scan'208";a="215322332" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa006.jf.intel.com with ESMTP; 25 Feb 2026 04:26:21 -0800 Received: by black.igk.intel.com (Postfix, from userid 1001) id 4722798; Wed, 25 Feb 2026 13:26:19 +0100 (CET) Date: Wed, 25 Feb 2026 13:26:19 +0100 From: Mika Westerberg To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Bjorn Helgaas , Lukas Wunner , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Richard Cochran , Andy Shevchenko , Vitaly Lifshits , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Vinicius Costa Gomes , Dima Ruinskiy Message-ID: <20260225122619.GA2275908@black.igk.intel.com> References: <20260224111044.3487873-3-mika.westerberg@linux.intel.com> <20260224165837.GA3736201@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260224165837.GA3736201@bhelgaas> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772022386; x=1803558386; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tw+WAcM1/3PbQ8VvUf+VpkKBf4FUQLx9zMT8Bchf+AU=; b=YrY5aav+Ry6oGIUX64u7OVfKi1pUkev6aSYVFNnu+el69PkjOWvJG8G/ YW80/6E+vILg44qMxiG6FwWYXP9d2ogdqtNefDAHANo9ukLFFXx9rpMHT ekqGl7YP+bh/DhLlQsyDT78X08wQcEal3eFAKUcILMIAZE2GpHKcmP4by SXo0/cu+kU+3m+DW+Xx5Cj7QgjpDLywNXA/nwF63gaiLJ26se7C7e//dX +yMtzvf2rIqpc5a08/ske6+reFR0XvtAT7m4xDCnEawNpo4T+U44lFXTu 402h005IGd1tWjvOXGJ9gKhUh50s2JpxBOhUoEszfaQfE44toucA+u41S A==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=YrY5aav+ Subject: Re: [Intel-wired-lan] [PATCH 2/5] igc: Let the PCI core deal with the PM resume flow X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Feb 24, 2026 at 10:58:37AM -0600, Bjorn Helgaas wrote: > On Tue, Feb 24, 2026 at 12:10:41PM +0100, Mika Westerberg wrote: > > Currently igc driver calls pci_set_power_state() and pci_restore_state() > > and the like to bring the device back from low power states. However, > > PCI core handles all this on behalf of the driver. Furthermore with PTM > > enabled the PCI core re-enables it on resume but the driver calls > > pci_restore_state() which ends up disabling it again. > > > > For this reason let the PCI core handle the common PM resume flow. > > > > Signed-off-by: Mika Westerberg > > Reviewed-by: Andy Shevchenko > > I love it, thanks a lot for doing this! > > Do we still need the pci_enable_device_mem() and pci_set_master() > in __igc_resume()? > > I suppose some of that is related to the pci_disable_device() in the > suspend path (__igc_shutdown()), but there are only a few dozen > drivers that do this, so I'm not sure it's essential. I think they are just as you describe due the fact there are explicit pci_disable_device() calls. Probably we can get rid of them as well but that requires careful testing that nothing accidentally breaks. @Vitaly, what do you think? I can take a look.