From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3D39EB1054 for ; Tue, 10 Mar 2026 14:31:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 929FC41BFC; Tue, 10 Mar 2026 14:31:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Oqfj9ax78wKN; Tue, 10 Mar 2026 14:31:24 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C7C6F41BF0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1773153084; bh=4/p8AtxdJ3b4aYgpRIBgOOPVM9R5HZLzlaxPPsEZ2Q4=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YtmgFUXTAJDmWetamgFl0i5nD382mbOsxEfxuo6VQQMaBHVX4G1rfeZCZR/mqNjs0 FrH0QB5e8SwOS0wdS7K7PRqhAt98x0fbSMr6vwX9gIl5gWML52M7/Hw7HYajlmNdcf k53GLkCKAyp/puRUyyUA/KTKFaTels6YRqQPZvogAZarYkMJbJibM/vxhzHRlyMjtz 7DWhHIvpTJhgOwrJcPg5nNftnZUeovbwTdRq7eVQxSXVvTUdsT3fJfV65hXwQY1QDX WUMkEbNElLz33wx67p8AutjYYYKuEWxVLlad0F+3owptFppFUEOl4zTU/IJb7UW78l V1bQNCJImlrJA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id C7C6F41BF0; Tue, 10 Mar 2026 14:31:24 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id F3DD135C for ; Tue, 10 Mar 2026 14:31:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F15F341BF0 for ; Tue, 10 Mar 2026 14:31:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TknS_L5Ar6-1 for ; Tue, 10 Mar 2026 14:31:23 +0000 (UTC) X-Greylist: delayed 345 seconds by postgrey-1.37 at util1.osuosl.org; Tue, 10 Mar 2026 14:31:22 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org EC9D440C2E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EC9D440C2E Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=18.9.28.11; helo=outgoing.mit.edu; envelope-from=tytso@mit.edu; receiver= Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by smtp4.osuosl.org (Postfix) with ESMTPS id EC9D440C2E for ; Tue, 10 Mar 2026 14:31:22 +0000 (UTC) Received: from macsyma.thunk.org (pool-173-48-117-133.bstnma.fios.verizon.net [173.48.117.133]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 62AENmJI023255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Mar 2026 10:23:49 -0400 Received: by macsyma.thunk.org (Postfix, from userid 15806) id 96A8A5C4FCED; Tue, 10 Mar 2026 10:23:48 -0400 (EDT) Date: Tue, 10 Mar 2026 10:23:48 -0400 From: "Theodore Tso" To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Julia Lawall , Nicolas Palix , Chris Mason , David Sterba , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Andreas Dilger , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Miklos Szeredi , Konstantin Komarov , Andreas Gruenbacher , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Jan Kara , Phillip Lougher , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Tejun Heo , David Vernet , Andrea Righi , Changwoo Min , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Max Filippov , Paolo Bonzini , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Jamal Hadi Salim , Jiri Pirko , Marcelo Ricardo Leitner , Xin Long , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Jon Maloy , Johannes Berg , Catalin Marinas , Russell King , John Crispin , Thomas Bogendoerfer , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Igor Russkikh , Andrew Lunn , Pavan Chebbi , Michael Chan , Potnuri Bharat Teja , Tony Nguyen , Przemek Kitszel , Taras Chornyi , Maxime Coquelin , Alexandre Torgue , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Heiner Kallweit , Marc Zyngier , Thomas Gleixner , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vinod Koul , Linus Walleij , Ulf Hansson , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Martin K. Petersen" , Eduardo Valentin , Keerthy , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alex Williamson , Mark Greer , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Shuah Khan , Kieran Bingham , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Lee Jones , Pavel Machek , Dave Penkler , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Justin Sanders , Jens Axboe , Georgi Djakov , Michael Turquette , Stephen Boyd , Philipp Zabel , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pali =?iso-8859-1?Q?Roh=E1r?= , Dmitry Torokhov Message-ID: <20260310142348.GA41218@macsyma-wired.lan> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1773152639; bh=4/p8AtxdJ3b4aYgpRIBgOOPVM9R5HZLzlaxPPsEZ2Q4=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=LBScO8Ewh5j+pvClPuvYJ6dYWu+6WL2ev3A6duJrcxObwFWjC8dgbq1R1jaNAuzD8 1N3QSZ+599jgS5LWqKIvONI9n0DrlV/bhIgTucL1f31tVRWGphyQLoG1P9ldyU2xAy 5HxclsvbqfBvFTqtCNAuPlMheXwVOKZyEuJ33r0JlgL4HScNylkzQj16H9ciOlXPZw GOi/SKdKtyjuJFISqW7lcvm87iESFGZLsNPOvP7dH6Va+zkOTwCBsrnPVNMrNF7MaI VGM4um3yd0mf+GQ4rfSGAnefCT4XC/KXug28EdqxTBjdSY5IyF4VkjDB0JxugqwdwX rwveeKEi+qz0Q== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=mit.edu X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.a=rsa-sha256 header.s=outgoing header.b=LBScO8Ew Subject: Re: [Intel-wired-lan] [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Mar 10, 2026 at 12:48:26PM +0100, Philipp Hahn wrote: > While doing some static code analysis I stumbled over a common pattern, > where IS_ERR() is combined with a NULL check. For that there is > IS_ERR_OR_NULL(). > > I've written a Coccinelle patch to find and patch those instances. > The patches follow grouped by subsystem. I'm going to gently suggest that you *not* try to do this as a tree-wide change, since we don't need to change some interface requiring a global, flag day change. This is instead a cleanup, which maybe makes the code slightly better, but which also has a the downside of breaking lots of inflight development patches by potentially causing merge or patch conflicts. So why don't you send it to each subsystem as a separate patch or small patch series, instead of spamming a dozen-plus mailing lists, are probably hundreds of developers, most of whom aren't going to care about changs in some far flung part of the kernel? Regards, - Ted