From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99361FD88D3 for ; Wed, 11 Mar 2026 00:09:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3730740860; Wed, 11 Mar 2026 00:09:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xXm4iUWa9h2z; Wed, 11 Mar 2026 00:09:40 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 67A23407FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1773187780; bh=w831jCp2lEinpGyIAtgZOZkL+Nb730nx7r4AR6nRVwk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ewj+BrBVIa9oXUR9gbZMCP1RqGkvYAZjih2c942kx5kXlB6wlrIbE/QkVDiwZxfb/ gMtSwAveuQHUPnMb9bGWl3dXribStelXyPQGyRA1PrNU6C8atgzR7PZ9dQYYZh8xd7 HgU4w+u79IuxvRCwWnYTPldST2xDnDEVo88TLROS0IWy/G3x9AY8U3aQhyQEkeWrDN tz/jtVuykH4M7LA7am6DECJt45WDLDf/xVKmdRyJjDHp73Nstbai2UGnqti7uzqSQQ qIQNo6wEyxpQyb+Q7lMVNokr5v259JXQZI2eDOr8Lkv5aNxRe1OOni1wuh/mRfqLQI UXsJdv4VFUWPg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 67A23407FC; Wed, 11 Mar 2026 00:09:40 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 1792933A for ; Wed, 11 Mar 2026 00:09:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F1A10407FC for ; Wed, 11 Mar 2026 00:09:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DEWqKyhNBpoS for ; Wed, 11 Mar 2026 00:09:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 60311407D1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 60311407D1 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp4.osuosl.org (Postfix) with ESMTPS id 60311407D1 for ; Wed, 11 Mar 2026 00:09:38 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 86DB6408A5; Wed, 11 Mar 2026 00:09:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29183C19423; Wed, 11 Mar 2026 00:09:37 +0000 (UTC) Date: Tue, 10 Mar 2026 17:09:36 -0700 From: Jakub Kicinski To: Jakub Ramaseuski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, przemyslaw.korba@intel.com Message-ID: <20260310170936.07d429b1@kernel.org> In-Reply-To: <20260310115556.1004263-1-jramaseu@redhat.com> References: <20260310115556.1004263-1-jramaseu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773187777; bh=G+EASqo5sUpecmd/NHO5XZFZ8PZbl576yUz1wTKeVIk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BxUBogDEud91vrfh78nE6b4Psf0sX8c+IxSKV5cvZjPiQq+lV7C8uTr3X4/SPlL/r AstzdooFZue0vECnrRMKFBC+owKjeOlmDTGjZYeBz33tkCK4RF6okZlwT727EN2nKe PKqDT7Kq5K9MZE159ubgG4Vl0jYdSZhk7TbNb9xw+QV/iHOkJV3/pVGSgOeh8lQo/i B6OI2e6azFmokt22bveYZbK3BtOZM58l4PHgI2uyFaOZkW7nd7lvOoaSwy/ogUdpbE Lt27el5LLlGc3PHmsdal92LE0/tcdoPL7Z5wGE5OrQ5/7u6diSOs49Mq47xFCMDLhv 6qLwGYh/+Dqhg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BxUBogDE Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: enable NETIF_F_HW_CSUM for GSO packets X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 10 Mar 2026 12:55:56 +0100 Jakub Ramaseuski wrote: > IPv4 over IPv6 GRE currently fails on E810 with skb_warn_bad_offload, > while IPv6 over IPv6 GRE falls back to software segmentation. > This happens because the kernel's GSO engine requires the generic HW_CSUM > flag to trust the hardware with complex encapsulation offloads. > > Add NETIF_F_HW_CSUM to the device's csumo_features to satisfy the network > stack and unlock full hardware segmentation for GRE tunnels. > To prevent checksum corruption on standard traffic, evaluate the packet > in ice_features_check() and dynamically clear the NETIF_F_HW_CSUM bit > if it is not a GSO frame. This forces the driver to fall back to safe, > protocol-specific checksum features for non-GSO packets > while preserving the generic offload for tunnels. If you're CCing netdev on iwl submissions you have to follow the 24h min reposting period. -- pv-bot: 24h