From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCA59F30282 for ; Sun, 15 Mar 2026 20:01:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9169740995; Sun, 15 Mar 2026 20:01:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KdmqAJMzNk4T; Sun, 15 Mar 2026 20:01:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EA0C1408A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1773604915; bh=03dIZEuf3IMigPuXNXr6U1nIEU52V05F0xQlKItD48k=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=G3VooLvbXsKPX2UaONncajx13HjUxgK4vznk4lWfsOFsrVURDTcEPtTu2FrEkAulq AcR4b6ggx0EF6/B5a1r6boulRb0+sOfuUWxwPaAcx6GXCSAD7VWcPM9hQdORz2vkIH BuC9EootSRaciYYXHw0t6/efNDn7bRPQPTe/roF5T+DeRV2blYx3IZ4SLGN5tBvUOL Qq+qLjfpN/ogmW+6ooO27ilfTBO0o0n0FaqF1rGarOI4ETszQmQAqAaLXFxeywgiRw wRM6YTwCauJ5zbvhLbJgElVPnpwnPX5p5R018d4MHCTBBQqrl8jKVT5mFnf8r/uRAK ZnxXqO3I0LRGQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id EA0C1408A5; Sun, 15 Mar 2026 20:01:54 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id D5DA11B2 for ; Sun, 15 Mar 2026 20:01:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C7A564075D for ; Sun, 15 Mar 2026 20:01:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 1valiRQxmZ-n for ; Sun, 15 Mar 2026 20:01:52 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3C173405B0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3C173405B0 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3C173405B0 for ; Sun, 15 Mar 2026 20:01:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 641DB4403C; Sun, 15 Mar 2026 20:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C55CC4CEF7; Sun, 15 Mar 2026 20:01:51 +0000 (UTC) Date: Sun, 15 Mar 2026 13:01:50 -0700 From: Jakub Kicinski To: intel-wired-lan@lists.osuosl.org, michal.swiatkowski@linux.intel.com Cc: "Kitszel, Przemyslaw" , jacob.e.keller@intel.com, anthony.l.nguyen@intel.com Message-ID: <20260315130150.12829f88@kernel.org> In-Reply-To: <20260315125451.3741843c@kernel.org> References: <20260315125451.3741843c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773604911; bh=RCgHiY7jVjrvekH8ESAe1BxUdVhTVpI6uzVWbL430zU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jRuQkWJh382nPBstVDUrEqZp5NUH6enPNGgGPfakoJAc8Kesv7WahD8NFgYMYwIaq WHfSDHVZinp+cRXUqfmljQhwDvvtM2rcIIxn7TemFByy9DBrfoL61YtNH+/8Sd6DNp rSrChJpxhe3Kbr9kNf9eAakQXtYFz3JuH6TVQLoD8YxFl4HCYpORnBz6FuKMUkwzpp TlaY5u+SMzo8rcSSxO/HH7FJZJlCBA2VaMwkJa+WXx7Cm0+YgXIt5tj83OzS60XRZN GgT91N+IPflwEcct4k9gYB86FywbJ6f7OM4VuVWEug8+4QMDPbt8IJn4gw49CAcvSB LPLTPRUtoDcJg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jRuQkWJh Subject: Re: [Intel-wired-lan] ice crashes when not enough IRQs X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sun, 15 Mar 2026 12:54:51 -0700 Jakub Kicinski wrote: > Trying to build a minimal kernel I dropped CONFIG_IRQ_REMAP=y from > my config, and (on AMD) that caused IRQ shortage. > > This seems to crash ice after commit ad61cd9c67ad ("ice: get rid of > num_lan_msix field"). Sorry for the lack of line numbers, I also > dropped DEBUG_INFO. But I think the problem itself is pretty obvious. > The fix less so, short of reverting ad61cd9c67ad. We can't just clamp > the queues in ice_vsi_alloc_q_vectors() because AFAICT that would make > ethtool -L succeed but driver would have a lower queue count than > requested. Hm, maybe it's not just CONFIG_IRQ_REMAP=y Enabling it makes no difference. Let me try to see what state the IRQ allocation machinery is in on this kernel. On distro kernel ice gets all the IRQs it wants at boot. But it also barfs something RDMA so I can't really compare..