From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9D021099B28 for ; Fri, 20 Mar 2026 17:49:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 71BF984955; Fri, 20 Mar 2026 17:49:08 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id CaBx6rfjK7dF; Fri, 20 Mar 2026 17:49:07 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B252884957 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1774028947; bh=x5coYV2m0Hrf853jK3AxLiJPMYhCiTplE5pkNnUBd3s=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=I6uyi8GfzJco8OkzSSRgZXdFkWf+rV2Munto1Xpeo77vvoJH6Gl7/WRShS5liI1Dv k8p9GSSmGD8KAKQ6jzQBCjbYFPIix2O4Uog7kM5KanGuxlyt2W4AiBoVCrjdbtxsqu gczM+4+7AgTaAZIxmTPslgdXt7vxbJFmYOVqN1fVQKBInCh49iV6HHVuKB4vC4WK5N sAs0e1uO+yQe1HzjNWLLzJmO5cSgVR2t30XmV4Wwl5ANiE1GjVpRG/sFI5sUSN5jOy ejPY+74MIm0mUXLTK6BPxSVtCgOpV5U2gbwtCwPBkYGeymlxoX3Nyu1c9v7rOtaEcS CMDZSj9oOFIaA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id B252884957; Fri, 20 Mar 2026 17:49:07 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id D683021F for ; Fri, 20 Mar 2026 17:49:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BA9B084957 for ; Fri, 20 Mar 2026 17:49:06 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id womcpQORCyjo for ; Fri, 20 Mar 2026 17:49:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org DE62784955 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org DE62784955 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp1.osuosl.org (Postfix) with ESMTPS id DE62784955 for ; Fri, 20 Mar 2026 17:49:05 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6C9FA443D1; Fri, 20 Mar 2026 17:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4789CC2BC87; Fri, 20 Mar 2026 17:49:01 +0000 (UTC) From: Simon Horman To: emil.s.tantilov@intel.com Cc: Simon Horman , daniel@iogearbox.net, ast@kernel.org, willemb@google.com, stable@vger.kernel.org, decot@google.com, bpf@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, edumazet@google.com, netdev@vger.kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, kuba@kernel.org, davem@davemloft.net, sdf@fomichev.me, aleksandr.loktionov@intel.com, aleksander.lobakin@intel.com, john.fastabend@gmail.com, hawk@kernel.org Date: Fri, 20 Mar 2026 17:48:43 +0000 Message-ID: <20260320174843.137651-1-horms@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319224159.23885-1-emil.s.tantilov@intel.com> References: <20260319224159.23885-1-emil.s.tantilov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774028945; bh=x5coYV2m0Hrf853jK3AxLiJPMYhCiTplE5pkNnUBd3s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pWQ++BbnJGdNK5Nxc684tR8zXPop5sbC7wcbUaQJcZwAaxn40MpVo0CpwrGGXb/Am vZSQm93CQ8talTNdSjhcYjj0kEHNyBzHzIQPGeWPatJHWnPZ/V7s8TEpxjZH1va++J TCZz5IVGrhhJtaZd3qCw8hByuO6gs0bPVESa+5eacXUd9J+e2fJnH9ZpqFvz29jlgw cFu0ZI4HUsFRcv8XF+nXoCFNLYTwffIajLtXbHumGG0COkbPKwtSSldZNtGYrNE8eh vH6nwITJIQaRTKYEHb50m4XI5Vdfnn/w/REc/HShm2WZr/Ksdi8r6Owinh4GQDS1Gu Z4Gd1uDSH3/4A== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pWQ++Bbn Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: fix xdp crash in soft reset error path X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- idpf: fix xdp crash in soft reset error path This commit fixes a NULL pointer dereference that occurs when idpf_vport_open() fails during soft reset. The fix restores vport->xdp_prog in the error path and updates the restart check in idpf_xsk_pool_setup() to use IDPF_VPORT_UP instead of netif_running(). > Fixes: 3d57b2c00f09 ("idpf: add XSk pool initialization") The Fixes: tag may not be targeting the correct commit. The primary bug being fixed is the NULL pointer dereference crash in idpf_xdp_setup_prog() that occurs when soft reset fails and vport->xdp_prog is not restored. Looking at the git history, this missing restoration was introduced in commit 705457e7211f ("idpf: implement XDP_SETUP_PROG in ndo_bpf for splitq"), where idpf_xdp_setup_prog() was first implemented. While commit 3d57b2c00f09 introduced the secondary issue with the netif_running() check, the main crash fix addresses code from commit 705457e7211f. Should the Fixes: tag point to commit 705457e7211f instead?