From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E01E01094461 for ; Sat, 21 Mar 2026 09:19:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B0FBA41E59; Sat, 21 Mar 2026 09:19:05 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zEDadWHvG2ao; Sat, 21 Mar 2026 09:19:05 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E566841E52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1774084744; bh=B5fqRTE3+6Q5vPw/H8P3cKvWg0vP2lU4Sc7A2SSL70I=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=2k4ioBT4Ae5ngCxxZLFnZ4wMFu9j3ogZNEOxnNb0r608tL4Hpk8b18m+DIizf6Bq7 oPTa4dpfyC2gqhcMnHpf3bYiIRETygqRq5jYGgBhzLnXbsMZjNegcTLNxHkqLSIm7+ LOO4fT4oNfeyzJCJKLkH2gVRsGpQClDVC0t6oRLnfKkAmIYbKD2LtAEDeqb8v/88Qg BEF2keKL7jv4ejExxFTtUVHbGgHBjG///AwcxtV7reim4g7fj/gUE9HK8Tvbku6TGp hCkrxj9G9D+uBqL2IYHZs9MVRyrF3CaQFX4vcg1OhvQimZGUyrsPgTEzrI5ahe+leJ Gt5PW0YnDzyww== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id E566841E52; Sat, 21 Mar 2026 09:19:04 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 8AC3934C for ; Sat, 21 Mar 2026 09:19:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 70CAB84112 for ; Sat, 21 Mar 2026 09:19:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qG5s84UNyx-J for ; Sat, 21 Mar 2026 09:19:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 99345840F5 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 99345840F5 Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp1.osuosl.org (Postfix) with ESMTPS id 99345840F5 for ; Sat, 21 Mar 2026 09:19:02 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6646360054; Sat, 21 Mar 2026 09:19:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22E2DC19421; Sat, 21 Mar 2026 09:18:59 +0000 (UTC) Date: Sat, 21 Mar 2026 09:18:57 +0000 From: Simon Horman To: Tony Nguyen Cc: aleksandr.loktionov@intel.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Message-ID: <20260321091857.GU74886@horms.kernel.org> References: <20260320050525.422403-1-aleksandr.loktionov@intel.com> <20260320193314.171338-1-horms@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774084741; bh=+PT2Ef3M/EjliKhKgDJD4Sx3IT5CPfpBTznnG/+7vHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=olTX/WolFzZ4TWAxYX/Rb+2iYgz/gE4jTXBWYe6j7SgwGPgFLNax5HcBUSGZpomzT U6VVJtcA7GqvwZ3sg8HUhsBy802+46Rs15UqsMbtnOv+hg013HiFtydbFbqQg+l4xD pt1ILCGuFxkNdyGlGl8RL4Qq5lTMYasJECGq4OqCEYzWy9mVP0Exax9T49zR+xJ4VE p8lYCFnBzzLJM5xvnJ8pDeVpeyW55qmmIDCXXGWgAbylPm5y+nFZFbzxV8JFpoVjYQ W+zFc6xqVvPxTqZ3u6gvJDKmbEHNzRhcTv4+z8NqnCqk5dS98IKB0e9SOezNsjI5cg HVjb6B5K+zp1g== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=olTX/Wol Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: do not carry link status over to link event data X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Mar 20, 2026 at 03:05:24PM -0700, Tony Nguyen wrote: > > > On 3/20/2026 12:33 PM, Simon Horman wrote: > > This is an AI-generated review of your patch. The human sending this > > email has considered the AI review valid, or at least plausible. > > > > For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html > > --- > > ice: do not carry link status over to link event data > > > > This patch removes code that updated the link_up parameter with the > > current firmware state after calling ice_update_link_info(). > > > > > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c > > > index e7308e381e2f..348c86b7328d 100644 > > > --- a/drivers/net/ethernet/intel/ice/ice_main.c > > > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > > > @@ -1127,12 +1127,6 @@ ice_link_event(struct ice_pf *pf, struct ice_port_info *pi, bool link_up, > > > > > > ice_check_link_cfg_err(pf, pi->phy.link_info.link_cfg_err); > > > > > > - /* Check if the link state is up after updating link info, and treat > > > - * this event as an UP event since the link is actually UP now. > > > - */ > > > - if (phy_info->link_info.link_info & ICE_AQ_LINK_UP) > > > - link_up = true; > > > - > > > > Could removing this check create a race condition with stale link events? > > This was a part of other changes that allows this to happen. By itself, as > evidenced here, it does not. Thanks for the clarification, much appreciated.