From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E77610F287A for ; Fri, 27 Mar 2026 23:47:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 17FBD411B1; Fri, 27 Mar 2026 23:47:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xxBZOq1xbfdw; Fri, 27 Mar 2026 23:47:22 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D0F64411B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1774655242; bh=zxFh21zA0f1E32WvYWkeJsNVFM+NjTzu0tGKpTPaBHM=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=S21qA1Cr2rz1MDnAOm2KiArapJaeVol11XjzozNXVC6hcPTx/bL/Ke3KkpoVu5gx7 NoDfJWOFuKLpQnbJr6px9V5J4snbF1wIrpElAgxIuaqjVRIqx6eX2k1rZJh2xn/jrt 0BIK7XAD9sj++3loLnYQizqaxhHsEFz8e2ULBswk1kb+/ThqW0v8OFnxVjofDv7SMA H+LHWrujMLQxUzZVyi6+vdJEEQf5GuBCQTT1MjPtuXcKkFZff1AqLzv4vAUsQ8EpM3 o/TIMWtlbUmIUnuaPngu/nl52iUN4Z2KEfzxP5/oeRv9W2aqiWnCF2UeBuK5T46ieH Zr07ZZsQUeEGg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id D0F64411B6; Fri, 27 Mar 2026 23:47:22 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id BDF1510F for ; Fri, 27 Mar 2026 23:47:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9AB5540752 for ; Fri, 27 Mar 2026 23:47:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8VtxPUTekPhD for ; Fri, 27 Mar 2026 23:47:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org CFFD0400C7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CFFD0400C7 Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id CFFD0400C7 for ; Fri, 27 Mar 2026 23:47:20 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 196D6405D2; Fri, 27 Mar 2026 23:47:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F5A4C19423; Fri, 27 Mar 2026 23:47:19 +0000 (UTC) Date: Fri, 27 Mar 2026 16:47:18 -0700 From: Jakub Kicinski To: Przemek Kitszel Message-ID: <20260327164718.72bf4b65@kernel.org> In-Reply-To: References: <20260325063143.261806-1-przemyslaw.kitszel@intel.com> <20260325063143.261806-2-przemyslaw.kitszel@intel.com> <20260326143808.1fd69825@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774655240; bh=LJC6boXcVhCOgdtGYeqxWCvOrumqAszQh6+n3gXpp+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=km2qaZOBKVgNrSzyi1afKAHfByPv2flHHCdCWRdIpAQYPxYvE2C+GMSKp5spf+21s 6NVoLUMYoVLr9HU9okRXyJoZW1qzcWnQGKy0CcV/YsyjRKtFAdzGEC3K7Qnn/HEiI9 wfhf20Rr5klNZmdq8/X5BwVXTayxGCVeWGF0oyjk9lW3QkfVb0tVHDSMgzhNLwoqQ3 WWRNU9yNyiLRVZA63p+1ChWhOyvWmturIlJJxB3iMdfuOMv/ZBydBg5Dk1SodZQEFv RDdIYZ93jtZq8qHj9tzybuzIkVr++WgjrPpOAo15epn1mA4fbtJ7tFSf/A6BNauO0F h31Z3ot0FVk1Q== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=km2qaZOB Subject: Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify devlink_shd_get_priv() into devlink_priv() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, Aleksandr Loktionov , edumazet@google.com, Tony Nguyen , horms@kernel.org, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 27 Mar 2026 08:42:47 +0100 Przemek Kitszel wrote: > > If we are worried about misuse we should instead add an accessor > > for "individual" (better name welcome) instance and WARN_ON() > > when devlink_priv() is used in the shared setup. > > that would require the same amount of code as this patch (curr ver) > has, only with WARN_ON() instead proper value (IOW: we detect what > developer wanted, and give them big warning instead) I guess I don't understand why you're so certain that you know what the developer wanted. I'm of the opinion that the "individual" devlink instances should not exist at all. Y'all want them, and claim to have use cases for them. And yet, it is somehow not valid to get their priv.