From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A23FA10F995B for ; Wed, 8 Apr 2026 16:27:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6449760F89; Wed, 8 Apr 2026 16:27:59 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id YKJYjn4VS3OB; Wed, 8 Apr 2026 16:27:58 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1634D60F86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1775665678; bh=DYRfVSgz4owZLDI/ocXpU8b8l7pYzkfmHaO7VL83kC8=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sxs9YD2PjlF0suK4WcKYWzFEAbjFtZnlHh8wcFFhsrHXXKQZdI/8jTKNPzWZMFjF+ TSJhqe59F+Roqqrdy67O4USxOfujbDqFZeO/46QFKaZtl+JxmdgnyZG7K74pW1yxAO tOADVJqFtkE8Ctb9WvFgrYfVoRJpjgGPiPaVcpFMbnX+X4GTiHk9ov7ewg3ckcZmuV hOszgsMjxFs+LZaUx3Kse2OMZBTWxfSp5V1tXpV6KtV1dEBIgdo/1QZMzFQFwzoGCh I9LuSVuSUou9lxVBpxh5hzs6yWheMI7UjhXZP72nnLyrTZxotqM5vjPJXGHHGvIt8A SH/H9rUNdagDw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 1634D60F86; Wed, 8 Apr 2026 16:27:58 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 6A8A4237 for ; Wed, 8 Apr 2026 16:27:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5BEA34033D for ; Wed, 8 Apr 2026 16:27:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AAv_RnJIXUaU for ; Wed, 8 Apr 2026 16:27:55 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org A4928400C1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A4928400C1 Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id A4928400C1 for ; Wed, 8 Apr 2026 16:27:55 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 247184326F; Wed, 8 Apr 2026 16:27:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 367B5C19425; Wed, 8 Apr 2026 16:27:52 +0000 (UTC) Date: Wed, 8 Apr 2026 17:27:49 +0100 From: Simon Horman To: "Tantilov, Emil S" Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, milena.olech@intel.com, jacob.e.keller@intel.com, konstantin.ilichev@intel.com Message-ID: <20260408162749.GD469338@kernel.org> References: <20260403153538.11516-1-emil.s.tantilov@intel.com> <20260407160241.470945-3-horms@kernel.org> <626f3619-499d-458e-8536-2cc30984656d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <626f3619-499d-458e-8536-2cc30984656d@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775665675; bh=9Aj6Lw7cNs33pOaJ8kTW0W5iCQ1Qu6l87NcJHj4Zyes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hmhIq463mdAgSJJmPsbHuHN9fSnUReA8mAjepwiLZ5CjFFGlNDBVo6WpRRj/z4yDc 7NWVquzHt7uY6MAU5fcSFLMiM1Wc3CAjcMBu3aIdXyS+KL/A9iH4WlxqRHD5a38A2o ojwsGYoTeWYYsl/TT1g8sctXqMaM1hBOUhVhRT+QAKDFawfWKSrcnYUK+XOYpWw5sz AvwPVOEmapLQHL5wJpRVKDuyRjNuzb3BF+s4n6zWh6D6FuAYBHwvjrPs1lrxjVhpWH +1v/8KHWV1uCnkJGI41+/xRY0OVw/cpFaKdZGikdE0au+HC2fp/ud4JJb6s+F+EVXm RW9ugAOKVdhIA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hmhIq463 Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix read_dev_clk_lock spinlock init in idpf_ptp_init() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 07, 2026 at 03:00:22PM -0700, Tantilov, Emil S wrote: > > > On 4/7/2026 9:02 AM, Simon Horman wrote: > > From: 'Simon Horman' > > > > This is an AI-generated review of your patch. The human sending this > > email has considered the AI review valid, or at least plausible. > > Full review at: https://sashiko.dev > > > > Simon says: I don't agree with the regression characterisation made by > > the AI review - I think this patch is good. But I do think the issues > > flagged by the AI review warrant investigation. > > The point of the change is to resolve the use of uninitialized spinlock. The > questions below appear to be generated around that code, which would > be out of scope for this patch, but I will address them anyway ... Right, I agree with that general statement on the review: it muddles up potential problems in nearby code, with problems introduced by your patch (none seen). I do thank you for analysing the problems raised. And I'll leave it up to you to provide follow-up patches as you see fit. For this patch, I think we are good. Reviewed-by: Simon Horman