From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27A65F34C56 for ; Mon, 13 Apr 2026 14:11:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CDEA784797; Mon, 13 Apr 2026 14:11:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8s8Fk3QLZLNY; Mon, 13 Apr 2026 14:11:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9B5558478F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1776089494; bh=DS+S0BRyZHRR76xF3fsEAk6msLD+shY5kdGfLkw+59M=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=5IrH54aTBDhuladj5r410PFwdQDg0R7uSXxEAeBWNN2I8RRCxLbAzM3aFramTELSz wZUphAE6rNkpYlVzToxorXuP3gNoRKVhw5UPga4NwhAMAgeckY1Vfot+4ZFm6Qp4X1 iZjwuAUlT+fsdLGk165GDp7yUaiWcpYYsDtCQooYSRCnD9aYusuRhuRGgdrTHc7szu FyqKSLnufTYuddgvpZ5zRaFLnAQVyiFxho0r3kVGhY50UQeLgKVTDIZ3tk1/amPodX cQAyzj2YOJM5E3AkeUdpUGb6+F45cnULA2IrAba0kJXbN5zxTTG5svzPMKPotuhoDk pW+/C4kfGsvxw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 9B5558478F; Mon, 13 Apr 2026 14:11:34 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 4130F237 for ; Mon, 13 Apr 2026 14:11:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3245D422AE for ; Mon, 13 Apr 2026 14:11:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id iOIBPHzOVTR4 for ; Mon, 13 Apr 2026 14:11:32 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7242E41F54 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7242E41F54 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7242E41F54 for ; Mon, 13 Apr 2026 14:11:32 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7BC0260172; Mon, 13 Apr 2026 14:11:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD6D9C2BCAF; Mon, 13 Apr 2026 14:11:28 +0000 (UTC) Date: Mon, 13 Apr 2026 15:11:26 +0100 From: Simon Horman To: Matt Fleming Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Matt Fleming Message-ID: <20260413141126.GR469338@kernel.org> References: <20260408190214.1287708-1-matt@readmodwrite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408190214.1287708-1-matt@readmodwrite.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776089491; bh=gFRvrKXlOfg+aEGi39wpVj9CoHvkfV4SW9XjwhO71Bg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vuz8JIgyGFQs79J7jNYhLXjVTEJKcIy7q5fIMQvp69Rs6UAmh9zywB6sRRJyuSPZ2 g+pdHQ203cM48BifuF+R1XKrQAour1unMgz1Hs9HNTMCQzb2M3F4CRrv4S2bN2AAfT 29qhXHvawfyEttE99sA2TD0YgSFFuxY+c2+oUt2NwsZH5HNRQi85n8aohpaOvSd32v fM9Vygo51KBRkcEEhB8B9OMaZ7kqOmtJ3ZeRTprb2EqP88EMVtZe1TDG9WyHnoQiru RKdLCkyaoXwYB6kV24hu8LH8p1H1q0ApAoO5ee8ZbPe7R36iMv9CJbvNo5XyKF14mn aGz59T8PyA/0w== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Vuz8JIgy Subject: Re: [Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement negation in GCS raw checksum X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Apr 08, 2026 at 08:02:14PM +0100, Matt Fleming wrote: > From: Matt Fleming > > Commit 905d1a220e8d ("ice: Add E830 checksum offload support") added > Generic Checksum (GCS) support for E830 NICs but omitted the 1's > complement negation (~) when converting the hardware raw_csum to > skb->csum for CHECKSUM_COMPLETE. > > Without the negation, every CHECKSUM_COMPLETE packet fails the > fast-path validation in nf_ip_checksum() and falls through to software > checksumming via __skb_checksum_complete(), which triggers the > rate-limited "hw csum failure" warning. Packets are still accepted > (the software recheck passes) but hardware checksum offload is > effectively disabled and the warning floods dmesg on systems running > nf_conntrack on VLAN sub-interfaces. > > Multiple other drivers (idpf, ehea, iwlwifi, cassini, sunhme, enetc) > also apply ~ for CHECKSUM_COMPLETE. The ice driver was the only in-tree > user of csum_unfold() for CHECKSUM_COMPLETE that omitted it. > > Fixes: 905d1a220e8d ("ice: Add E830 checksum offload support") > Signed-off-by: Matt Fleming Reviewed-by: Simon Horman