[Intel-wired-lan] [PATCH iwl-next 5/10] ice: improve Add/Update VSI error messages in ice_vsi_init()

Aleksandr Loktionov
2026-04-10T07:49:38Z

The error messages emitted when Add VSI or Update VSI Admin
Queue commands fail are missing the VSI index and the last AQ
error code. Add both to match the pattern used elsewhere in
the driver for AQ-command failures, which helps narrow down
firmware issues without requiring debug logs.

Signed-off-by: Eric Joyner <eric.joyner@intel.com>
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 689c602..0e79d66 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -1320,14 +1320,18 @@ static int ice_vsi_init(struct ice_vsi *vsi, u32 vsi_flags)
if (vsi_flags & ICE_VSI_FLAG_INIT) {
ret = ice_add_vsi(hw, vsi->idx, ctxt, NULL);
if (ret) {
- dev_err(dev, "Add VSI failed, err %d\n", ret);
+ dev_err(dev, "Add VSI %d failed, err %d aq_err %s\n",
+ vsi->idx, ret,
+ libie_aq_str(hw->adminq.sq_last_status));
ret = -EIO;
goto out;
}
} else {
ret = ice_update_vsi(hw, vsi->idx, ctxt, NULL);
if (ret) {
- dev_err(dev, "Update VSI failed, err %d\n", ret);
+ dev_err(dev, "Update VSI %d failed, err %d aq_err %s\n",
+ vsi->idx, ret,
+ libie_aq_str(hw->adminq.sq_last_status));
ret = -EIO;
goto out;
}
--
2.52.0