From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1266FF419B6 for ; Wed, 15 Apr 2026 13:26:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AB7E4852AE; Wed, 15 Apr 2026 13:26:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ElmIidzcHYdo; Wed, 15 Apr 2026 13:26:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org DFA2E852A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1776259594; bh=7m2ezkIqo2uvDe3HqFJVxl++HhvSoFZ87y2IFRDhQfc=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=07EVxxfZZ96+xB5bqnNTp0vtcFZzAf27UKWySP4xl/EZ/1qkTuSfu9ebej0eVrSfk I3u05MWc3EifaWIf9+1aFToo+Vhm8mJU+gHQzpdamns8/ix8EetTdqgw5URrN5XvND BGaPQfy+kn/TKtuzP/hJShNfsZ1UCSLE1Serh2H0y7kIUTWY6PcsLoLVDQFPRf8xcz EhOAMBXIt7u51liuldyEx7C138Xgmi27Y+mXwdqL9IUQ26KsBf7x5ImcKYDzd/4MHG RUQBTRG7KyYN4n2quU8jReQrw3ELAJFh5LeaQrbkSWli3qD5RP6oSNhmlhGXzRxkJm Sd4dpaKyABu5g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id DFA2E852A1; Wed, 15 Apr 2026 13:26:34 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id C876C237 for ; Wed, 15 Apr 2026 13:26:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AE61161B28 for ; Wed, 15 Apr 2026 13:26:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id tbm1Q5Vl9vYz for ; Wed, 15 Apr 2026 13:26:32 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BE2B161ACF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BE2B161ACF Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp3.osuosl.org (Postfix) with ESMTPS id BE2B161ACF for ; Wed, 15 Apr 2026 13:26:32 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3184744275; Wed, 15 Apr 2026 13:26:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B309EC19424; Wed, 15 Apr 2026 13:26:30 +0000 (UTC) From: Simon Horman To: aleksandr.loktionov@intel.com Cc: 'Simon Horman' , intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, kiran.patil@intel.com Date: Wed, 15 Apr 2026 14:26:11 +0100 Message-ID: <20260415132610.803526-2-horms@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413073035.4082204-3-aleksandr.loktionov@intel.com> References: <20260413073035.4082204-3-aleksandr.loktionov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776259592; bh=DENY9p9CKwihwW347KzzpeYMyVvwNcN5J3ZSHZcwozU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bf7vnJgpzCsbPUH8WG8aESx8Oi+xPqzTkKQaUX7Pc5u2zei199VgIVJlfLq5cU4v9 TGajpwWHwS8L9OyXYRva8Iv/nJm3OJj1vLNpCyfTKA/MnGfZUAvSVIQ/irb6M1vPGI UZ/oAZ0211kBLmKkwVazf18jzrnthWWp5eGlXWWilmllIaKghpfjLJ4XiGSFjLTDMU zeP86rJ4KfySFbfchl5zVQHbNaci1v7fIEwY8mEgOl0inXbgomqSDYoiZZ0f2WqjEY HxNJrENRJAV4FdDNtfNQpLJGIrIFUlXbr2IGm7IpEY4juAuAOVw0Met80TpFdcYMFQ z6Q+AO+uypEtQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bf7vnJgp Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/5] iavf: fix error path in iavf_request_misc_irq X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: 'Simon Horman' This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. Full review at: https://sashiko.dev --- iavf: fix error path in iavf_request_misc_irq This patch drops the free_irq() call from the error path of iavf_request_misc_irq() when request_irq() fails. This is intended to prevent a kernel warning when freeing an unrequested vector. > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index dad001abc9086..ab5f5adc2d3c2 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -587,7 +587,6 @@ static int iavf_request_misc_irq(struct iavf_adapter *adapter) > dev_err(&adapter->pdev->dev, > "request_irq for %s failed: %d\n", > adapter->misc_vector_name, err); > - free_irq(adapter->msix_entries[0].vector, netdev); Does this patch completely fix the warning? If request_irq() fails, iavf_request_misc_irq() returns an error but leaves adapter->msix_entries allocated. In caller error handling paths like iavf_disable_vf() which clean up after a failure, iavf_free_misc_irq() is called: static void iavf_free_misc_irq(struct iavf_adapter *adapter) { struct net_device *netdev = adapter->netdev; if (!adapter->msix_entries) return; free_irq(adapter->msix_entries[0].vector, netdev); } Since adapter->msix_entries is still allocated, the check passes and free_irq() is called on the unrequested vector anyway, triggering the exact same warning. Does the driver need to explicitly track whether the IRQ was successfully requested? > } > return err; > }