From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53AD4F588EC for ; Mon, 20 Apr 2026 15:54:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1DEDE610F6; Mon, 20 Apr 2026 15:54:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id O_SKgILYaRUN; Mon, 20 Apr 2026 15:54:15 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5F54C6105F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1776700455; bh=J7o/8KgJizxABEXyLEkezDlutD4Gutygp+NZfiPyNo8=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NPMGyMzkBrxwxbj6IGt399h8WTmEP6ZVu1L8oaWEypcPsbjDWe0pC4Qwk2/IGSXy2 8KeZCghKx+pYatRkrR11bpz1D6EmQ21adVEZvqYfi3VE3EFAxDwSNEuEEzfIcm3sC5 ji2jqOIGlfG04QFfbRZQOVHUgBoK9AOi/ISS8SmmJF5i9LViOEQzro4jan8PgLOHHe g77TcCZWWiPC43HwDM2HvK455PQO02lNf45jMpOb650B16RxDJJ7cxJK/F99R3+8gV B49lkEM7Acf/TbJaOfctE0tAw0iWAEN+hIA0zuKW7TrccabomFMXS2x7VnRt6XCQOO /y5HM0Br69EsA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 5F54C6105F; Mon, 20 Apr 2026 15:54:15 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id AAA42355 for ; Mon, 20 Apr 2026 15:54:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 909BA6105F for ; Mon, 20 Apr 2026 15:54:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id u6ikNOBX7-FG for ; Mon, 20 Apr 2026 15:54:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BBB4660AA1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BBB4660AA1 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id BBB4660AA1 for ; Mon, 20 Apr 2026 15:54:13 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6DBEB4368A; Mon, 20 Apr 2026 15:54:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10939C19425; Mon, 20 Apr 2026 15:54:11 +0000 (UTC) Date: Mon, 20 Apr 2026 16:54:09 +0100 From: Simon Horman To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, Konrad Knitter Message-ID: <20260420155409.GT280379@horms.kernel.org> References: <20260417062954.1241900-1-aleksandr.loktionov@intel.com> <20260417062954.1241900-3-aleksandr.loktionov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260417062954.1241900-3-aleksandr.loktionov@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776700453; bh=KjHyxxjPDBim6sQ9KYPdRWv3pfyjQHkMzJZQEGKI5R0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=md5E8DjZIOSFg8J9sBuryhu60e/wjXlftP7tYt1NXoHXTc9pfr9SQohuJfb3bmkM2 ftBxgWfg9FHJtRzqdQTWfijvvXCDRWQe0TGGpSCktRyA24k3A49qAhiL32mlYT9Mt5 MvjhQcGoccQLUkUEnxtyZHTy+XA5hK66+4w8Lc6NiVPpIDM3gj4zrbleVx8MQbFJ57 dKZI5TB6U1h2q/GmhVwdQf+4rbrOCD7SqkIe6y5bCwPN/HEmIqTn9zywFZQg2o6VT9 d7TzPUtNFhnyVG84SCeAKDgKrIxUjFErptquIX8jI/uBn5UC3l77XSJUOFjOBu5B0I m572eY2mik9KQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=md5E8DjZ Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable when link partner doesn't support AN X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Apr 17, 2026 at 08:29:52AM +0200, Aleksandr Loktionov wrote: > From: Konrad Knitter > > Disabling autonegotiation was silently ignored when autoneg had not yet > completed (ICE_AQ_AN_COMPLETED was not set), leaving the configuration > unchanged with no error. This could prevent link from forming if the > link partner requires non-autoneg mode. > > Extend the condition to also allow disabling autoneg when the link > partner reports no AN ability (ICE_AQ_LP_AN_ABILITY clear). Gate the > ICE_AQ_LP_AN_ABILITY check on the link being up so that stale or > zeroed an_info when link is down does not produce a false positive. > Introduce the helper ice_autoneg_disable_allowed() to make the check > explicit. > > Fixes: f1a4a66d2310 ("ice: fix set pause param autoneg check") AI generated code review [1] flags that this does not seem to be the right Fixes tag and that the following seems more appropriate: Fixes: 48cb27f2fd18 ("ice: Implement handlers for ethtool PHY/link operations") [1] https://netdev-ai.bots.linux.dev/ai-local.html > Signed-off-by: Konrad Knitter > Signed-off-by: Aleksandr Loktionov The above not withstanding, this looks looks to me: Reviewed-by: Simon Horman I somehow feel obliged to acknowledge that Sashiko has provided review of this patch. However, I don't believe any of the issues flagged there should block progress of this patch. You may wish to look over that review for possible follow-up activity. ...