From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 860EDF588EC for ; Mon, 20 Apr 2026 15:56:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2A72D8291C; Mon, 20 Apr 2026 15:56:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3tNF1yFfu8B0; Mon, 20 Apr 2026 15:56:26 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 713708291D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1776700586; bh=QtC6e8MpcAXtuF9Y3/YJXdsJokgg6hm3QJ4Wa2lKWIc=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eNY7gZ6kwPQTxzdUJOB4Yvr+ZlnEEaw3H6SzfD+g89GM4wbdy/9jg3UNhtfdeL2aa Y3C6arHPqDgAtoi8O9KBEvE6MlPqv97LQkYwdwpi4wg7Zn93QEdPLGFJvstk/lgREf 0UWSOLcNzA7p6ns/Ua6mzAFsqA+Qd/3zi/uhjAlibD+pleuw6hR0SgAcYvzWBybyd6 MWNquSqgf6QHGr9XW287s3TIyaadIvCT5S0RKmecA74I43pgjcsviUndxjTKdI94tP vOhn8t21zN4UudJKCfB8ASbN9t2DstjlmY7oQdsfLH8CzIRsn+wKrO3t3Kb6t2EVIW VZEc6zKe5042w== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 713708291D; Mon, 20 Apr 2026 15:56:26 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 74421355 for ; Mon, 20 Apr 2026 15:56:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 661C96105F for ; Mon, 20 Apr 2026 15:56:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 1dxKefuiJRzB for ; Mon, 20 Apr 2026 15:56:24 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 9887E60ABB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9887E60ABB Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9887E60ABB for ; Mon, 20 Apr 2026 15:56:24 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 952E260018; Mon, 20 Apr 2026 15:56:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E37D6C19425; Mon, 20 Apr 2026 15:56:21 +0000 (UTC) From: Simon Horman To: aleksandr.loktionov@intel.com Cc: 'Simon Horman' , intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, jan.glaza@intel.com Date: Mon, 20 Apr 2026 16:56:04 +0100 Message-ID: <20260420155604.576318-1-horms@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417062954.1241900-4-aleksandr.loktionov@intel.com> References: <20260417062954.1241900-4-aleksandr.loktionov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776700583; bh=9Qgqeri4ieAdo6+5MWuNmYIp4MCTl3DLSaPutxRqWfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ksmEw8KYLFBEBK2tCdF7SXGEKmpxM7ZICe3lhvRKln9sXBeFa2xWxzLFjbC5vrc13 /WbPEX4nslhLuPVukFOPgxQiWh5raYTvk3f+21U1GLBrIyhe+B05EMYDrgo1N3hrlQ JkYk+tUCAhA29Y6fn8UCJiw6xLCidkOv6vXTr3p9XGs1J6vmnh2AjGXW8LEiyFjZaT uHuqXIP4CqZtieutBJ7lO/MyogE32IXEa7NFgXQ+L4jZmJp5bqONbZdibB471R6oGv k1fOEYGPzteio9nK9ycuEf7mAZiYKqr5YhQWPlrUY7n+YBqvp6ELPuvez97WFtyOfI j8qUoiy9mbmMA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ksmEw8KY Subject: Re: [Intel-wired-lan] [PATCH iwl-net 3/4] ice: support RDMA on 4+-port E830 devices X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: 'Simon Horman' This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. Full review at: https://sashiko.dev --- ice: support RDMA on 4+-port E830 devices This patch narrows the RDMA capability check to keep RDMA enabled for E830 devices configured with more than 4 ports, as they do not share the limitations of E810 and E82X devices. > diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c > --- a/drivers/net/ethernet/intel/ice/ice_common.c > +++ b/drivers/net/ethernet/intel/ice/ice_common.c > @@ -2509,7 +2509,7 @@ ice_recalc_port_limited_caps(struct ice_hw *hw, struct ice_hw_common_caps *caps) > caps->maxtc = 4; > ice_debug(hw, ICE_DBG_INIT, "reducing maxtc to %d (based on #ports)\n", > caps->maxtc); > - if (caps->rdma) { > + if (caps->rdma && hw->mac_type != ICE_MAC_E830) { > ice_debug(hw, ICE_DBG_INIT, "forcing RDMA off\n"); > caps->rdma = 0; > } Does this leave the diagnostic message further down out of sync with the new condition? If the device is an E830 with more than 4 ports, RDMA remains enabled, but because the dev_info() call just below this block is evaluated for all devices with more than 4 ports: ice_recalc_port_limited_caps() { if (hw->dev_caps.num_funcs > 4) { ... if (caps->rdma && hw->mac_type != ICE_MAC_E830) { ice_debug(hw, ICE_DBG_INIT, "forcing RDMA off\n"); caps->rdma = 0; } /* print message only when processing device capabilities * during initialization. */ if (caps == &hw->dev_caps.common_cap) dev_info(ice_hw_to_dev(hw), "RDMA functionality is not available with the current device configuration.\n"); } } Could this cause confusion by logging a warning about RDMA being disabled when it is actually active?