Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test

Jacob Keller
2026-04-25T00:37:18Z

On 4/24/2026 1:32 AM, Corinna Vinschen wrote:
> On Apr 23 19:55, Simon Horman wrote:
>> On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote:
>>> This is just a simple cleanup fix. Commit 35a2443d0910f ("iavf: Add
>>> waiting for response from PF in set mac") introduced a duplicate
>>> ether_addr_equal() check, so the current code tests the new MAC twice
>>> against the former MAC.
>>>
>>> Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b
>>> ("iavf: fix MAC address setting for VFs when filter is rejected")
>>>
>>> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
>>> Fixes: 35a2443d0910f ("iavf: Add waiting for response from PF in set mac")
>>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>>> ---
>>> Added CC: stable@vger.kernel.org
>>
>> Hi,
>>
>> This feels more like a cleanup for net-next (without a Fixes tag)
>> than a fix for net. I'm missing where the bug is here.
>
> Yeah, it's not a bug, the "Fixes" tag was just supposed to point out the
> patch introducing the duplicate test.
>
> Shall I create a v3 or is it ok as is and just goes to net-next instead
> of net?
>
>
> Thanks,
> Corinna
>

I can make a note for later and either myself or Tony can forward it
net-next as part of an Intel Wired LAN update when the merge window
re-opens and any testing has completed. (Not that there is much needing
to be tested in this patches case)

Thanks,
Jake