From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B17FFED3C1 for ; Fri, 24 Apr 2026 12:40:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AFC7584A42; Fri, 24 Apr 2026 12:40:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id shJY4KFpHj4m; Fri, 24 Apr 2026 12:40:49 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org DF51584A26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777034448; bh=Os6slKuiLGxBWiHsIraIVXqi+PiGactCEycWMtcaDv8=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CGEsLwjVdRbkG07CE7r2/2npo8vqREBJybaO50f5O/mjxK7eQwsgP4jxJBGhVCwC3 08i9Jw1TlGxYiU689fvNqN/nHADXawJ1R+PnxTIrKkzPOxSXgEoe1fefIrIUIsx2ET /Oj1A5YYIdDlXq0FO7rP5k51KGpozX3BkT56U7Nl4MDexvQpIvqz6yAKkyMYVzIXxQ PwbnIjyZVRc8byE5+spmkTvQo4w1Wm5RIV9p1D8ZHP4zMjIOjp5SKSW6/NkVhjovFh rWTEI+YFh7Gs4vHxcq4VR8V0hcPw6yEATM/LP6JRnrpqljtawTc8xtTeUh3BhxEi/C 0hAUwNYc8D0xA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id DF51584A26; Fri, 24 Apr 2026 12:40:48 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 6624B231 for ; Fri, 24 Apr 2026 12:40:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4B70E422AC for ; Fri, 24 Apr 2026 12:40:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id MUm72BCuTZCA for ; Fri, 24 Apr 2026 12:40:46 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 3813840194 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3813840194 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3813840194 for ; Fri, 24 Apr 2026 12:40:45 +0000 (UTC) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-KXYT9KXtN8O36aMG-Drc7w-1; Fri, 24 Apr 2026 08:40:40 -0400 X-MC-Unique: KXYT9KXtN8O36aMG-Drc7w-1 X-Mimecast-MFC-AGG-ID: KXYT9KXtN8O36aMG-Drc7w_1777034438 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 84E00180034F; Fri, 24 Apr 2026 12:40:38 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.29]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5FFE519560AB; Fri, 24 Apr 2026 12:40:32 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: aleksandr.loktionov@intel.com Cc: anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, horms@kernel.org, intel-wired-lan@lists.osuosl.org, jacob.e.keller@intel.com, jesse.brandeburg@intel.com, jtornosm@redhat.com, kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, przemyslaw.kitszel@intel.com Date: Fri, 24 Apr 2026 14:40:31 +0200 Message-ID: <20260424124031.834241-1-jtornosm@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: DMrccyLsOTTYYXsb6rdGa0a40r7Ecs31HHGjeD79mdA_1777034438 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777034444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Os6slKuiLGxBWiHsIraIVXqi+PiGactCEycWMtcaDv8=; b=ZJU0KSzpJdfLiKq2HD5QvDPb50JR5k82l+8zYYAEdbpQuw6xWNwg3ko/yQBSCNupRLH8+t 5kQXbHt4aDPNFvvpHhFvUZrbRnI7uFMdRHmBcr0JPrruvGKUE2PB6EjWAUqoNmrSlz/ivc BS0EFNMfVZIwyzlbDnSpTXgL7ft8Prw= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZJU0KSzp Subject: Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF reset when setting trust X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hello Aleksandr, >>> You declare ice_vf_clear_all_promisc_modes() returning int, but >>> ignore the return value. >>> Looks suspicious isn't it? >> Well, it is used like that when the funciton is called locally (the >> function is not modifiedi, just made public), and really my intention >> was to clean as much as possible (so error checking is not necessary). >> In my opinion it would be enough to warn about the possible problems >> (already done in the existing function). > Can you go extra mile and add error code handling? > Or at least document it in the code why you don't do it? Ok, I can add the error handling in ice_setup_vf_trust and an extra warning to indicate that promiscuous mode clear failed when revoking trust. Just let me wait a bit longer for more possible reviews to create the next version of the series. Thanks Best regards Jose Ignacio