From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD8B6FF886D for ; Tue, 28 Apr 2026 07:48:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A747841121; Tue, 28 Apr 2026 07:48:46 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id GHL8ar7UWixp; Tue, 28 Apr 2026 07:48:45 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 440564111E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777362525; bh=72kvUDy67XvkuOCjTdd6EaMNEGi97jXi33FAtt2eb9o=; h=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=SZGbPj3mSIlsGuVPOcc9sCplaW5bkf9Tt9mx2sJvQyAcxKT+/zb3FhFyy4sZBSrQh KG7zYP3baSSuKNSWZxs1Lo2kGooV21soAZSmhmwUE1KlbU36DxZ656jgZw6Im06Uyj /qtmtoz4MFIxXBb60Ppus8HZu5OQnpVwk2AhcHP0zcWsqqHnYbyXFDBuE+xxtYnZH9 p3mUnCuQkgaHllBA5qsBVRnIMguDLLqRLPRGA8KkrVlQm+KLYYjUADSZYZ4S614vAC RnTItSMoEQkyqzBS/Vv4ND3BcqGtbjCl5lztsvjtHofALTlDV8SWoBSdxyQMdOUS4V WKFPzF1PUAXNQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 440564111E; Tue, 28 Apr 2026 07:48:45 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 890E5231 for ; Tue, 28 Apr 2026 07:48:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6F14683595 for ; Tue, 28 Apr 2026 07:48:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uH3cvvdZ_lTQ for ; Tue, 28 Apr 2026 07:48:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4C31181DF6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4C31181DF6 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4C31181DF6 for ; Tue, 28 Apr 2026 07:48:42 +0000 (UTC) X-CSE-ConnectionGUID: o4T6po1jT1eqRfLqYvEj6g== X-CSE-MsgGUID: WGJCjy5URF25aBW4mn7k/w== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="82114974" X-IronPort-AV: E=Sophos;i="6.23,203,1770624000"; d="scan'208";a="82114974" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 00:48:41 -0700 X-CSE-ConnectionGUID: 6zDqpDuoQdS5dOu/lJqulA== X-CSE-MsgGUID: 81SKb8KxQ/S+MTVdb8qPmQ== X-ExtLoop1: 1 Received: from os-delivery.igk.intel.com ([10.102.21.165]) by fmviesa003.fm.intel.com with ESMTP; 28 Apr 2026 00:48:37 -0700 From: Michal Swiatkowski To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, jramaseu@redhat.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com, Michal Swiatkowski Date: Tue, 28 Apr 2026 09:06:45 +0200 Message-ID: <20260428070647.777141-1-michal.swiatkowski@linux.intel.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777362522; x=1808898522; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1J1mF9VLA4ad+WVCKHtPLi8k9wXENH/phrj6cZ2eDTM=; b=Cvq62SrIWnlYY39cdJyaNEVpNBj7wLq6QnjDENCNkcpjgK4hjJzPKHiC PPx9gBG83we9Py2dDyAyCT9S1zz+SXbFkn+naWuxcsHco7/vdXaVVHsDt RI2SdHERh5w1RBOqrcpIpcRlj92Vgpp/9NiAClBw0aupTruMbuBScQL+m YtWZ3nN1p2P9FgWd+oRb9cVa7s7MjMaebndGHyWfe8NwNpU5FvxXlqDyl 3AX8wzgOuv6rwFD5lP0yiNmrssK2xp2hwwLrIIrFZRQVtyCXR10xRJZht 64W2aB5drJOPYNVtjwImArVsUsTMSS0wCKsTd20oN29tZ8JHhq8bo4apb A==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Cvq62SrI Subject: [Intel-wired-lan] [PATCH iwl-net v1 0/2] Rework ice Tx checksum X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi, Jakub find the problem with how ice handles Tx checksum offload [1]. The issue is that IP_CSUM/IPV6_CSUM should support only basic packet types. Kernel assumes that if there are extensions headers and there is no HW_CSUM software fallback should be applied. Here is a patch that introduced that [2]. However, software fallback can't be applied when TSO offload happens. That is the situation that this patchset is fixing. When TSO is enabled and IP_CSUM/IPV6_CSUM is on, kernel is assuming hardware will be able to calculate the checksum, but later on the extension headers are checked and if there is no HW_CSUM the skb_bad_offload() is called. Following the documentation ice driver is capable of HW_CSUM support, so switch from IP_CSUM/IPV6_CSUM to HW_CSUM. Other Intel drivers (even previous like i40e, ixgbe) also supports HW_CSUM. The HW_CSUM was used to indicate that GCS (Intel name for checksumming offload using additional descriptor) is support, which is variation of HW_CSUM. Even without GCS th HW_CSUM is supported. First patch is switching to use custom Tx ring flags to allow HW_CSUM usage. [1] https://lore.kernel.org/netdev/20260310150557.1138437-1-jramaseu@redhat.com/ [2] https://lore.kernel.org/all/5fbeecfc311ea182aa1d1c771725ab8b4cac515e.1729778144.git.benoit.monin@gmx.fr/ Michal Swiatkowski (2): ice: always do GCS if hardware supports it ice: use NETIF_F_HW_CSUM instead of IP/IPV6 drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++++ drivers/net/ethernet/intel/ice/ice_main.c | 21 +-------------------- drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- drivers/net/ethernet/intel/ice/ice_txrx.h | 1 + 4 files changed, 7 insertions(+), 21 deletions(-) -- 2.49.0