From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76CBCFF8875 for ; Wed, 29 Apr 2026 10:32:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 37A4C6154A; Wed, 29 Apr 2026 10:32:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vzGki2OCGYVY; Wed, 29 Apr 2026 10:32:24 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6C75061548 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777458744; bh=vxxeK/frimSyziqidYBFVM7MXycT03WdfpbEA8GIFWQ=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=6tMXSoSZeXfra4aYS0FgBP6SYC4b/zIg7M7nAOvluuGhIQtVVjDsVRyXWly64MYqD gn629Rak0khq6aNzUjSSoOAw6a3Dqr196qagNry8TGEZZH63/B5JFZc2DDRRxcmpAu wGt3iwAjZu/dUJgaZi13Hvb3tVEWn6Isyyh/Sno5ZCLR69QRdET/KvwLPqHt3p3bFu jtNX2i3nCk+mHB2vGTnFSw4r/Z6aKmcPTsce2RrdjGrq3GhzsTwgKit6MR15kpAAFA ORtV8yF11+LDxHGJCB0Yq7roK74YjvduLu1E0l6w+T8sJQsdEf7PbxIHjNtQtHrugP KTiBKY+w4udAw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 6C75061548; Wed, 29 Apr 2026 10:32:24 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 2EBEA231 for ; Wed, 29 Apr 2026 10:32:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 148934230C for ; Wed, 29 Apr 2026 10:32:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JITDBv2C0uyr for ; Wed, 29 Apr 2026 10:32:22 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4B80642301 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4B80642301 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4B80642301 for ; Wed, 29 Apr 2026 10:32:22 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9D3E260018; Wed, 29 Apr 2026 10:32:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0034AC19425; Wed, 29 Apr 2026 10:32:17 +0000 (UTC) Date: Wed, 29 Apr 2026 11:32:15 +0100 From: Simon Horman To: Michal Schmidt Message-ID: <20260429103215.GY900403@horms.kernel.org> References: <20260427151827.43342-1-mschmidt@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427151827.43342-1-mschmidt@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777458740; bh=duAsDJqmbqNJ9PlYMKXHs5Ry2vjSnimCTEf03ja5FRg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BDSdjthwmycI1JuMkY+YoDIMxrV1zeGppZFXcAlagvK0BOvUCw0EICd1Da+IjHAqL Nl/cHxSqotsKTTxJZnMV5zmmfot+IhZebTQ2sZqZyVmgzwTnCBs7HiknXhpIJI6M6J O14UMbwWo68lWQHPX24mFeirz8BK84v6OwGSU1IbHzNmiZGH/WH+cagv0FxNZqqY5k Rr9MKZwVGMF89IjlZPsjFmV7I/JLRAmqLteA2SpIh/vtDMJDwHhCtw1UMaPvac1XKY miLFtDFJHCPTjxdY/u3kh1A76JTASCGaYN1kzv0CUD2cwTrZ4qV6ZaSUs5eZJNDsWM 3j3wBk9RUb/BA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BDSdjthw Subject: Re: [Intel-wired-lan] [PATCH net] ice: fix stats array overflow when VF requests more queues X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Przemek Kitszel , linux-kernel@vger.kernel.org, Andrew Lunn , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jacob Keller , Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Apr 27, 2026 at 05:18:26PM +0200, Michal Schmidt wrote: > When a VF increases its queue count via VIRTCHNL_OP_REQUEST_QUEUES, > ice_vc_request_qs_msg() sets vf->num_req_qs and triggers a VF reset. > The reset calls ice_vf_reconfig_vsi(), which does ice_vsi_decfg() > followed by ice_vsi_cfg(). ice_vsi_decfg() does not free the per-ring > stats arrays. Inside ice_vsi_cfg_def(), ice_vsi_set_num_qs() updates > alloc_txq/alloc_rxq to the new larger value, but > ice_vsi_alloc_stat_arrays() returns early because the stats already > exist. ice_vsi_alloc_ring_stats() then iterates using the new larger > alloc_txq and writes beyond the bounds of the old, smaller > tx_ring_stats/rx_ring_stats pointer arrays, corrupting adjacent SLUB > metadata. ... > See the linked RHEL Jira item for a reproducer. > > Fixes: 2a2cb4c6c181 ("ice: replace ice_vf_recreate_vsi() with ice_vf_reconfig_vsi()") > Closes: https://redhat.atlassian.net/browse/RHEL-164321 > Signed-off-by: Michal Schmidt > Assisted-by: Claude:claude-opus-4-6 semcode Reviewed-by: Simon Horman FTR: There is an AI generated review of this patch available on sashiko.dev. I believe the issues flagged there pre-date this patch and do not impact this patch. So while I do not think they should block progress of this patch I suggest looking over them to see if any follow-up is warranted.