From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4029FF8875 for ; Wed, 29 Apr 2026 20:41:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9E68484577; Wed, 29 Apr 2026 20:41:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id lGNcc7Okrr2O; Wed, 29 Apr 2026 20:41:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CED9B84436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777495294; bh=Dombmj9ny0RyT7dLXRXjIRy7HfDUGhjx5FcWbglB77o=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Bf5uxq1udLQzjWoqZyb0BIAxQBxcfvAjhdBbJzRd6ffeiWsZFr3Z8MJH64DDEMXwL OMa2KUEaQlHhqCcY9hAcRiX4X6oxgV5slqF+nCXevaUHq7wDzbQCxcJyLHRszREeNt DZ5NzxnXfV+ytjebIuSwozwUeqed/qwuXfVv8t4ty3t6n8A0L5v3x/Z06e1luuYCSf VX0FaEwamgoQTL+tSQUrsDvfaAzp96bC1dpSRX31cGeSGQtzQYeMRiCiFEScT+w6M4 mnMSG5B/81wOBIhITrhmVFPMGbBJBYYZnuXDro19Q+wzr4T9m39btlEeE4krP0z5xK nHbK3I4xfYorA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id CED9B84436; Wed, 29 Apr 2026 20:41:34 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id B4C9018E for ; Wed, 29 Apr 2026 20:41:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9A8E242622 for ; Wed, 29 Apr 2026 20:41:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ftjwbvQTFe-1 for ; Wed, 29 Apr 2026 20:41:33 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1349; helo=mail-dy1-x1349.google.com; envelope-from=3-2zyaqykd_qxkkhheckkcha.ykiejpah-senaz-hwjheopo.koqkoh.knc@flex--boolli.bounces.google.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org ED7BD42615 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org ED7BD42615 Received: from mail-dy1-x1349.google.com (mail-dy1-x1349.google.com [IPv6:2607:f8b0:4864:20::1349]) by smtp4.osuosl.org (Postfix) with ESMTPS id ED7BD42615 for ; Wed, 29 Apr 2026 20:41:32 +0000 (UTC) Received: by mail-dy1-x1349.google.com with SMTP id 5a478bee46e88-2d93379001eso974335eec.1 for ; Wed, 29 Apr 2026 13:41:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777495292; x=1778100092; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Dombmj9ny0RyT7dLXRXjIRy7HfDUGhjx5FcWbglB77o=; b=NnQdsqjVw43t8hCkLTW37gav+giLGULJgrda1z80x8atp0m3F3FxbTob8aLvkS5W4U tdB+g+LbA4nhwZsxBK8kN8ZiI403gHj450h/ySn6vuWWXIPyVF4cKbtPAxxS8/ooQoKy qJUdCfwnROdei61l8YqV2SFpvdLbQES06rBywgNewUNYnEcgv6Wq38baOJ/koTnk7hEK jh9rvojPwK2UjYde7N7Uef5gYpTqJeffKU6LvA5wtsItXsyQnibBJmwKe3EmUhyhQuRM i6ihKTqkx/4pNyNCGQQPPZXSMe+AwRPs90/vyyFzeFQzdGqC+yMN2Pl+5lwIwTVpMs75 pkBQ== X-Forwarded-Encrypted: i=1; AFNElJ8/ypRD/vNDZ+Q7KMkg7JjlX4LTcfPYb/sSv5lrORoylYiXW7MUHZvUNF0v0DWTpMa5ahoWvfSawkZ0uTkio/U=@lists.osuosl.org X-Gm-Message-State: AOJu0Yxli4eXtoVWc5ikBs+3h2OhXHL/ZrDQdq8gZ75U6GOoc+JfQB3t S+DT03C9I4csF+QdByfWjUrjZm3jryDpRSg2DVE6yYYhgmpzU1dOEMxNHuTtyrV7h/KbIoFccpv Zi6EeKw== X-Received: from dycmd10.prod.google.com ([2002:a05:693c:23ca:b0:2dd:7012:2d3b]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:dc93:b0:2cb:8d2f:e247 with SMTP id 5a478bee46e88-2ed0a099154mr4072247eec.13.1777495291613; Wed, 29 Apr 2026 13:41:31 -0700 (PDT) Date: Wed, 29 Apr 2026 20:41:28 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260429204128.2865817-1-boolli@google.com> To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Type: text/plain; charset="UTF-8" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777495292; x=1778100092; darn=lists.osuosl.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Dombmj9ny0RyT7dLXRXjIRy7HfDUGhjx5FcWbglB77o=; b=aUjB3wq9C3B5olyvGeuL99eQsSG67vwQ9Onop5JXwXoCRlQ2TL1ZvUEDvOzaQ7+9fN CCYv9t49Je1qYOiTP6TUUUmWuLEZRqynXrEbMDv3zJtrmKG5fGaTizPtPM/f4UZGJAT7 cxLIt3PjQjVdiE5jvcgaC8cCeF4aq094xw6WiY8OmEwiiTSRwcc6V4/b1RRf+j174Xts YVJjT/iNzQq761CniEyQyADtFvajlDUkNkziYhabcMC2OFDZTuGP2DFOYLchW7rUikPj 6a0r0p4MCzsjFKekPzJcEABbBUKs668X6AdDHnQogVvfGJGFPjYA1kWC3diHCGnLGfEq eZXA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=reject dis=none) header.from=google.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=aUjB3wq9 Subject: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when virtchnl fails X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Li Li via Intel-wired-lan Reply-To: Li Li Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Virtchnl failures can be hard to debug without logs. Logging the details of virtchnl transactions can be useful for debugging virtchnl-related issues. Tested: Built & booted on a test machine and synthetically produced a virtual failure to produce the following log: idpf 0000:01:00.0: Non-zero virtchnl ret val (msg op: 1, ret val: 6, data_len: 8); xn id: 0, cookie: 0 idpf 0000:01:00.0: Transaction failed (op 1, xn state: 3, id: 0, cookie: 0, size: 8) Signed-off-by: Li Li --- v3: - Use dev_err_ratelimited in both logs. - Move log placement to after virtchnl field validation. - Remove redundant op/cookie fields since they were validated. v2: - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on reviewer feedback. drivers/net/ethernet/intel/libie/controlq.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c index ebc05355e39d..ceca8a076d79 100644 --- a/drivers/net/ethernet/intel/libie/controlq.c +++ b/drivers/net/ethernet/intel/libie/controlq.c @@ -766,6 +766,14 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params, msg_cookie != xn->cookie) return false; + if (ctlq_msg->chnl_retval) { + dev_err_ratelimited( + params->ctlq->dev, + "Non-zero virtchnl ret val (msg op: %u, ret val: %u, data_len: %u); xn id: %u, cookie: %u\n", + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval, + ctlq_msg->data_len, xn->index, xn->cookie); + } + spin_lock(&xn->xn_lock); if (xn->state != LIBIE_CTLQ_XN_ASYNC && xn->state != LIBIE_CTLQ_XN_WAITING) { @@ -1011,6 +1019,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params) params->recv_mem = xn->recv_mem; break; default: + dev_err_ratelimited( + params->ctlq->dev, + "Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu)\n", + params->chnl_opcode, xn->state, xn->index, xn->cookie, + xn->recv_mem.iov_len); ret = -EBADMSG; break; } -- 2.54.0.545.g6539524ca2-goog